From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
devicetree@vger.kernel.org
Cc: robdclark@gmail.com, quic_abhinavk@quicinc.com,
dmitry.baryshkov@linaro.org, sean@poorly.run, airlied@gmail.com,
daniel@ffwll.ch, robh+dt@kernel.org, dianders@chromium.org,
david@ixit.cz, krzysztof.kozlowski+dt@linaro.org,
swboyd@chromium.org, konrad.dybcio@somainline.org,
agross@kernel.org, andersson@kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
bryan.odonoghue@linaro.org, Rob Herring <robh@kernel.org>
Subject: [PATCH v6 06/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in
Date: Fri, 23 Dec 2022 02:10:13 +0000 [thread overview]
Message-ID: <20221223021025.1646636-7-bryan.odonoghue@linaro.org> (raw)
In-Reply-To: <20221223021025.1646636-1-bryan.odonoghue@linaro.org>
When converting from .txt to .yaml we didn't include descriptions for the
existing regulator supplies.
- vdd
- vdda
- vddio
Add those descriptions into the yaml now as they were prior to the
conversion. In the .txt description we marked these regulators as required,
however, that requirement appears to have been in error.
Taking the example of sc7180-trogdor-wormdingler.dtsi. The avdd and avee
come from GPIO controlled external regulators, not the SoC and in this case
there's no need for vddio to power an I/O bus. Similarly the regulators for
the LCD are controlled by the panel driver not by the dsi-ctrl driver.
It would be possible to connect a different type of panel to the DSI bus
here in which case we may or may not want to make use of vdd, vdda or
vddio.
This is also the case for older chipsets like apq8064, msm8916 etc the vdd*
regulators in the dsi-ctrl block are helpers not dependencies.
Add the description of vdd, vdda and vddio back in for the existing
upstream dts where vdd, vdda or vddio are already declared but, don't
declare those regulators required - they are not SoC requirements.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../bindings/display/msm/dsi-controller-main.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index 4b79b31123515..3144699e20a08 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -143,6 +143,18 @@ properties:
- port@0
- port@1
+ vdd-supply:
+ description:
+ VDD regulator
+
+ vddio-supply:
+ description:
+ VDD-IO regulator
+
+ vdda-supply:
+ description:
+ VDDA regulator
+
required:
- compatible
- reg
--
2.38.1
next prev parent reply other threads:[~2022-12-23 2:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 2:10 [PATCH v6 00/18] mdss-dsi-ctrl binding and dts fixes Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 01/18] dt-bindings: msm: dsi-controller-main: Fix operating-points-v2 constraint Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 02/18] dt-bindings: msm: dsi-controller-main: Fix power-domain constraint Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 03/18] dt-bindings: msm: dsi-controller-main: Fix description of core clock Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 04/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC Bryan O'Donoghue
2023-01-10 5:48 ` Dmitry Baryshkov
2022-12-23 2:10 ` [PATCH v6 05/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis Bryan O'Donoghue
2023-01-10 5:47 ` Dmitry Baryshkov
2022-12-23 2:10 ` Bryan O'Donoghue [this message]
2022-12-23 2:10 ` [PATCH v6 07/18] dt-bindings: display/msm: Add list of mdss-dsi-ctrl compats Bryan O'Donoghue
2023-01-04 0:29 ` Rob Herring
2023-01-04 9:37 ` Dmitry Baryshkov
2022-12-23 2:10 ` [PATCH v6 08/18] ARM: dts: qcom: apq8064: add compat qcom,apq8064-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 09/18] ARM: dts: qcom: msm8974: Add compat qcom,msm8974-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 10/18] arm64: dts: qcom: msm8916: Add compat qcom,msm8916-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 11/18] arm64: dts: qcom: msm8953: Add compat qcom,msm8953-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 12/18] arm64: dts: qcom: msm8996: Add compat qcom,msm8996-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 13/18] arm64: dts: qcom: sc7180: Add compat qcom,sc7180-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 14/18] arm64: dts: qcom: sc7280: Add compat qcom,sc7280-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 15/18] arm64: dts: qcom: sdm630: Add compat qcom,sdm660-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 16/18] arm64: dts: qcom: sdm660: " Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 17/18] arm64: dts: qcom: sdm845: Add compat qcom,sdm845-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 18/18] arm64: dts: qcom: sm8250: Add compat qcom,sm8250-dsi-ctrl Bryan O'Donoghue
2022-12-29 17:23 ` (subset) [PATCH v6 00/18] mdss-dsi-ctrl binding and dts fixes Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221223021025.1646636-7-bryan.odonoghue@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).