linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
	Stephen Boyd <swboyd@chromium.org>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Bjorn Andersson <andersson@kernel.org>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org,
	Neil Armstrong <neil.armstrong@linaro.org>
Subject: [PATCH v2 1/6] drm/msm/dpu: don't set DPU_INTF_TE globally
Date: Tue, 23 May 2023 00:45:22 +0300	[thread overview]
Message-ID: <20230522214527.190054-2-dmitry.baryshkov@linaro.org> (raw)
In-Reply-To: <20230522214527.190054-1-dmitry.baryshkov@linaro.org>

Using BIT(DPU_INTF_TE) in INTF_SC7180_MASK (and by extension in
INTF_SC7280_MASK) results in this bit (and corrsponding operations)
being enabled for all interfaces, even the ones which do not have TE
block. Move this bit setting to INTF_DSI_TE(), so that it is only
enabled for those INTF blocks which have TE support.

Fixes: 152c1d430992 ("drm/msm/dpu: Add TEAR-READ-pointer interrupt to INTF block")
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
index 1dee5ba2b312..162141cb5c83 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
@@ -101,7 +101,6 @@
 
 #define INTF_SC7180_MASK \
 	(BIT(DPU_INTF_INPUT_CTRL) | \
-	 BIT(DPU_INTF_TE) | \
 	 BIT(DPU_INTF_STATUS_SUPPORTED) | \
 	 BIT(DPU_DATA_HCTL_EN))
 
@@ -544,7 +543,7 @@ static const struct dpu_pingpong_sub_blks sc7280_pp_sblk = {
 	{\
 	.name = _name, .id = _id, \
 	.base = _base, .len = _len, \
-	.features = _features, \
+	.features = _features | BIT(DPU_INTF_TE), \
 	.type = _type, \
 	.controller_id = _ctrl_id, \
 	.prog_fetch_lines_worst_case = _progfetch, \
-- 
2.39.2


  reply	other threads:[~2023-05-22 21:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-22 21:45 [PATCH v2 0/6] drm/msm/dpu: rework interrupt handling Dmitry Baryshkov
2023-05-22 21:45 ` Dmitry Baryshkov [this message]
2023-05-22 21:56   ` [PATCH v2 1/6] drm/msm/dpu: don't set DPU_INTF_TE globally Marijn Suijten
2023-05-22 22:01     ` Dmitry Baryshkov
2023-05-22 22:24       ` Marijn Suijten
2023-05-22 23:03   ` Marijn Suijten
2023-05-22 21:45 ` [PATCH v2 2/6] drm/msm/dpu: inline __intr_offset Dmitry Baryshkov
2023-05-22 21:57   ` Marijn Suijten
2023-05-22 21:45 ` [PATCH v2 3/6] drm/msm/dpu: split interrupt address arrays Dmitry Baryshkov
2023-05-22 22:04   ` Marijn Suijten
2023-05-25 21:40   ` [Freedreno] " Jeykumar Sankaran
2023-05-25 22:30     ` Dmitry Baryshkov
2023-05-25 22:42       ` Abhinav Kumar
2023-05-26  8:43         ` Dmitry Baryshkov
2023-05-26 18:03           ` Abhinav Kumar
2023-05-26  8:48   ` Neil Armstrong
2023-05-22 21:45 ` [PATCH v2 4/6] drm/msm/dpu: autodetect supported interrupts Dmitry Baryshkov
2023-05-22 22:12   ` Marijn Suijten
2023-05-22 22:17     ` Dmitry Baryshkov
2023-05-22 22:20       ` Marijn Suijten
2023-05-22 21:45 ` [PATCH v2 5/6] drm/msm/dpu: drop now-unused mdss_irqs field from hw catalog Dmitry Baryshkov
2023-05-22 22:15   ` Marijn Suijten
2023-05-22 22:18     ` Dmitry Baryshkov
2023-05-22 21:45 ` [PATCH v2 6/6] drm/msm/dpu: drop compatibility INTR defines Dmitry Baryshkov
2023-05-22 22:21   ` Marijn Suijten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230522214527.190054-2-dmitry.baryshkov@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).