From: Bjorn Andersson <quic_bjorande@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 3/3] soc: qcom: rtmfs: Handle reserved-memory allocation issues
Date: Tue, 30 May 2023 16:36:43 -0700 [thread overview]
Message-ID: <20230530233643.4044823-4-quic_bjorande@quicinc.com> (raw)
In-Reply-To: <20230530233643.4044823-1-quic_bjorande@quicinc.com>
In the even that Linux failed to allocate the reserved memory range
specified in the DeviceTree, the size of the reserved_mem will be 0,
which results in a oops when memory remapping is attempted.
Detect this and report that the memory region was not found instead.
Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
Changes since v1:
- New patch
drivers/soc/qcom/rmtfs_mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c
index 28238974d913..e3a55fa041f9 100644
--- a/drivers/soc/qcom/rmtfs_mem.c
+++ b/drivers/soc/qcom/rmtfs_mem.c
@@ -180,7 +180,7 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev)
int ret, i;
rmem = of_reserved_mem_lookup(node);
- if (!rmem) {
+ if (!rmem || !rmem->size) {
dev_err(&pdev->dev, "failed to acquire memory region\n");
return -EINVAL;
}
--
2.25.1
prev parent reply other threads:[~2023-05-30 23:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 23:36 [PATCH v2 0/3] soc: qcom: rmtfs: Support dynamic allocation Bjorn Andersson
2023-05-30 23:36 ` [PATCH v2 1/3] dt-bindings: reserved-memory: rmtfs: Allow guard pages Bjorn Andersson
2023-06-01 12:34 ` Stephan Gerhold
2023-06-04 10:25 ` Krzysztof Kozlowski
2023-05-30 23:36 ` [PATCH v2 2/3] soc: qcom: rmtfs: Support discarding " Bjorn Andersson
2023-05-31 0:08 ` Caleb Connolly
2023-05-31 0:09 ` Caleb Connolly
2023-06-01 12:26 ` Stephan Gerhold
2023-05-30 23:36 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530233643.4044823-4-quic_bjorande@quicinc.com \
--to=quic_bjorande@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).