From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81E70C7EE2E for ; Wed, 7 Jun 2023 20:50:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234784AbjFGUuZ (ORCPT ); Wed, 7 Jun 2023 16:50:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235060AbjFGUtp (ORCPT ); Wed, 7 Jun 2023 16:49:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD99B2130; Wed, 7 Jun 2023 13:49:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8DADE646E4; Wed, 7 Jun 2023 20:49:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA98AC433D2; Wed, 7 Jun 2023 20:49:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686170965; bh=yIQkALqfpk76Ao9CbRynGfkR9SerCGob88NMbCbX+9A=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=CYKPa6UBTMgPrPiN9HALK3dfzw30muDr1RYpAq8vN7hvUHrtbmH8c2SWq8oGrqHia 8wxVvUe5TM4kQXF233PTjr4TUYPIGhOmus7i/c4bJiESw7JXT3j6rMfehECb0W6zYc JN91GxRbjjXCxXZZAEUyeW5dZr98CNe0DP5WMsqTT6VcgV3YDAzoOjGaDtr0XQTs3E VarfIXjpKKIEgBfIlUoZfW6DZOa12Tiz5CDVewzlInj6nbrMgC4ESMLrYxDexRrpVS X8kzoXGMOXiGo9pAWj66w01yXzdGL/rCQ+sXS2yEQW0KiJbNWmZ1uhek7FHpcm0xGA lh4o8tn1mqI9Q== Date: Wed, 7 Jun 2023 15:49:23 -0500 From: Bjorn Helgaas To: Manivannan Sadhasivam Cc: lpieralisi@kernel.org, kw@linux.com, kishon@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dlemoal@kernel.org Subject: Re: [PATCH v6 8/9] PCI: endpoint: Add PCI Endpoint function driver for MHI bus Message-ID: <20230607204923.GA1174664@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230602114756.36586-9-manivannan.sadhasivam@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Jun 02, 2023 at 05:17:55PM +0530, Manivannan Sadhasivam wrote: > Add PCI Endpoint driver for the Qualcomm MHI (Modem Host Interface) bus. > The driver implements the MHI function over PCI in the endpoint device > such as SDX55 modem. The MHI endpoint function driver acts as a > controller driver for the MHI Endpoint stack and carries out all PCI > related activities like mapping the host memory using iATU, triggering > MSIs etc... > ... > +static int pci_epf_mhi_bind(struct pci_epf *epf) > +{ > ... > + ret = platform_get_irq_byname(pdev, "doorbell"); > + if (ret < 0) { > + dev_err(dev, "Failed to get Doorbell IRQ\n"); This dev_err() causes this new warning from the 0-day robot [1]: drivers/pci/endpoint/functions/pci-epf-mhi.c:362:2-9: line 362 is redundant because platform_get_irq() already prints an error Maybe we could drop it? Bjorn [1] https://lore.kernel.org/all/20230607163937.ZTc-D%25lkp@intel.com/