From: Bjorn Helgaas <helgaas@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: lpieralisi@kernel.org, kw@linux.com, kishon@kernel.org,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
dlemoal@kernel.org, Yang Li <yang.lee@linux.alibaba.com>
Subject: Re: [PATCH v6 8/9] PCI: endpoint: Add PCI Endpoint function driver for MHI bus
Date: Wed, 7 Jun 2023 16:19:41 -0500 [thread overview]
Message-ID: <20230607211941.GA1176583@bhelgaas> (raw)
In-Reply-To: <20230607204923.GA1174664@bhelgaas>
[+cc Yang Li, sorry I didn't notice your patch earlier:
https://lore.kernel.org/r/20230607093514.104012-1-yang.lee@linux.alibaba.com]
I think we can squash this into the original commit since it hasn't
gone upstream yet. Also note that removing the dev_err() apparently
makes "dev" unused, so we'd have to remove that as well, based on this
report [2].
[2] https://lore.kernel.org/r/202306080418.i64hTj5T-lkp@intel.com
On Wed, Jun 07, 2023 at 03:49:25PM -0500, Bjorn Helgaas wrote:
> On Fri, Jun 02, 2023 at 05:17:55PM +0530, Manivannan Sadhasivam wrote:
> > Add PCI Endpoint driver for the Qualcomm MHI (Modem Host Interface) bus.
> > The driver implements the MHI function over PCI in the endpoint device
> > such as SDX55 modem. The MHI endpoint function driver acts as a
> > controller driver for the MHI Endpoint stack and carries out all PCI
> > related activities like mapping the host memory using iATU, triggering
> > MSIs etc...
> > ...
>
> > +static int pci_epf_mhi_bind(struct pci_epf *epf)
> > +{
> > ...
>
> > + ret = platform_get_irq_byname(pdev, "doorbell");
> > + if (ret < 0) {
> > + dev_err(dev, "Failed to get Doorbell IRQ\n");
>
> This dev_err() causes this new warning from the 0-day robot [1]:
>
> drivers/pci/endpoint/functions/pci-epf-mhi.c:362:2-9: line 362 is redundant because platform_get_irq() already prints an error
>
> Maybe we could drop it?
>
> Bjorn
>
> [1] https://lore.kernel.org/all/20230607163937.ZTc-D%25lkp@intel.com/
next prev parent reply other threads:[~2023-06-07 21:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 11:47 [PATCH v6 0/9] Add support for MHI Endpoint function driver Manivannan Sadhasivam
2023-06-02 11:47 ` [PATCH v6 1/9] PCI: endpoint: Add missing documentation about the MSI/MSI-X range Manivannan Sadhasivam
2023-06-02 11:47 ` [PATCH v6 2/9] PCI: endpoint: Pass EPF device ID to the probe function Manivannan Sadhasivam
2023-06-02 12:13 ` Damien Le Moal
2023-06-05 13:08 ` Lorenzo Pieralisi
2023-06-05 13:55 ` Manivannan Sadhasivam
2023-06-05 9:27 ` Lorenzo Pieralisi
2023-06-05 11:57 ` Manivannan Sadhasivam
2023-06-05 13:06 ` Lorenzo Pieralisi
2023-06-23 20:14 ` Bjorn Helgaas
2023-06-02 11:47 ` [PATCH v6 3/9] PCI: endpoint: Return error if EPC is started/stopped multiple times Manivannan Sadhasivam
2023-06-02 12:14 ` Damien Le Moal
2023-06-02 11:47 ` [PATCH v6 4/9] PCI: endpoint: Add linkdown notifier support Manivannan Sadhasivam
2023-06-02 11:47 ` [PATCH v6 5/9] PCI: endpoint: Add BME " Manivannan Sadhasivam
2023-06-02 11:47 ` [PATCH v6 6/9] PCI: qcom-ep: Add support for Link down notification Manivannan Sadhasivam
2023-06-02 11:47 ` [PATCH v6 7/9] PCI: qcom-ep: Add support for BME notification Manivannan Sadhasivam
2023-06-02 11:47 ` [PATCH v6 8/9] PCI: endpoint: Add PCI Endpoint function driver for MHI bus Manivannan Sadhasivam
2023-06-07 20:49 ` Bjorn Helgaas
2023-06-07 21:19 ` Bjorn Helgaas [this message]
2023-06-08 16:35 ` Manivannan Sadhasivam
2023-06-09 7:53 ` Lorenzo Pieralisi
2023-06-02 11:47 ` [PATCH v6 9/9] MAINTAINERS: Add PCI MHI endpoint function driver under " Manivannan Sadhasivam
2023-06-02 12:15 ` Damien Le Moal
2023-06-05 14:45 ` [PATCH v6 0/9] Add support for MHI Endpoint function driver Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607211941.GA1176583@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=dlemoal@kernel.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).