From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC5CDC7EE25 for ; Thu, 8 Jun 2023 16:36:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234021AbjFHQgk (ORCPT ); Thu, 8 Jun 2023 12:36:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235855AbjFHQgh (ORCPT ); Thu, 8 Jun 2023 12:36:37 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9169419B for ; Thu, 8 Jun 2023 09:36:05 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-53f70f7c2d2so430930a12.3 for ; Thu, 08 Jun 2023 09:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686242140; x=1688834140; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=/aL6Mm02RP068H18Hmx+R64BHyyt5ervIsVqvJjdt9Q=; b=JdAw6Mq860YRQRBQswOEjzf4ISFKIXDDTQ9l5+MNDNoF1EZ0S1jAnlfVQnp3wSTKLf kIrgXpITkuDawG2u8CMycorgDxUFVpWL5x1rcK5SeXYILykhJu1cXysOOYEBWsf1+54K 32y2qYyO5wU2TOJDEUoYhqc8bbZJM5oNqSKnGWCnfcxnHH8u/7B6Lo1a36cGs7EA/G5B 3OkmjlYhcoeo4hKxgvF2KxE7/KIW/UK3Zmbd6bpnWLGT6nnhkm2JrYf3WTfykpUuO6Em Vyn0hKWWcGz0IA4xb7O2uCHk7PWP//aDpb9qwosyCGupjN0eqeIhjN3y6D7jQR6D7iwe JtTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686242140; x=1688834140; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/aL6Mm02RP068H18Hmx+R64BHyyt5ervIsVqvJjdt9Q=; b=cpApisbD5ayMbxfyqNeGYRBEOHpGwIXT2STer4bchEVBCCrzL8myWL1rOTzHB7j/6A Dttm41AcMB0HgqyrNuvAL3XF9svf7b1h8l/FI0mgPQb7w1lY3Xvs2XVgZslTE1TfoQK4 bKYhFJ8ATH7XinT6iEDo4v8Qj7BFu+6BBDOdxlWOzzscJblnW1olk7uR9J7SZ2u4f4Sx pp9pLAIzvnsiNJFnDJJD5lZ9ttOMlQk/EVKqtRTFoH/GuDwDNwlQB9P5wX+NcFOZ7YcI 8rBBmzBOft8XKf+AS0O3NvpKEL89zFyEqzptrKEz68haESH0J8FxyETO15QZUtOfQc/2 LXKg== X-Gm-Message-State: AC+VfDw6SM16gMZsi5NkN+fhgXyt8V0RdHm+tWzLgSB2U5Ur98FIzHQL lC5ZaHZy2ILeQ9fs677KB+qw X-Google-Smtp-Source: ACHHUZ41Md8JiH2gX2B8B2vO1CwrgtpmT9DH0nhknBHBFZk41hPsvipEwYYD0QPAAbP64J2nbjYOZQ== X-Received: by 2002:a17:902:e54b:b0:1a9:9ace:3e74 with SMTP id n11-20020a170902e54b00b001a99ace3e74mr5073873plf.65.1686242140125; Thu, 08 Jun 2023 09:35:40 -0700 (PDT) Received: from thinkpad ([117.202.186.138]) by smtp.gmail.com with ESMTPSA id z11-20020a1709027e8b00b001b0295de9acsm1656054pla.179.2023.06.08.09.35.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 09:35:39 -0700 (PDT) Date: Thu, 8 Jun 2023 22:05:29 +0530 From: Manivannan Sadhasivam To: Bjorn Helgaas Cc: lpieralisi@kernel.org, kw@linux.com, kishon@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dlemoal@kernel.org, Yang Li Subject: Re: [PATCH v6 8/9] PCI: endpoint: Add PCI Endpoint function driver for MHI bus Message-ID: <20230608163529.GD8632@thinkpad> References: <20230607204923.GA1174664@bhelgaas> <20230607211941.GA1176583@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230607211941.GA1176583@bhelgaas> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Jun 07, 2023 at 04:19:41PM -0500, Bjorn Helgaas wrote: > [+cc Yang Li, sorry I didn't notice your patch earlier: > https://lore.kernel.org/r/20230607093514.104012-1-yang.lee@linux.alibaba.com] > > I think we can squash this into the original commit since it hasn't > gone upstream yet. Also note that removing the dev_err() apparently > makes "dev" unused, so we'd have to remove that as well, based on this > report [2]. > > [2] https://lore.kernel.org/r/202306080418.i64hTj5T-lkp@intel.com > > On Wed, Jun 07, 2023 at 03:49:25PM -0500, Bjorn Helgaas wrote: > > On Fri, Jun 02, 2023 at 05:17:55PM +0530, Manivannan Sadhasivam wrote: > > > Add PCI Endpoint driver for the Qualcomm MHI (Modem Host Interface) bus. > > > The driver implements the MHI function over PCI in the endpoint device > > > such as SDX55 modem. The MHI endpoint function driver acts as a > > > controller driver for the MHI Endpoint stack and carries out all PCI > > > related activities like mapping the host memory using iATU, triggering > > > MSIs etc... > > > ... > > > > > +static int pci_epf_mhi_bind(struct pci_epf *epf) > > > +{ > > > ... > > > > > + ret = platform_get_irq_byname(pdev, "doorbell"); > > > + if (ret < 0) { > > > + dev_err(dev, "Failed to get Doorbell IRQ\n"); > > > > This dev_err() causes this new warning from the 0-day robot [1]: > > > > drivers/pci/endpoint/functions/pci-epf-mhi.c:362:2-9: line 362 is redundant because platform_get_irq() already prints an error > > > > Maybe we could drop it? > > Right. I think Lorenzo can handle both while squashing. - Mani > > Bjorn > > > > [1] https://lore.kernel.org/all/20230607163937.ZTc-D%25lkp@intel.com/ -- மணிவண்ணன் சதாசிவம்