From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EDDDC7618B for ; Wed, 24 Jul 2019 11:16:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0EAC3229FA for ; Wed, 24 Jul 2019 11:16:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726681AbfGXLQx (ORCPT ); Wed, 24 Jul 2019 07:16:53 -0400 Received: from ns.iliad.fr ([212.27.33.1]:56064 "EHLO ns.iliad.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726070AbfGXLQw (ORCPT ); Wed, 24 Jul 2019 07:16:52 -0400 Received: from ns.iliad.fr (localhost [127.0.0.1]) by ns.iliad.fr (Postfix) with ESMTP id A083C20609; Wed, 24 Jul 2019 13:16:50 +0200 (CEST) Received: from [192.168.108.49] (freebox.vlq16.iliad.fr [213.36.7.13]) by ns.iliad.fr (Postfix) with ESMTP id 88C652018B; Wed, 24 Jul 2019 13:16:50 +0200 (CEST) Subject: Re: [PATCH] arm64: dts: qcom: msm8998: Node ordering, address cleanups To: Jeffrey Hugo , Andy Gross , Bjorn Andersson Cc: Rob Herring , Mark Rutland , MSM , DT , LKML References: <20190722165823.21539-1-jeffrey.l.hugo@gmail.com> From: Marc Gonzalez Message-ID: <2165bbd3-aa60-bec0-4ee7-dfb7dc1dd1ad@free.fr> Date: Wed, 24 Jul 2019 13:16:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190722165823.21539-1-jeffrey.l.hugo@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP ; ns.iliad.fr ; Wed Jul 24 13:16:50 2019 +0200 (CEST) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 22/07/2019 18:58, Jeffrey Hugo wrote: > DT nodes should be ordered by address, then node name, and finally label. > The msm8998 dtsi does not follow this, so clean it up by reordering the > nodes. While we are at it, extend the addresses to be fully 32-bits wide > so that ordering is easy to determine when adding new nodes. Also, two > or so nodes had the wrong address value in their node name (did not match > the reg property), so fix those up as well. > > Hopefully going forward, things can be maintained so that a cleanup like > this is not needed. > > Signed-off-by: Jeffrey Hugo > --- > arch/arm64/boot/dts/qcom/msm8998.dtsi | 254 +++++++++++++------------- > 1 file changed, 127 insertions(+), 127 deletions(-) LGTM. Reviewed-by: Marc Gonzalez Rob, Mark: when there are multiple reg properties, why is the convention to use the *first* address in the node's name, rather than the lowest address? e.g. spmi_bus: spmi@800f000 { compatible = "qcom,spmi-pmic-arb"; reg = <0x0800f000 0x1000>, <0x08400000 0x1000000>, <0x09400000 0x1000000>, <0x0a400000 0x220000>, <0x0800a000 0x3000>; reg-names = "core", "chnls", "obsrvr", "intr", "cnfg"; "spmi@800f000" instead of "spmi@800a000" Especially, since the reg props could be in any order here, given the lookup by name. Regards.