linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	agross@kernel.org, bjorn.andersson@linaro.org,
	lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
	plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz,
	tiwai@suse.com, rohitkr@codeaurora.org,
	linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Subject: Re: [PATCH] Asoc: qcom: lpass-sc7180: Fix MI2S bitwidth field bit positions
Date: Mon, 26 Oct 2020 21:34:32 +0530	[thread overview]
Message-ID: <242284b2-ca3f-fbe0-af97-c0e8e5fe640d@codeaurora.org> (raw)
In-Reply-To: <335f1d55-8a85-8501-fd69-0397f44e21af@linaro.org>

Thanks for your time srinivas!!!

On 10/26/2020 8:31 PM, Srinivas Kandagatla wrote:
>
>
> On 22/10/2020 14:26, Srinivasa Rao Mandadapu wrote:
>> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
>>
>> Update SC7180 lpass_variant structure with proper I2S bitwidth
>> field bit positions, as bitwidth denotes 0 to 1 bits,
>> but previously used only 0 bit.
>>
>> Fixes: commit cba62c8b49bead ("Merge series "ASoC: qcom: Add support 
>> for SC7180 lpass variant" from Rohit kumar <rohitkr@codeaurora.org>:")
> this should be 12 chars long, for this particular fix it should be!
>
> Fixes: 24caf8d9eb108 ("ASoC: qcom: lpass-sc7180: Add platform driver 
> for lpass audio")
>>
>
> No empty line after Fixes tag!
>
> Will coorect it in next patch.

>> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
>> ---
>>   sound/soc/qcom/lpass-sc7180.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/qcom/lpass-sc7180.c 
>> b/sound/soc/qcom/lpass-sc7180.c
>> index c6292f9e..bc998d5 100644
>> --- a/sound/soc/qcom/lpass-sc7180.c
>> +++ b/sound/soc/qcom/lpass-sc7180.c
>> @@ -188,7 +188,7 @@ static struct lpass_variant sc7180_data = {
>>       .micmode        = REG_FIELD_ID(0x1000, 4, 8, 3, 0x1000),
>>       .micmono        = REG_FIELD_ID(0x1000, 3, 3, 3, 0x1000),
>>       .wssrc            = REG_FIELD_ID(0x1000, 2, 2, 3, 0x1000),
>> -    .bitwidth        = REG_FIELD_ID(0x1000, 0, 0, 3, 0x1000),
>> +    .bitwidth        = REG_FIELD_ID(0x1000, 0, 1, 3, 0x1000),
>>         .rdma_dyncclk        = REG_FIELD_ID(0xC000, 21, 21, 5, 0x1000),
>>       .rdma_bursten        = REG_FIELD_ID(0xC000, 20, 20, 5, 0x1000),
>>
> --srini

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


      reply	other threads:[~2020-10-26 16:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-22 13:26 [PATCH] Asoc: qcom: lpass-sc7180: Fix MI2S bitwidth field bit positions Srinivasa Rao Mandadapu
2020-10-26 15:01 ` Srinivas Kandagatla
2020-10-26 16:04   ` Srinivasa Rao Mandadapu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=242284b2-ca3f-fbe0-af97-c0e8e5fe640d@codeaurora.org \
    --to=srivasam@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=plai@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=rohitkr@codeaurora.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    --cc=vsujithk@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).