From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH] soc: qcom: update config dependencies for QCOM_RPMPD Date: Mon, 21 Jan 2019 21:08:25 -0800 Message-ID: <25f46403-e78e-271b-c4d0-13b4623846b3@roeck-us.net> References: <20190118044801.7312-1-rnayak@codeaurora.org> <154783318835.169631.6614930101893188915@swboyd.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Rajendra Nayak , Stephen Boyd , andy.gross@linaro.org, david.brown@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On 1/21/19 6:30 PM, Rajendra Nayak wrote: > > > On 1/18/2019 11:09 PM, Stephen Boyd wrote: >> Quoting Rajendra Nayak (2019-01-17 20:48:01) >>>   drivers/soc/qcom/Kconfig | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig >>> index a5d5167c3f16..1ee298f6bf17 100644 >>> --- a/drivers/soc/qcom/Kconfig >>> +++ b/drivers/soc/qcom/Kconfig >>> @@ -109,7 +109,7 @@ config QCOM_RPMHPD >>>   config QCOM_RPMPD >>>          bool "Qualcomm RPM Power domain driver" >> >> Just curious, does it need to be bool for some reason? > > Here's the link to the discussion around it on the v3 patchset of this series > https://lkml.org/lkml/2018/6/12/111 > I think you were missing the implication of "if possible", the implication being that the driver can now not be used in a multi-platform image, and that having a bool driver depend on tristate drivers doesn't make much if any sense. The argument in the exchange is odd - one can not remove any driver as long there are client drivers / devices attached to it. This is true for all drivers, not just for this one, and handled quite nicely by the driver core. Just run "lsmod" and try to remove a driver with any attached users. Guenter