linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org
Cc: bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	agross@kernel.org, herbert@gondor.apana.org.au,
	davem@davemloft.net, Bjorn Andersson <bjorn.andersson@linaro.org>,
	Thara Gopinath <thara.gopinath@linaro.org>
Subject: Re: [PATCH v4 17/20] crypto: qce: Print a failure msg in case probe() fails
Date: Wed, 13 Oct 2021 22:26:20 +0300	[thread overview]
Message-ID: <2699de22-4943-685f-5700-82137a4326ae@linaro.org> (raw)
In-Reply-To: <20211013105541.68045-18-bhupesh.sharma@linaro.org>

Hi Bhupesh,

On 10/13/21 1:55 PM, Bhupesh Sharma wrote:
> Print a failure message (dev_err) in case the qcom qce crypto
> driver probe() fails.
> 
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
>   drivers/crypto/qce/core.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c
> index 576c416461f9..cb8c77709e1e 100644
> --- a/drivers/crypto/qce/core.c
> +++ b/drivers/crypto/qce/core.c
> @@ -281,6 +281,8 @@ static int qce_crypto_probe(struct platform_device *pdev)
>   	icc_set_bw(qce->mem_path, 0, 0);
>   err_mem_path_put:
>   	icc_put(qce->mem_path);
> +
> +	dev_err(dev, "%s failed : %d\n", __func__, ret);
>   	return ret;
>   }
>   

As for me the rationale of this change is quite non-obvious, a user is well
informed, if a driver probe fails. I would rather ask you to consider to
drop this change.

--
Best wishes,
Vladimir

  reply	other threads:[~2021-10-13 19:26 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13 10:55 [PATCH v4 00/20] Enable Qualcomm Crypto Engine on sm8250 Bhupesh Sharma
2021-10-13 10:55 ` [PATCH v4 01/20] arm64/dts: qcom: Fix 'dma' & 'qcom,controlled-remotely' nodes in dts Bhupesh Sharma
2021-10-13 10:55 ` [PATCH v4 02/20] arm64/dts: qcom: ipq6018: Remove unused 'qcom,config-pipe-trust-reg' property Bhupesh Sharma
2021-10-13 10:55 ` [PATCH v4 03/20] arm64/dts: qcom: ipq6018: Remove unused 'iface_clk' property from dma-controller node Bhupesh Sharma
2021-10-13 10:55 ` [PATCH v4 04/20] dt-bindings: qcom-bam: Convert binding to YAML Bhupesh Sharma
2021-10-13 12:56   ` Vladimir Zapolskiy
2021-10-13 17:13     ` Bhupesh Sharma
2021-10-13 10:55 ` [PATCH v4 05/20] dt-bindings: qcom-bam: Add 'interconnects' & 'interconnect-names' to optional properties Bhupesh Sharma
2021-10-13 13:03   ` Vladimir Zapolskiy
2021-10-13 17:14     ` Bhupesh Sharma
2021-10-13 18:39   ` Rob Herring
2021-10-14  7:03     ` Bhupesh Sharma
2021-10-24 13:55       ` Bhupesh Sharma
2021-10-13 10:55 ` [PATCH v4 06/20] dt-bindings: qcom-bam: Add 'iommus' " Bhupesh Sharma
2021-10-13 10:55 ` [PATCH v4 07/20] dt-bindings: qcom-qce: Convert bindings to yaml Bhupesh Sharma
2021-10-13 13:05   ` Vladimir Zapolskiy
2021-10-13 17:15     ` Bhupesh Sharma
2021-10-13 10:55 ` [PATCH v4 08/20] dt-bindings: qcom-qce: Add 'interconnects' and move 'clocks' to optional properties Bhupesh Sharma
2021-10-26 19:40   ` Rob Herring
2021-10-13 10:55 ` [PATCH v4 09/20] dt-bindings: qcom-qce: Add 'iommus' " Bhupesh Sharma
2021-10-26 19:40   ` Rob Herring
2021-10-13 10:55 ` [PATCH v4 10/20] arm64/dts: qcom: sdm845: Use RPMH_CE_CLK macro directly Bhupesh Sharma
2021-10-13 10:55 ` [PATCH v4 11/20] dt-bindings: crypto : Add new compatible strings for qcom-qce Bhupesh Sharma
2021-10-18 18:26   ` Rob Herring
2021-10-13 10:55 ` [PATCH v4 12/20] arm64/dts: qcom: Use new compatibles for crypto nodes Bhupesh Sharma
2021-10-13 10:55 ` [PATCH v4 13/20] dma: qcom: bam_dma: Add support to initialize interconnect path Bhupesh Sharma
2021-10-13 19:15   ` Vladimir Zapolskiy
2021-10-24 13:53     ` Bhupesh Sharma
2021-10-13 10:55 ` [PATCH v4 14/20] crypto: qce: core: " Bhupesh Sharma
2021-10-13 19:19   ` Vladimir Zapolskiy
2021-10-24 13:53     ` Bhupesh Sharma
2021-10-13 10:55 ` [PATCH v4 15/20] crypto: qce: Add new compatibles for qce crypto driver Bhupesh Sharma
2021-10-13 19:22   ` Vladimir Zapolskiy
2021-10-20 14:07   ` Thara Gopinath
2021-10-24 13:52     ` Bhupesh Sharma
2021-10-13 10:55 ` [PATCH v4 16/20] crypto: qce: core: Make clocks optional Bhupesh Sharma
2021-10-13 19:23   ` Vladimir Zapolskiy
2021-10-24 13:34     ` Bhupesh Sharma
2021-10-13 10:55 ` [PATCH v4 17/20] crypto: qce: Print a failure msg in case probe() fails Bhupesh Sharma
2021-10-13 19:26   ` Vladimir Zapolskiy [this message]
2021-10-24 13:33     ` Bhupesh Sharma
2021-10-13 10:55 ` [PATCH v4 18/20] crypto: qce: Defer probing if BAM dma channel is not yet initialized Bhupesh Sharma
2021-10-13 20:49   ` Vladimir Zapolskiy
2021-10-14  7:40     ` Bhupesh Sharma
2021-10-14  8:42       ` Vladimir Zapolskiy
2021-10-20 14:10   ` Thara Gopinath
2021-10-24 14:05     ` Bhupesh Sharma
2021-10-13 10:55 ` [PATCH v4 19/20] crypto: qce: Add 'sm8250-qce' compatible string check Bhupesh Sharma
2021-10-20 14:11   ` Thara Gopinath
2021-10-13 10:55 ` [PATCH v4 20/20] arm64/dts: qcom: sm8250: Add dt entries to support crypto engine Bhupesh Sharma
2021-10-20 14:03 ` [PATCH v4 00/20] Enable Qualcomm Crypto Engine on sm8250 Thara Gopinath
2021-10-24 13:58   ` Bhupesh Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2699de22-4943-685f-5700-82137a4326ae@linaro.org \
    --to=vladimir.zapolskiy@linaro.org \
    --cc=agross@kernel.org \
    --cc=bhupesh.linux@gmail.com \
    --cc=bhupesh.sharma@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=thara.gopinath@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).