From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0629CC433F5 for ; Wed, 13 Oct 2021 19:26:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D88E961213 for ; Wed, 13 Oct 2021 19:26:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238815AbhJMT21 (ORCPT ); Wed, 13 Oct 2021 15:28:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236935AbhJMT20 (ORCPT ); Wed, 13 Oct 2021 15:28:26 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFA81C061746 for ; Wed, 13 Oct 2021 12:26:22 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id p16so16601073lfa.2 for ; Wed, 13 Oct 2021 12:26:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Cqg6OlscZqEMvb/ReYXudBaSyipapWX2ho/bKAy2P6s=; b=QIG+ixl2Q4prZfyV2wCaaV06GK34fLeJljGPY2tmislnOnnZgid7OA0rtWBo2t1esQ afLbkXegUw8WteZuauN8DY9jGP1mQwJQaW3ImwlYDIdxUiDuLqIcY27qyI0RyBSXan/Z McxnsDpDOA8ZCTeLKYdTVX4lPhTSWMxeZUVvyNIxDQlqzvLav/ktJErSDZFwdFdV+OXC gwVnso03jrqpF7HGBdkBDmGG5QzCb9hOn71y9ANa75N0QrsXa4Wv9Eg/MSg2+nL6JtGX jPWdB7AWpsfuPYHmi5FfPW7/vIs8PGanB/plcFVlvijuJGnn+ii7JWR5WkwWhkEFVOlf pn1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Cqg6OlscZqEMvb/ReYXudBaSyipapWX2ho/bKAy2P6s=; b=jIsnVVULBu81OVZ5hvR9+8TQ/qcoRt3Kgq9Nw52WE9988mVKA2971ynHXt6DlSNQMG y+jM2yVMDPtOHCIGjATiOnp4W0upu6pNwdIPYkoGVcjx/aExgkLA8TbiUatjovziXW0x k8sLuFy5uUJ5Okg4EeVU/DAUvjolu7Iq6mggE823hk14vqLO0haGzUhduNv5Iyp2n6aS T6Gm/QW7jLjdarzx0L98BNP/0OvMyEwyNGS1aPi6uByUfo0Hz6wJ8HG6tRhVwd0asw5T wFLgVbiqgyYUlouG2ZlkBfXkwbAVEn6jKl5FUSoNjDeMh92IhnX0YwUAiaD3+APT/zOx AuyQ== X-Gm-Message-State: AOAM530SPZAu5K3uSZ3rSgUBM/0F4lw7BQUp/7/qMGIeMK9K5pjyLFi1 zvogEayrO5aSIdjjrQLmda7kcg== X-Google-Smtp-Source: ABdhPJznjZnDpqOvqSdheZSC8P42iPnMdQCzy/Tnq4TKbALGTxj9GhVYDaxKh0Q/72NXCoIRKjTuew== X-Received: by 2002:a05:6512:14b:: with SMTP id m11mr811712lfo.410.1634153181254; Wed, 13 Oct 2021 12:26:21 -0700 (PDT) Received: from [192.168.1.102] (62-248-207-242.elisa-laajakaista.fi. [62.248.207.242]) by smtp.gmail.com with ESMTPSA id g7sm31776lfr.113.2021.10.13.12.26.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Oct 2021 12:26:21 -0700 (PDT) Subject: Re: [PATCH v4 17/20] crypto: qce: Print a failure msg in case probe() fails To: Bhupesh Sharma , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org Cc: bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, agross@kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, Bjorn Andersson , Thara Gopinath References: <20211013105541.68045-1-bhupesh.sharma@linaro.org> <20211013105541.68045-18-bhupesh.sharma@linaro.org> From: Vladimir Zapolskiy Message-ID: <2699de22-4943-685f-5700-82137a4326ae@linaro.org> Date: Wed, 13 Oct 2021 22:26:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20211013105541.68045-18-bhupesh.sharma@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Bhupesh, On 10/13/21 1:55 PM, Bhupesh Sharma wrote: > Print a failure message (dev_err) in case the qcom qce crypto > driver probe() fails. > > Cc: Bjorn Andersson > Cc: Rob Herring > Reviewed-by: Thara Gopinath > Signed-off-by: Bhupesh Sharma > --- > drivers/crypto/qce/core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > index 576c416461f9..cb8c77709e1e 100644 > --- a/drivers/crypto/qce/core.c > +++ b/drivers/crypto/qce/core.c > @@ -281,6 +281,8 @@ static int qce_crypto_probe(struct platform_device *pdev) > icc_set_bw(qce->mem_path, 0, 0); > err_mem_path_put: > icc_put(qce->mem_path); > + > + dev_err(dev, "%s failed : %d\n", __func__, ret); > return ret; > } > As for me the rationale of this change is quite non-obvious, a user is well informed, if a driver probe fails. I would rather ask you to consider to drop this change. -- Best wishes, Vladimir