From: Steev Klimaszewski <steev@kali.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <abhinavk@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Jonathan Marek <jonathan@marek.ca>,
Stephen Boyd <sboyd@kernel.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
Amit Pundir <amit.pundir@linaro.org>
Subject: Re: Revert "arm64: dts: qcom: sm8250: remove bus clock from the mdss node for sm8250 target"
Date: Thu, 14 Oct 2021 10:42:19 -0500 [thread overview]
Message-ID: <298400eb-fe8d-6a92-6ff4-6188a8f3161a@kali.org> (raw)
In-Reply-To: <20211014135410.4136412-1-dmitry.baryshkov@linaro.org>
On 10/14/21 8:54 AM, Dmitry Baryshkov wrote:
> From: Amit Pundir <amit.pundir@linaro.org>
>
> This reverts commit 001ce9785c0674d913531345e86222c965fc8bf4.
>
> This upstream commit broke AOSP (post Android 12 merge) build
> on RB5. The device either silently crashes into USB crash mode
> after android boot animation or we see a blank blue screen
> with following dpu errors in dmesg:
>
> [ T444] hw recovery is not complete for ctl:3
> [ T444] [drm:dpu_encoder_phys_vid_prepare_for_kickoff:539] [dpu error]enc31 intf1 ctl 3 reset failure: -22
> [ T444] [drm:dpu_encoder_phys_vid_wait_for_commit_done:513] [dpu error]vblank timeout
> [ T444] [drm:dpu_kms_wait_for_commit_done:454] [dpu error]wait for commit done returned -110
> [ C7] [drm:dpu_encoder_frame_done_timeout:2127] [dpu error]enc31 frame done timeout
> [ T444] [drm:dpu_encoder_phys_vid_wait_for_commit_done:513] [dpu error]vblank timeout
> [ T444] [drm:dpu_kms_wait_for_commit_done:454] [dpu error]wait for commit done returned -110
>
> Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 8c15d9fed08f..d12e4cbfc852 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2590,9 +2590,10 @@
> power-domains = <&dispcc MDSS_GDSC>;
>
> clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
> + <&gcc GCC_DISP_HF_AXI_CLK>,
> <&gcc GCC_DISP_SF_AXI_CLK>,
> <&dispcc DISP_CC_MDSS_MDP_CLK>;
> - clock-names = "iface", "nrt_bus", "core";
> + clock-names = "iface", "bus", "nrt_bus", "core";
>
> assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>;
> assigned-clock-rates = <460000000>;
Is this the correct fix for the issue? I see those same messages on the
Lenovo Yoga C630 every so often as well as the blue screen, however I
see them on both 5.14 (which does not have the related commit to this),
and in 5.15-rcX, which does. Or does this just revert it enough that it
doesn't occur as often?
next prev parent reply other threads:[~2021-10-14 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 13:54 Revert "arm64: dts: qcom: sm8250: remove bus clock from the mdss node for sm8250 target" Dmitry Baryshkov
2021-10-14 15:42 ` Steev Klimaszewski [this message]
2021-10-14 15:47 ` Steev Klimaszewski
2021-10-14 16:54 ` Vladimir Zapolskiy
2021-10-14 21:23 ` Dmitry Baryshkov
2021-10-22 19:24 ` Amit Pundir
2021-10-25 20:20 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=298400eb-fe8d-6a92-6ff4-6188a8f3161a@kali.org \
--to=steev@kali.org \
--cc=abhinavk@codeaurora.org \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).