From: Neil Armstrong <narmstrong@baylibre.com>
To: Mihail Atanassov <Mihail.Atanassov@arm.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Cc: "Martyn Welch" <martyn.welch@collabora.co.uk>,
"David Airlie" <airlied@linux.ie>,
"Peter Senna Tschudin" <peter.senna@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Boris Brezillon" <boris.brezillon@collabora.com>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"Vincent Abriou" <vincent.abriou@st.com>,
"Martin Donnelly" <martin.donnelly@ge.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Vasily Khoruzhick" <anarsoul@gmail.com>,
"Kukjin Kim" <kgene@kernel.org>,
"Icenowy Zheng" <icenowy@aosc.io>,
"Jonas Karlman" <jonas@kwiboo.se>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"Brian Masney" <masneyb@onstation.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>, nd <nd@arm.com>,
"Sean Paul" <sean@poorly.run>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
"Douglas Anderson" <dianders@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Yannick Fertré" <yannick.fertre@st.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
"Torsten Duwe" <duwe@lst.de>,
"Dariusz Marcinkiewicz" <darekm@google.com>,
"freedreno@lists.freedesktop.org"
<freedreno@lists.freedesktop.org>
Subject: Re: [PATCH v2 00/28] drm/bridge: Consolidate initialization
Date: Mon, 9 Dec 2019 11:39:07 +0100 [thread overview]
Message-ID: <2989c044-8134-bb7c-a7e0-c518334bf4a6@baylibre.com> (raw)
In-Reply-To: <20191204114732.28514-1-mihail.atanassov@arm.com>
Hi Mihail,
On 04/12/2019 12:48, Mihail Atanassov wrote:
> Hi all,
>
> I've dropped the fun parts of this series since they need more work, but
> figured drm_bridge_init() as a concept is still valuable on its own (and
> I think I'll need it to roll out device links for registered bridges),
> so here goes.
>
> v2:
> - expanded commit messages and added some extra bridge-related
> documentation (Daniel)
> - dropped v1 patches 29 and 30: 29 needs more work, and 30 depends on
> it
> - added all remaining drm_bridge implementers, found by searching for
> drm_bridge_funcs which is mandatory for any bridge; new uses in
> patches 3, 27, and 28 (Sam)
> - due to the above, I've decided to squash all analogix changes into
> one patch
>
> ---
> v1 [https://patchwork.freedesktop.org/series/70039/] cover text below:
>
> This series adds device links support to drm_bridge. The motivation
> behind it is that a drm_bridge in a module could get removed under the
> feet of the bridge user without warning, so we need a way to remove and
> reprobe the client as needed to avoid peering into the void.
>
> 1: Add a drm_bridge_init() function which wraps all initialisation of
> the structure prior to calling drm_bridge_add().
>
> 2-26,28: Apply the drm_bridge_init() refactor to every bridge that uses
> drm_bridge_add().
>
> 27: Minor cleanup in rcar-du.
>
> 29: Add of_drm_find_bridge_devlink() which functions the same as
> of_drm_find_bridge() plus adds a device device link from the owning
> drm_device to the bridge device.
>
> 30: As a motivating example, convert komeda to exclusively use
> drm_bridge for its pipe outputs; this isn't a regression in usability
> any more since device links bring the same automatic remove/reprobe
> feature as components.
>
> Mihail Atanassov (28):
> drm: Introduce drm_bridge_init()
> drm/bridge: adv7511: Use drm_bridge_init()
> drm/bridge/analogix: Use drm_bridge_init()
> drm/bridge: cdns: Use drm_bridge_init()
> drm/bridge: dumb-vga-dac: Use drm_bridge_init()
> drm/bridge: lvds-encoder: Use drm_bridge_init()
> drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: Use drm_bridge_init()
> drm/bridge: nxp-ptn3460: Use drm_bridge_init()
> drm/bridge: panel: Use drm_bridge_init()
> drm/bridge: ps8622: Use drm_bridge_init()
> drm/bridge: sii902x: Use drm_bridge_init()
> gpu: drm: bridge: sii9234: Use drm_bridge_init()
> drm/bridge: sil_sii8620: Use drm_bridge_init()
> drm/bridge: dw-hdmi: Use drm_bridge_init()
> drm/bridge/synopsys: dsi: Use drm_bridge_init()
> drm/bridge: tc358764: Use drm_bridge_init()
> drm/bridge: tc358767: Use drm_bridge_init()
> drm/bridge: thc63: Use drm_bridge_init()
> drm/bridge: ti-sn65dsi86: Use drm_bridge_init()
> drm/bridge: ti-tfp410: Use drm_bridge_init()
> drm/exynos: mic: Use drm_bridge_init()
> drm/i2c: tda998x: Use drm_bridge_init()
> drm/mcde: dsi: Use drm_bridge_init()
> drm/mediatek: hdmi: Use drm_bridge_init()
> drm: rcar-du: lvds: Use drm_bridge_init()
> drm: rcar-du: lvds: Don't set drm_bridge private pointer
> drm/sti: Use drm_bridge_init()
> drm/msm: Use drm_bridge_init()
>
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 5 ++-
> .../drm/bridge/analogix/analogix-anx6345.c | 5 ++-
> .../drm/bridge/analogix/analogix-anx78xx.c | 8 ++---
> .../drm/bridge/analogix/analogix_dp_core.c | 5 ++-
> drivers/gpu/drm/bridge/cdns-dsi.c | 4 +--
> drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 ++--
> drivers/gpu/drm/bridge/lvds-encoder.c | 7 ++--
> .../bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 4 +--
> drivers/gpu/drm/bridge/nxp-ptn3460.c | 4 +--
> drivers/gpu/drm/bridge/panel.c | 7 ++--
> drivers/gpu/drm/bridge/parade-ps8622.c | 3 +-
> drivers/gpu/drm/bridge/sii902x.c | 5 ++-
> drivers/gpu/drm/bridge/sii9234.c | 3 +-
> drivers/gpu/drm/bridge/sil-sii8620.c | 3 +-
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 ++--
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 7 ++--
> drivers/gpu/drm/bridge/tc358764.c | 4 +--
> drivers/gpu/drm/bridge/tc358767.c | 3 +-
> drivers/gpu/drm/bridge/thc63lvd1024.c | 7 ++--
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 ++-
> drivers/gpu/drm/bridge/ti-tfp410.c | 5 ++-
> drivers/gpu/drm/drm_bridge.c | 34 ++++++++++++++++++-
> drivers/gpu/drm/exynos/exynos_drm_mic.c | 8 +----
> drivers/gpu/drm/i2c/tda998x_drv.c | 6 +---
> drivers/gpu/drm/mcde/mcde_dsi.c | 3 +-
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 +--
> drivers/gpu/drm/msm/dsi/dsi_manager.c | 4 +--
> drivers/gpu/drm/msm/edp/edp_bridge.c | 3 +-
> drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 4 +--
> drivers/gpu/drm/rcar-du/rcar_lvds.c | 5 ++-
> drivers/gpu/drm/sti/sti_dvo.c | 4 +--
> drivers/gpu/drm/sti/sti_hda.c | 3 +-
> drivers/gpu/drm/sti/sti_hdmi.c | 3 +-
> include/drm/drm_bridge.h | 15 +++++++-
> 34 files changed, 100 insertions(+), 103 deletions(-)
>
Can you check it doesn't collides with Boris 1-7 of "drm: Add support for bus-format negotiation" patches he just pushed on drm-misc-next ?
Neil
next prev parent reply other threads:[~2019-12-09 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191204114732.28514-1-mihail.atanassov@arm.com>
2019-12-04 11:48 ` [PATCH v2 28/28] drm/msm: Use drm_bridge_init() Mihail Atanassov
2019-12-09 10:39 ` Neil Armstrong [this message]
2019-12-09 11:08 ` [PATCH v2 00/28] drm/bridge: Consolidate initialization Mihail Atanassov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2989c044-8134-bb7c-a7e0-c518334bf4a6@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=Mihail.Atanassov@arm.com \
--cc=airlied@linux.ie \
--cc=anarsoul@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=darekm@google.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=duwe@lst.de \
--cc=freedreno@lists.freedesktop.org \
--cc=icenowy@aosc.io \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kgene@kernel.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=martin.donnelly@ge.com \
--cc=martyn.welch@collabora.co.uk \
--cc=masneyb@onstation.org \
--cc=matthias.bgg@gmail.com \
--cc=nd@arm.com \
--cc=peter.senna@gmail.com \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=sw0312.kim@samsung.com \
--cc=vincent.abriou@st.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).