From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E051C2BA83 for ; Wed, 12 Feb 2020 11:01:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6A9C20675 for ; Wed, 12 Feb 2020 11:01:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=serbinski.com header.i=@serbinski.com header.b="MhWhH9Rd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727007AbgBLLB4 (ORCPT ); Wed, 12 Feb 2020 06:01:56 -0500 Received: from mail.serbinski.com ([162.218.126.2]:46110 "EHLO mail.serbinski.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726351AbgBLLB4 (ORCPT ); Wed, 12 Feb 2020 06:01:56 -0500 Received: from localhost (unknown [127.0.0.1]) by mail.serbinski.com (Postfix) with ESMTP id 5B51AD006F9; Wed, 12 Feb 2020 11:01:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at serbinski.com Received: from mail.serbinski.com ([127.0.0.1]) by localhost (mail.serbinski.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hCMGVnst3C2i; Wed, 12 Feb 2020 06:01:46 -0500 (EST) Received: from mail.serbinski.com (localhost [127.0.0.1]) by mail.serbinski.com (Postfix) with ESMTP id 70D9CD00693; Wed, 12 Feb 2020 06:01:46 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.serbinski.com 70D9CD00693 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=serbinski.com; s=default; t=1581505306; bh=qDlickU02ZsMirNi7OvLtFkUvQ/GB+12rPSlCDuRsos=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MhWhH9Rd+rlN4TPPcXlLIQdva3asJcljwG91E8xKi1vAtOWnGBoigWmwSGU2pqXFw nO4KBxhsAJhSkDSF7B4k82VppgYouU7aODtGzgJqcFM21xggXNK3kELA1LjPP1QRMh 2MDK689fN1KtIpvfYwCymniyKta3p2T8JI6bdK8M= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 12 Feb 2020 06:01:46 -0500 From: Adam Serbinski To: Srinivas Kandagatla Cc: Mark Brown , Rob Herring , Bjorn Andersson , Andy Gross , Mark Rutland , Liam Girdwood , Patrick Lai , Banajit Goswami , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 6/6] ASoC: qdsp6: dt-bindings: Add q6afe pcm dt binding documentation In-Reply-To: <579e0ae1-f257-7af3-eac9-c8e3ab3b52c7@linaro.org> References: <20200212015222.8229-1-adam@serbinski.com> <20200212015222.8229-7-adam@serbinski.com> <579e0ae1-f257-7af3-eac9-c8e3ab3b52c7@linaro.org> User-Agent: Roundcube Webmail/1.4-beta Message-ID: <2989c09149976a28d13d4b4eb10b7c7e@serbinski.com> X-Sender: adam@serbinski.com Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2020-02-12 04:59, Srinivas Kandagatla wrote: > On 12/02/2020 01:52, Adam Serbinski wrote: >> This patch adds documentation of bindings required for PCM ports on >> AFE. >> >> Signed-off-by: Adam Serbinski >> CC: Andy Gross >> CC: Mark Rutland >> CC: Liam Girdwood >> CC: Patrick Lai >> CC: Banajit Goswami >> CC: Jaroslav Kysela >> CC: Takashi Iwai >> CC: alsa-devel@alsa-project.org >> CC: linux-arm-msm@vger.kernel.org >> CC: devicetree@vger.kernel.org >> CC: linux-kernel@vger.kernel.org >> --- >> .../devicetree/bindings/sound/qcom,q6afe.txt | 42 >> +++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6afe.txt >> b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt >> index d74888b9f1bb..6b1b17d31a2a 100644 >> --- a/Documentation/devicetree/bindings/sound/qcom,q6afe.txt >> +++ b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt >> @@ -51,6 +51,24 @@ configuration of each dai. Must contain the >> following properties. >> Definition: Must be list of serial data lines used by this dai. >> should be one or more of the 0-3 sd lines. >> + - qcom,pcm-quantype >> + Usage: required for pcm interface >> + Value type: >> + Definition: PCM quantization type >> + 0 - ALAW, no padding >> + 1 - MULAW, no padding >> + 2 - Linear, no padding >> + 3 - ALAW, padding >> + 4 - MULAW, padding >> + 5 - Linear, padding >> + >> + - qcom,pcm-slot-mapping >> + Usage: required for pcm interface > > Are these not specific to 8k and 16k mode ? > We should probably list values for both modes here. No, this is just the offset that the audio sample is placed in with respect to a maximum of 4 slots, 16 bits wide, beginning with the sync pulse. When switching between 8 and 16k sample rate, it is just the sync pulse rate that is changed. The audio sample will be delivered in the same slot, just at a different frequency. >> + Value type: >> + Definition: Slot mapping for audio channels. Array size is the >> number >> + of slots, minimum 1, maximum 4. The value is 0 for no mapping >> + to the slot, or the channel number from 1 to 32. >> + >> - qcom,tdm-sync-mode: >> Usage: required for tdm interface >> Value type: >> @@ -174,5 +192,29 @@ q6afe@4 { >> reg = <23>; >> qcom,sd-lines = <1>; >> }; >> + >> + pri-pcm-rx@105 { >> + reg = <105>; >> + qcom,pcm-quantype = <2>; >> + qcom,pcm-slot-mapping = <1>; >> + }; >> + >> + pri-pcm-tx@106 { >> + reg = <106>; >> + qcom,pcm-quantype = <2>; >> + qcom,pcm-slot-mapping = <1>; >> + }; >> + >> + quat-pcm-rx@111 { >> + reg = <111>; >> + qcom,pcm-quantype = <5>; >> + qcom,pcm-slot-mapping = <0 0 1>; >> + }; >> + >> + quat-pcm-tx@112 { >> + reg = <112>; >> + qcom,pcm-quantype = <5>; >> + qcom,pcm-slot-mapping = <0 0 1>; >> + }; >> }; >> }; >>