From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF12BC433DB for ; Sat, 13 Feb 2021 03:26:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1FE964E8D for ; Sat, 13 Feb 2021 03:26:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229679AbhBMDZ7 (ORCPT ); Fri, 12 Feb 2021 22:25:59 -0500 Received: from mail-pj1-f49.google.com ([209.85.216.49]:50381 "EHLO mail-pj1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229648AbhBMDZ6 (ORCPT ); Fri, 12 Feb 2021 22:25:58 -0500 Received: by mail-pj1-f49.google.com with SMTP id cl8so679441pjb.0; Fri, 12 Feb 2021 19:25:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZDK5F7tnO4b2ft9Zo/5qZ+F8VO7X7IwT4LLVFZ1PYwU=; b=OJtpfdQMZ/zIUokpnXYyEj4OCO8Om6Z/Kw9do9pr5gpH0psaRF0dw/nhLMnMcrkOH6 O+L/oFKuSESlp6m/B1ehK8gObvHogndEsbyGHgpOrq5sanR7bMHv6cI+WyHZCgHQssub Iy1ObasEoVpY/yBNieaVLEw74ZnmooFaFyltZ5XXP3FL7XOhS5FQD1Kgg9MivQ87bmYe WOYVPLvY/LFVfClMKhwDKgSJapEUIINzTV2skrSvSUaiol3P5toujIX4527rsOtnVSPi 9Ik/VHXZapFgsvj1tVBQof9+lVotP9W+4J3DKQPGKveDJjWxfSxpEwKD4JD7E6nOZzs1 kmcg== X-Gm-Message-State: AOAM531BnhHPMg31hU0tq/nBtZZEuL1kq2+wt89kVSsb2RrlCnLVLfvo Rq/lLeRQsv5jbvWaVTXRh3fDgT43Eko= X-Google-Smtp-Source: ABdhPJxn19h6MYI/Ybf1mOYrG0afmx694nMh8K9UfLwB4lz8P4EvdkML+GScoC91Zq7bPUpH3BkAQQ== X-Received: by 2002:a17:90a:8b82:: with SMTP id z2mr5455309pjn.25.1613186717224; Fri, 12 Feb 2021 19:25:17 -0800 (PST) Received: from ?IPv6:2601:647:4000:d7:7f86:b7b7:63df:6d7a? ([2601:647:4000:d7:7f86:b7b7:63df:6d7a]) by smtp.gmail.com with ESMTPSA id z11sm9598558pjn.5.2021.02.12.19.25.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Feb 2021 19:25:16 -0800 (PST) Subject: Re: [RFC PATCH v3 1/1] scsi: ufs: Enable power management for wlun To: Asutosh Das , cang@codeaurora.org, martin.petersen@oracle.com, linux-scsi@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, stern@rowland.harvard.edu, Alim Akhtar , Avri Altman , "James E.J. Bottomley" , Steven Rostedt , Ingo Molnar , Stanley Chu , Bean Huo , Jaegeuk Kim , Kiwoong Kim , Adrian Hunter , Satya Tangirala , open list References: From: Bart Van Assche Message-ID: <29fcd3c1-72c7-1191-ec03-aea1b0c6b8c9@acm.org> Date: Fri, 12 Feb 2021 19:25:13 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2/11/21 11:18 AM, Asutosh Das wrote: > +static inline bool is_rpmb_wlun(struct scsi_device *sdev) > +{ > + return (sdev->lun == ufshcd_upiu_wlun_to_scsi_wlun(UFS_UPIU_RPMB_WLUN)); > +} > + > +static inline bool is_device_wlun(struct scsi_device *sdev) > +{ > + return (sdev->lun == > + ufshcd_upiu_wlun_to_scsi_wlun(UFS_UPIU_UFS_DEVICE_WLUN)); > +} A minor comment: checkpatch should have reported that "return is not a function" for the above code. > /** > + * ufshcd_setup_links - associate link b/w device wlun and other luns > + * @sdev: pointer to SCSI device > + * @hba: pointer to ufs hba > + * > + * Returns void > + */ Please leave out "Returns void". > +static int ufshcd_wl_suspend(struct device *dev) > +{ > + struct scsi_device *sdev = to_scsi_device(dev); > + struct ufs_hba *hba; > + int ret; > + ktime_t start = ktime_get(); > + > + if (is_rpmb_wlun(sdev)) > + return 0; > + hba = shost_priv(sdev->host); > + ret = __ufshcd_wl_suspend(hba, UFS_SYSTEM_PM); > + if (ret) > + dev_err(&sdev->sdev_gendev, "%s failed: %d\n", __func__, ret); > + > + trace_ufshcd_wl_suspend(dev_name(dev), ret, > + ktime_to_us(ktime_sub(ktime_get(), start)), > + hba->curr_dev_pwr_mode, hba->uic_link_state); > + > + return ret; > + > +} Please remove the blank line after the return statement. Otherwise this patch looks good to me. Hence: Reviewed-by: Bart Van Assche