From: Florian Fainelli <f.fainelli@gmail.com>
To: Vinod Koul <vkoul@kernel.org>, David S Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Niklas Cassel <niklas.cassel@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v2 5/5] net: dsa: qca8k: disable delay for RGMII mode
Date: Tue, 8 Jan 2019 10:00:37 -0800 [thread overview]
Message-ID: <29fde9a8-00ed-b784-d9d0-eebd2e0cb4e7@gmail.com> (raw)
In-Reply-To: <20190108162926.17806-6-vkoul@kernel.org>
On 1/8/19 8:29 AM, Vinod Koul wrote:
> In RGMII mode we should not have any delay in phy, so disable
> the delay.
This seems to apply to the port's MAC itself, so the commit message
should be mentioning the port's MAC not the PHY, right?
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/net/dsa/qca8k.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
> index 7e97e620bd44..a4b6cda38016 100644
> --- a/drivers/net/dsa/qca8k.c
> +++ b/drivers/net/dsa/qca8k.c
> @@ -420,7 +420,7 @@ qca8k_mib_init(struct qca8k_priv *priv)
> static int
> qca8k_set_pad_ctrl(struct qca8k_priv *priv, int port, int mode)
> {
> - u32 reg;
> + u32 reg, val;
>
> switch (port) {
> case 0:
> @@ -439,17 +439,9 @@ qca8k_set_pad_ctrl(struct qca8k_priv *priv, int port, int mode)
> */
> switch (mode) {
> case PHY_INTERFACE_MODE_RGMII:
> - qca8k_write(priv, reg,
> - QCA8K_PORT_PAD_RGMII_EN |
> - QCA8K_PORT_PAD_RGMII_TX_DELAY(3) |
> - QCA8K_PORT_PAD_RGMII_RX_DELAY(3));
> -
> - /* According to the datasheet, RGMII delay is enabled through
> - * PORT5_PAD_CTRL for all ports, rather than individual port
> - * registers
> - */
> - qca8k_write(priv, QCA8K_REG_PORT5_PAD_CTRL,
> - QCA8K_PORT_PAD_RGMII_RX_DELAY_EN);
> + /* RGMII mode means no delay so don't enable the delay */
> + val = QCA8K_PORT_PAD_RGMII_EN;
> + qca8k_write(priv, reg, val);
> break;
> case PHY_INTERFACE_MODE_SGMII:
> qca8k_write(priv, reg, QCA8K_PORT_PAD_SGMII_EN);
>
--
Florian
next prev parent reply other threads:[~2019-01-08 18:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 16:29 [PATCH v2 0/5] net: Add support for Qualcomm ethqos Vinod Koul
2019-01-08 16:29 ` [PATCH v2 1/5] dt-bindings: net: Add Qualcomm ethqos binding Vinod Koul
2019-01-15 21:03 ` Rob Herring
2019-01-17 4:03 ` Vinod Koul
2019-01-08 16:29 ` [PATCH v2 2/5] net: stmmac: Add driver for Qualcomm ethqos Vinod Koul
2019-01-08 16:29 ` [PATCH v2 3/5] MAINTAINER: Add entry for Qualcomm ETHQOS ethernet driver Vinod Koul
2019-01-08 16:29 ` [PATCH v2 4/5] net: phy: at803x: Disable phy delay for RGMII mode Vinod Koul
2019-01-08 17:59 ` Florian Fainelli
2019-01-09 4:35 ` Vinod Koul
2019-01-08 16:29 ` [PATCH v2 5/5] net: dsa: qca8k: disable " Vinod Koul
2019-01-08 18:00 ` Florian Fainelli [this message]
2019-01-09 4:43 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29fde9a8-00ed-b784-d9d0-eebd2e0cb4e7@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).