Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
From: Scott Branden <scott.branden@broadcom.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
	David Brown <david.brown@linaro.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
	Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH 2/3] firmware: add offset to request_firmware_into_buf
Date: Wed, 31 Jul 2019 17:18:32 -0700
Message-ID: <2f67db0a-27c3-d13c-bbe0-0af5edd4f0da@broadcom.com> (raw)
In-Reply-To: <20190524052258.GB28229@kroah.com>

Hi Greg,

I am now back from leave to continue this patch.  Comment below.

On 2019-05-23 10:22 p.m., Greg Kroah-Hartman wrote:
> On Thu, May 23, 2019 at 10:01:38PM -0700, Scott Branden wrote:
>> On 2019-05-23 9:54 a.m., Greg Kroah-Hartman wrote:
>>> On Thu, May 23, 2019 at 09:36:02AM -0700, Scott Branden wrote:
>>>> Hi Greg,
>>>>
>>>> On 2019-05-22 10:52 p.m., Greg Kroah-Hartman wrote:
>>>>> On Wed, May 22, 2019 at 07:51:12PM -0700, Scott Branden wrote:
>>>>>> Add offset to request_firmware_into_buf to allow for portions
>>>>>> of firmware file to be read into a buffer.  Necessary where firmware
>>>>>> needs to be loaded in portions from file in memory constrained systems.
>>>>>>
>>>>>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>>>>>> ---
>>>>>>     drivers/base/firmware_loader/firmware.h |  5 +++
>>>>>>     drivers/base/firmware_loader/main.c     | 49 +++++++++++++++++--------
>>>>>>     include/linux/firmware.h                |  8 +++-
>>>>>>     3 files changed, 45 insertions(+), 17 deletions(-)
>>>>> No new firmware test for this new option?  How do we know it even works?
>>>> I was unaware there are existing firmware tests.  Please let me know where
>>>> these tests exists and I can add a test for this new option.
>>> tools/testing/selftests/firmware/
>> Unfortunately, there doesn't seem to be a test for the existing
>> request_firmware_into_buf api.
> Are you sure?  The test is for userspace functionality, there isn't
> kernel unit tests here.  You need to verify that you didn't break
> existing functionality as well as verify that your new functionality
> works.

I managed to figure out how to build and run 
tools/testing/selftest/firmware/fw_run_tests.sh

and my changes don't break existing functionality.

But, I find no use of request_firmware_into_buf in lib/test_firmware.c 
(triggered by fw_run_tests.sh).

Is there another test for request_firmware_into_buf?

>>>> We have tested this with a new driver in development which requires the
>>>> firmware file to be read in portions into memory.  I can add my tested-by
>>>> and others to the commit message if desired.
>>> I can't take new apis without an in-kernel user, you all know this...
>> OK, It will have to wait then as I was hoping to get this in before my
>> leave.
> Throwing new code over the wall and running away is a sure way to ensure
> that your code will be ignored :)
>
> thanks,
>
> greg k-h

  reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23  2:51 [PATCH 0/3] fs: add partial file read support Scott Branden
2019-05-23  2:51 ` [PATCH 1/3] fs: introduce kernel_pread_file* support Scott Branden
2019-05-23  2:51 ` [PATCH 2/3] firmware: add offset to request_firmware_into_buf Scott Branden
2019-05-23  5:52   ` Greg Kroah-Hartman
2019-05-23 16:36     ` Scott Branden
2019-05-23 16:54       ` Greg Kroah-Hartman
2019-05-24  5:01         ` Scott Branden
2019-05-24  5:22           ` Greg Kroah-Hartman
2019-08-01  0:18             ` Scott Branden [this message]
2019-08-01  6:18               ` Greg Kroah-Hartman
2019-08-01 17:42                 ` Luis Chamberlain
2019-08-01 18:15                   ` Scott Branden
2019-08-19 22:22                     ` Luis Chamberlain
2019-05-23  2:51 ` [PATCH 3/3] soc: qcom: mdt_loader: " Scott Branden
2019-05-23  5:52   ` Greg Kroah-Hartman
2019-05-23 16:41     ` Scott Branden
2019-05-23 16:56       ` Greg Kroah-Hartman
2019-05-27  5:36         ` Bjorn Andersson
2019-07-30 23:02           ` Scott Branden
2019-08-22 19:33         ` Scott Branden

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f67db0a-27c3-d13c-bbe0-0af5edd4f0da@broadcom.com \
    --to=scott.branden@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=david.brown@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=olof@lixom.net \
    --cc=rafael@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git