Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH linux-next] qcom: qcs404: remove COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404
@ 2019-08-15  7:48 Mao Wenan
  2019-08-18  1:09 ` Stephen Boyd
  0 siblings, 1 reply; 4+ messages in thread
From: Mao Wenan @ 2019-08-15  7:48 UTC (permalink / raw)
  To: agross, georgi.djakov, linux-arm-msm, linux-pm
  Cc: linux-kernel, kernel-janitors, Mao Wenan

There is one compilation error when CONFIG_INTERCONNECT_QCOM_QCS404=y and
CONFIG_INTERCONNECT_QCOM_SMD_RPM=y, as well as CONFIG_COMPILE_TEST=y,
but CONFIG_QCOM_SMD_RPM is not set, logs as below:

drivers/interconnect/qcom/smd-rpm.o: In function `qcom_icc_rpm_smd_send':
smd-rpm.c:(.text+0xe4): undefined reference to `qcom_rpm_smd_write'
Makefile:1071: recipe for target 'vmlinux' failed
make: *** [vmlinux] Error 1

This is because
INTERCONNECT_QCOM_QCS404 depends on QCOM_SMD_RPM || COMPILE_TEST.
Here CONFIG_COMPILE_TEST=y, so CONFIG_INTERCONNECT_QCOM_SMD_RPM
is selected. If CONFIG_QCOM_SMD_RPM is not set, then
qcom_rpm_smd_write() is not defined, and compilation error happen.
Fix this by removing COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404.

Fixes: 5e4e6c4d3ae0 ("interconnect: qcom: Add QCS404 interconnect provider driver")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 drivers/interconnect/qcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig
index 339e8f1..6ab4012 100644
--- a/drivers/interconnect/qcom/Kconfig
+++ b/drivers/interconnect/qcom/Kconfig
@@ -8,7 +8,7 @@ config INTERCONNECT_QCOM
 config INTERCONNECT_QCOM_QCS404
 	tristate "Qualcomm QCS404 interconnect driver"
 	depends on INTERCONNECT_QCOM
-	depends on QCOM_SMD_RPM || COMPILE_TEST
+	depends on QCOM_SMD_RPM
 	select INTERCONNECT_QCOM_SMD_RPM
 	help
 	  This is a driver for the Qualcomm Network-on-Chip on qcs404-based
-- 
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH linux-next] qcom: qcs404: remove COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404
  2019-08-15  7:48 [PATCH linux-next] qcom: qcs404: remove COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404 Mao Wenan
@ 2019-08-18  1:09 ` Stephen Boyd
  2019-08-19  1:31   ` maowenan
  2019-08-19  3:37   ` [PATCH v2 linux-next] qcom: qcs404: move COMPILE_TEST to INTERCONNECT_QCOM Mao Wenan
  0 siblings, 2 replies; 4+ messages in thread
From: Stephen Boyd @ 2019-08-18  1:09 UTC (permalink / raw)
  To: Mao Wenan, agross, georgi.djakov, linux-arm-msm, linux-pm
  Cc: linux-kernel, kernel-janitors, Mao Wenan

Quoting Mao Wenan (2019-08-15 00:48:48)
> There is one compilation error when CONFIG_INTERCONNECT_QCOM_QCS404=y and
> CONFIG_INTERCONNECT_QCOM_SMD_RPM=y, as well as CONFIG_COMPILE_TEST=y,
> but CONFIG_QCOM_SMD_RPM is not set, logs as below:
> 
> drivers/interconnect/qcom/smd-rpm.o: In function `qcom_icc_rpm_smd_send':
> smd-rpm.c:(.text+0xe4): undefined reference to `qcom_rpm_smd_write'
> Makefile:1071: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
> 
> This is because
> INTERCONNECT_QCOM_QCS404 depends on QCOM_SMD_RPM || COMPILE_TEST.
> Here CONFIG_COMPILE_TEST=y, so CONFIG_INTERCONNECT_QCOM_SMD_RPM
> is selected. If CONFIG_QCOM_SMD_RPM is not set, then
> qcom_rpm_smd_write() is not defined, and compilation error happen.
> Fix this by removing COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404.

Can you fix the actual problem with compile testing this driver vs. just
removing the possibility to compile test. Otherwise it gives up on
the spirit of the idea of COMPILE_TEST.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH linux-next] qcom: qcs404: remove COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404
  2019-08-18  1:09 ` Stephen Boyd
@ 2019-08-19  1:31   ` maowenan
  2019-08-19  3:37   ` [PATCH v2 linux-next] qcom: qcs404: move COMPILE_TEST to INTERCONNECT_QCOM Mao Wenan
  1 sibling, 0 replies; 4+ messages in thread
From: maowenan @ 2019-08-19  1:31 UTC (permalink / raw)
  To: Stephen Boyd, agross, georgi.djakov, linux-arm-msm, linux-pm
  Cc: linux-kernel, kernel-janitors



On 2019/8/18 9:09, Stephen Boyd wrote:
> Quoting Mao Wenan (2019-08-15 00:48:48)
>> There is one compilation error when CONFIG_INTERCONNECT_QCOM_QCS404=y and
>> CONFIG_INTERCONNECT_QCOM_SMD_RPM=y, as well as CONFIG_COMPILE_TEST=y,
>> but CONFIG_QCOM_SMD_RPM is not set, logs as below:
>>
>> drivers/interconnect/qcom/smd-rpm.o: In function `qcom_icc_rpm_smd_send':
>> smd-rpm.c:(.text+0xe4): undefined reference to `qcom_rpm_smd_write'
>> Makefile:1071: recipe for target 'vmlinux' failed
>> make: *** [vmlinux] Error 1
>>
>> This is because
>> INTERCONNECT_QCOM_QCS404 depends on QCOM_SMD_RPM || COMPILE_TEST.
>> Here CONFIG_COMPILE_TEST=y, so CONFIG_INTERCONNECT_QCOM_SMD_RPM
>> is selected. If CONFIG_QCOM_SMD_RPM is not set, then
>> qcom_rpm_smd_write() is not defined, and compilation error happen.
>> Fix this by removing COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404.
> 
> Can you fix the actual problem with compile testing this driver vs. just
> removing the possibility to compile test. Otherwise it gives up on
> the spirit of the idea of COMPILE_TEST.

yes, I have already tried to move COMPILE_TEST to INTERCONNECT_QCOM,


 config INTERCONNECT_QCOM
        bool "Qualcomm Network-on-Chip interconnect drivers"
-       depends on ARCH_QCOM
+       depends on ARCH_QCOM || COMPILE_TEST
        help
          Support for Qualcomm's Network-on-Chip interconnect hardware.

> 
> 
> .
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 linux-next] qcom: qcs404: move COMPILE_TEST to INTERCONNECT_QCOM
  2019-08-18  1:09 ` Stephen Boyd
  2019-08-19  1:31   ` maowenan
@ 2019-08-19  3:37   ` Mao Wenan
  1 sibling, 0 replies; 4+ messages in thread
From: Mao Wenan @ 2019-08-19  3:37 UTC (permalink / raw)
  To: agross, georgi.djakov, linux-arm-msm, linux-pm, sboyd
  Cc: linux-kernel, kernel-janitors, Mao Wenan

There is one compilation error when CONFIG_INTERCONNECT_QCOM_QCS404=y and
CONFIG_INTERCONNECT_QCOM_SMD_RPM=y, as well as CONFIG_COMPILE_TEST=y,
but CONFIG_QCOM_SMD_RPM is not set, logs as below:

drivers/interconnect/qcom/smd-rpm.o: In function `qcom_icc_rpm_smd_send':
smd-rpm.c:(.text+0xe4): undefined reference to `qcom_rpm_smd_write'
Makefile:1071: recipe for target 'vmlinux' failed
make: *** [vmlinux] Error 1

This is because
INTERCONNECT_QCOM_QCS404 depends on QCOM_SMD_RPM || COMPILE_TEST.
Here CONFIG_COMPILE_TEST=y, so CONFIG_INTERCONNECT_QCOM_SMD_RPM
is selected. If CONFIG_QCOM_SMD_RPM is not set, then
qcom_rpm_smd_write() is not defined, and compilation error happen.
Fix this by moving COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404 to
CONFIG_INTERCONNECT_QCOM, qcom's interconnect drivers can be compiled on
different platform.

Fixes: 5e4e6c4d3ae0 ("interconnect: qcom: Add QCS404 interconnect provider driver")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 v2: change subject of patch, and move COMPILE_TEST to INTERCONNECT_QCOM.
 drivers/interconnect/qcom/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig
index 339e8f1..7207248 100644
--- a/drivers/interconnect/qcom/Kconfig
+++ b/drivers/interconnect/qcom/Kconfig
@@ -1,14 +1,14 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config INTERCONNECT_QCOM
 	bool "Qualcomm Network-on-Chip interconnect drivers"
-	depends on ARCH_QCOM
+	depends on ARCH_QCOM || COMPILE_TEST
 	help
 	  Support for Qualcomm's Network-on-Chip interconnect hardware.
 
 config INTERCONNECT_QCOM_QCS404
 	tristate "Qualcomm QCS404 interconnect driver"
 	depends on INTERCONNECT_QCOM
-	depends on QCOM_SMD_RPM || COMPILE_TEST
+	depends on QCOM_SMD_RPM
 	select INTERCONNECT_QCOM_SMD_RPM
 	help
 	  This is a driver for the Qualcomm Network-on-Chip on qcs404-based
-- 
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-15  7:48 [PATCH linux-next] qcom: qcs404: remove COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404 Mao Wenan
2019-08-18  1:09 ` Stephen Boyd
2019-08-19  1:31   ` maowenan
2019-08-19  3:37   ` [PATCH v2 linux-next] qcom: qcs404: move COMPILE_TEST to INTERCONNECT_QCOM Mao Wenan

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org linux-arm-msm@archiver.kernel.org
	public-inbox-index linux-arm-msm


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/ public-inbox