From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9B78C433E0 for ; Fri, 24 Jul 2020 15:04:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0CF6206F0 for ; Fri, 24 Jul 2020 15:04:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="loHVUzuS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726643AbgGXPEa (ORCPT ); Fri, 24 Jul 2020 11:04:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726366AbgGXPE3 (ORCPT ); Fri, 24 Jul 2020 11:04:29 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81381C0619D3 for ; Fri, 24 Jul 2020 08:04:29 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id k20so902404wmi.5 for ; Fri, 24 Jul 2020 08:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CwqTzUi/rsF9bmn8x3JnPsegKmJmnxCYF19O9EiQB8g=; b=loHVUzuSXm/GXdrjvO7AU7jZHFLrpAAJsnJpXBS5lUYxZQOZXQIF+xRvuPs3DbZJwC JA/atED/VBunAZuU+Lc0CUar4pSOmbdofW5NR0oU8CB/wpFeotp11dUaouQkkRyWekaV nvJIOGu036olMFpZ1yRHiOSXDx2dZfnlWh4Moz5+LJjRF9ftz7OV84tRwdSBiwfcwOf7 4CQW0MLexrp3YA1UAOPs8dVXsLL0ciCmTKs2j8p8iqJw+YR1zAVO4XeUbbzVMEyJR//u C0Ju4QattfSL52v4YmT6xs43zp0r04a+pGzBQLd74Aa/j8JeeGgowi7oIVB2CEsO6iI7 FaFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CwqTzUi/rsF9bmn8x3JnPsegKmJmnxCYF19O9EiQB8g=; b=aV+H3qoJLWuRFSAs59xJElEuVDELIYn2Pqsp6fNNuwuY2YEZECv8sdMnf3BAwmdX8l z0w6GukSFF/NhpT9+2BV8EdHG2h8/DEBhrKHB6uEs/jqCFwlaPphNMOOzmFg6Im4Q3JR PxeFbjKjVm530HRzrtimlVRhqFUVJsnV5TJWHi+Kb/KoyoGselaVDw8ehkYRb6vBcYdb lvnu9EifIvhnpWd3V9cR3WfSr4g3btZvEiEaFdQCEu74b9Chx5mJx7f36i7KfyrJv+Fe KwpdsxdG8cPztPuCVItnh6s0ODm7MCMel+BPzrYwAN86NVfsoKjuy0Y6nspipX8Kxi25 OBfA== X-Gm-Message-State: AOAM5334XfiSyQYJQ0y2/B2RlziYrUfaXRKftOXRwR8mSPzF4P+OC1zi RWZxUvoqBn/adf0OOoTQmvmCeA== X-Google-Smtp-Source: ABdhPJzl0EVy4Bj5RvkTByOZ6A7C/JVWAHmDOBveLcYBe6Hq1TeuhffCfAo09aU3U03SOlJnohe47A== X-Received: by 2002:a05:600c:285:: with SMTP id 5mr9496156wmk.41.1595603068117; Fri, 24 Jul 2020 08:04:28 -0700 (PDT) Received: from [192.168.1.4] ([195.24.90.54]) by smtp.googlemail.com with ESMTPSA id m126sm407029wmf.3.2020.07.24.08.04.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2020 08:04:27 -0700 (PDT) Subject: Re: [PATCH 1/2] firmware: qcom_scm: Add memory protect virtual address ranges To: Stanimir Varbanov , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Cc: Andy Gross , Bjorn Andersson , Elliot Berman References: <20200709115829.8194-1-stanimir.varbanov@linaro.org> <20200709115829.8194-2-stanimir.varbanov@linaro.org> From: Stanimir Varbanov Message-ID: <33a63665-2f75-1b58-8a0c-3b0a8979fb85@linaro.org> Date: Fri, 24 Jul 2020 18:04:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200709115829.8194-2-stanimir.varbanov@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, Gentle ping for review. On 7/9/20 2:58 PM, Stanimir Varbanov wrote: > This adds a new SCM memprotect command to set virtual address ranges. > > Signed-off-by: Stanimir Varbanov > --- > drivers/firmware/qcom_scm.c | 24 ++++++++++++++++++++++++ > drivers/firmware/qcom_scm.h | 1 + > include/linux/qcom_scm.h | 8 +++++++- > 3 files changed, 32 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > index 0e7233a20f34..a73870255c2e 100644 > --- a/drivers/firmware/qcom_scm.c > +++ b/drivers/firmware/qcom_scm.c > @@ -864,6 +864,30 @@ int qcom_scm_assign_mem(phys_addr_t mem_addr, size_t mem_sz, > } > EXPORT_SYMBOL(qcom_scm_assign_mem); > > +int qcom_scm_mem_protect_video_var(u32 cp_start, u32 cp_size, > + u32 cp_nonpixel_start, > + u32 cp_nonpixel_size) > +{ > + int ret; > + struct qcom_scm_desc desc = { > + .svc = QCOM_SCM_SVC_MP, > + .cmd = QCOM_SCM_MP_VIDEO_VAR, > + .arginfo = QCOM_SCM_ARGS(4, QCOM_SCM_VAL, QCOM_SCM_VAL, > + QCOM_SCM_VAL, QCOM_SCM_VAL), > + .args[0] = cp_start, > + .args[1] = cp_size, > + .args[2] = cp_nonpixel_start, > + .args[3] = cp_nonpixel_size, > + .owner = ARM_SMCCC_OWNER_SIP, > + }; > + struct qcom_scm_res res; > + > + ret = qcom_scm_call(__scm->dev, &desc, &res); > + > + return ret ? : res.result[0]; > +} > +EXPORT_SYMBOL(qcom_scm_mem_protect_video_var); > + > /** > * qcom_scm_ocmem_lock_available() - is OCMEM lock/unlock interface available > */ > diff --git a/drivers/firmware/qcom_scm.h b/drivers/firmware/qcom_scm.h > index d9ed670da222..14da834ac593 100644 > --- a/drivers/firmware/qcom_scm.h > +++ b/drivers/firmware/qcom_scm.h > @@ -97,6 +97,7 @@ extern int scm_legacy_call(struct device *dev, const struct qcom_scm_desc *desc, > #define QCOM_SCM_MP_RESTORE_SEC_CFG 0x02 > #define QCOM_SCM_MP_IOMMU_SECURE_PTBL_SIZE 0x03 > #define QCOM_SCM_MP_IOMMU_SECURE_PTBL_INIT 0x04 > +#define QCOM_SCM_MP_VIDEO_VAR 0x08 > #define QCOM_SCM_MP_ASSIGN 0x16 > > #define QCOM_SCM_SVC_OCMEM 0x0f > diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h > index 3d6a24697761..19b5188d17f4 100644 > --- a/include/linux/qcom_scm.h > +++ b/include/linux/qcom_scm.h > @@ -81,7 +81,9 @@ extern int qcom_scm_assign_mem(phys_addr_t mem_addr, size_t mem_sz, > unsigned int *src, > const struct qcom_scm_vmperm *newvm, > unsigned int dest_cnt); > - > +extern int qcom_scm_mem_protect_video_var(u32 cp_start, u32 cp_size, > + u32 cp_nonpixel_start, > + u32 cp_nonpixel_size); > extern bool qcom_scm_ocmem_lock_available(void); > extern int qcom_scm_ocmem_lock(enum qcom_scm_ocmem_client id, u32 offset, > u32 size, u32 mode); > @@ -131,6 +133,10 @@ static inline int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare) > static inline int qcom_scm_assign_mem(phys_addr_t mem_addr, size_t mem_sz, > unsigned int *src, const struct qcom_scm_vmperm *newvm, > unsigned int dest_cnt) { return -ENODEV; } > +extern inline int qcom_scm_mem_protect_video_var(u32 cp_start, u32 cp_size, > + u32 cp_nonpixel_start, > + u32 cp_nonpixel_size) > + { return -ENODEV; } > > static inline bool qcom_scm_ocmem_lock_available(void) { return false; } > static inline int qcom_scm_ocmem_lock(enum qcom_scm_ocmem_client id, u32 offset, > -- regards, Stan