From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56FA8C49361 for ; Tue, 15 Jun 2021 16:00:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 363F761465 for ; Tue, 15 Jun 2021 16:00:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232146AbhFOQCj (ORCPT ); Tue, 15 Jun 2021 12:02:39 -0400 Received: from mga14.intel.com ([192.55.52.115]:40062 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231971AbhFOQC3 (ORCPT ); Tue, 15 Jun 2021 12:02:29 -0400 IronPort-SDR: 9qtBS4XVWneRtHMPoVPg4kP1W5XRznlzKHznjKAw0Ud6P+oBKt1Bh5CwKWlaICCroD/v6Mf81s WgKxX6q3vOrA== X-IronPort-AV: E=McAfee;i="6200,9189,10016"; a="205836964" X-IronPort-AV: E=Sophos;i="5.83,275,1616482800"; d="scan'208";a="205836964" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2021 09:00:13 -0700 IronPort-SDR: VuzC0kwC5Gd7fL4dcEBxLlwVKjbOSfVaWfYUJJcNryXABhVaEK7CES8NVtdky/X2ZqPP4QFqfA bw9EeubIQywg== X-IronPort-AV: E=Sophos;i="5.83,275,1616482800"; d="scan'208";a="487823401" Received: from bgeagarc-mobl1.amr.corp.intel.com (HELO [10.209.128.67]) ([10.209.128.67]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2021 09:00:11 -0700 Subject: Re: [PATCH] ASoC: max98357a: set channels_max to 4 To: Cheng-yi Chiang , Tzung-Bi Shih Cc: Taniya Das , ALSA development , Banajit Goswami , Takashi Iwai , Rohit kumar , Patrick Lai , Andy Gross , Dylan Reid , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Tzung-Bi Shih , Stephan Gerhold , linux-arm-msm , Stephen Boyd , Rob Herring , Bjorn Andersson , "moderated list:ARM/Mediatek SoC support" , Douglas Anderson , Liam Girdwood , Mark Brown , Judy Hsiao References: <20210526154704.114957-1-judyhsiao@chromium.org> From: Pierre-Louis Bossart Message-ID: <3501e398-dfba-43b1-4638-325a158e860d@linux.intel.com> Date: Tue, 15 Jun 2021 11:00:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 6/15/21 10:47 AM, Cheng-yi Chiang wrote: > Hi Tzung-Bi, > > On a platform, the four max98357a amps will be controlled by only one > codec device, as GPIO for SD_MODE is shared by all amps and is the > only thing to be controlled. > In this sense, I think we can treat max98357a DAI as if it supports > four channels. > I understand that this solution is not scalable, because one can > control as many amps as they want. > Theoretically, the number of supported channels by this codec device > is unlimited. > I found that rt1015.c has similar usage. > Do you have a better suggestion to support this kind of use case ? > Thanks! please don't top-post... I don't think it's correct to declare 4-channel support at the individual codec DAI level when in practice each device will be provided with a TDM mask that selects two slots. This is confusing device capabilities and TDM link configuration. > On Tue, Jun 1, 2021 at 2:20 PM Tzung-Bi Shih wrote: >> >> On Wed, May 26, 2021 at 11:47 PM Judy Hsiao wrote: >>> Sets channels_max to 4 to support QUAD channel. >> >> Could you point out probably the up-to-date MAX98357A datasheet for >> 4-channel support? >> >> On a related note, from the public datasheet I could find[1], "Table >> 5" only shows 2 channel's configuration. >> >> [1]: https://pdf1.alldatasheet.com/datasheet-pdf/view/623796/MAXIM/MAX98357A.html