From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Jonathan Marek <jonathan@marek.ca>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v1 1/3] dt-bindings: clock: qcom,dispcc: document power domain bindings
Date: Wed, 14 Oct 2020 12:36:50 +0300 [thread overview]
Message-ID: <36c5d7dc-7b31-69d1-6862-4432ee22a2c4@linaro.org> (raw)
In-Reply-To: <160263639992.310579.2985110685040776427@swboyd.mtv.corp.google.com>
On 14/10/2020 03:46, Stephen Boyd wrote:
> Quoting Dmitry Baryshkov (2020-10-05 15:59:12)
>> SM8250 requires special power domain for accessing MMDS_GDSC registers.
>
> Heh, not sure it's special.
>
>> Add bindings for the MMCX power domain.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>> .../bindings/clock/qcom,sdm845-dispcc.yaml | 28 +++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sdm845-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sdm845-dispcc.yaml
>> index 4a3be733d042..ff0db55470ac 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,sdm845-dispcc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sdm845-dispcc.yaml
>> @@ -97,5 +108,22 @@ examples:
>> #clock-cells = <1>;
>> #reset-cells = <1>;
>> #power-domain-cells = <1>;
>> + /* this is a part of sm8250 setup the power domain example */
>> + power-domains = <&rpmhpd SDM845_CX>;
>> + power-domain-names = "mmcx";
>> + required-opps = <&rpmhpd_opp_low_svs>;
>> + };
>> + rpmhpd: power-controller {
>
> Do we need this node in the example? I think it isn't required but I
> guess it's OK.
It is to be able to resolve "power-domains" and "required-opps"
properties values.
>> + compatible = "qcom,sdm845-rpmhpd";
>> + #power-domain-cells = <1>;
>> + operating-points-v2 = <&rpmhpd_opp_table>;
>> +
>> + rpmhpd_opp_table: opp-table {
>> + compatible = "operating-points-v2";
>> +
>> + rpmhpd_opp_low_svs: opp3 {
--
With best wishes
Dmitry
next prev parent reply other threads:[~2020-10-14 9:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 22:59 [PATCH v1 0/3] clk: qcom: handle power domains supplies for GDSC Dmitry Baryshkov
2020-10-05 22:59 ` [PATCH v1 1/3] dt-bindings: clock: qcom,dispcc: document power domain bindings Dmitry Baryshkov
2020-10-14 0:46 ` Stephen Boyd
2020-10-14 9:36 ` Dmitry Baryshkov [this message]
2020-10-14 2:17 ` Stephen Boyd
2020-10-05 22:59 ` [PATCH v1 2/3] clk: qcom: gdsc: enable external switchable power domain Dmitry Baryshkov
2020-10-14 2:15 ` Stephen Boyd
2020-10-14 9:44 ` Dmitry Baryshkov
2020-10-14 17:29 ` Stephen Boyd
2020-10-05 22:59 ` [PATCH v1 3/3] clk: qcom: dispcc-sm8250: handle MMCX " Dmitry Baryshkov
2020-10-14 2:16 ` Stephen Boyd
2020-10-14 9:46 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36c5d7dc-7b31-69d1-6862-4432ee22a2c4@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).