From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v2 1/1] remoteproc: Add support for xo clock Date: Tue, 1 Nov 2016 10:52:00 -0700 Message-ID: <38cfee53-8699-b3c1-22e0-cb5355ce9387@codeaurora.org> References: <1477429046-26855-1-git-send-email-spjoshi@codeaurora.org> <20161101000555.GK25787@tuxbot> <564faf01-f4d7-4bdb-ee48-76a893d3d4c0@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:45824 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753990AbcKARwC (ORCPT ); Tue, 1 Nov 2016 13:52:02 -0400 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Bjorn Andersson Cc: Sarangdhar Joshi , Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org, lkml , linux-arm-msm , Trilok Soni On 11/01/2016 10:46 AM, Bjorn Andersson wrote: > On Tue, Nov 1, 2016 at 10:41 AM, Stephen Boyd wrote: >> On 10/31/2016 05:05 PM, Bjorn Andersson wrote: >>> On Tue 25 Oct 13:57 PDT 2016, Sarangdhar Joshi wrote: >>> >>>> Add xo clock support required to boot up Qualcomm ADSP processor. >>>> The ADSP remoteproc driver keeps xo clock enabled until the >>>> driver receives "handover" irq, in order to allow ADSP processor >>>> to vote for xo clock with rpm. >>> Looks good, thanks. >>> >>> We have to add the clock to the DT binding and run that by Rob again, >>> before merging the driver and this patch. >>> >> Maybe we should make the xo clock required. We always have a clock for >> it somewhere, either RPM controlled or as a fixed rate clock so it >> should work just as well. >> > As far as I can see it is required, after Sarangdhar's patch - so this > is what I meant we need to add to the DT binding before merging that. > And as you say, we can always make it reference "xo_board" for now. > Ah good then. Brain must have misread the patch. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project