Re: [PATCH v1 3/4] arm64: dts: Add aqp8039-t2 board

[Bryan O'Donoghue <bryan.odonoghue@linaro.org>]

On 19/04/2022 20:20, Stephan Gerhold wrote:
> On Tue, Apr 19, 2022 at 02:09:02AM +0100, Bryan O'Donoghue wrote:
>> +&otg {
>> +	status = "okay";
>> +	usb-role-switch;
>> +
>> +	pinctrl-names = "default", "host", "device";
>> +	pinctrl-0 = <&pinctrl_otg_default>;
>> +	pinctrl-1 = <&pinctrl_otg_host>;
>> +	pinctrl-2 = <&pinctrl_otg_device>;
>> +	pin-switch-delay-us = <100000>;
>> +
>> +	ulpi {
>> +		usb_hs_phy: phy {
>> +			qcom,enable-vbus-pullup;
> 
> Hm, what handles the USB detection on this port? The tps6598x?

tps yes

> Can it provide an extcon so that you don't need to keep the USB PHY
> powered permanently?

Per my understanding new extcon is verboten

This particular hardware has an internal USB hub intermediating to 
switch-in internal USB peripherals when disconnected from the external 
type-c port so, we actually don't want to switch off the PHY.

> 
>> + [...]
>> +&pronto {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&wcnss_pin_a &wcnss_pin_antennae>;
>> +	status = "okay";
>> +
>> +	iris {
>> +		compatible = "qcom,wcn3680";
>> +	};
>> +
>> +	smd-edge {
>> +		wcnss {
>> +			bt {
>> +				local-bd-address = [ 55 44 33 22 11 00 ];
> 
> Is this really needed?
> 
> The DB410c LK and U-Boot port (and also lk2nd) automatically generate a
> WiFi/BT address based on the eMMC serial number. That's probably a
> better solution than a fixed MAC address specified here.

Ah yes I remember seeing the strings being populated.
Thanks, I'll zap this.

---
bod