From: Georgi Djakov <georgi.djakov@linaro.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Vikash Garodia <vgarodia@codeaurora.org>,
Andy Gross <agross@kernel.org>,
David Dai <daidavid1@codeaurora.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: sdm845: Add interconnect properties for Venus
Date: Thu, 10 Oct 2019 17:24:26 +0300 [thread overview]
Message-ID: <3c222f45-2db7-42a7-c79a-492bb587c331@linaro.org> (raw)
In-Reply-To: <20190912082948.22836-3-stanimir.varbanov@linaro.org>
On 9/12/19 11:29, Stanimir Varbanov wrote:
> Populate Venus DT node with interconnect properties.
>
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 0323e3da190a..567bfc89bd77 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -2039,6 +2039,9 @@
> iommus = <&apps_smmu 0x10a0 0x8>,
> <&apps_smmu 0x10b0 0x0>;
> memory-region = <&venus_mem>;
> + interconnects = <&rsc_hlos MASTER_VIDEO_P0 &rsc_hlos SLAVE_EBI1>,
> + <&rsc_hlos MASTER_APPSS_PROC &rsc_hlos SLAVE_VENUS_CFG>;
> + interconnect-names = "video-mem", "cpu-cfg";
>
> video-core0 {
> compatible = "venus-decoder";
>
The patch look fine to me, but David is currently working on some patches that
split the rsc_hlos node into multiple DT nodes (for each NoC). So maybe wait
until we conclude on that first and then add Venus as user in DT.
Thanks,
Georgi
prev parent reply other threads:[~2019-10-10 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 8:29 [PATCH v2 0/2] Venus interconnect support for sdm845 Stanimir Varbanov
2019-09-12 8:29 ` [PATCH v2 1/2] venus: use on-chip interconnect API Stanimir Varbanov
2019-10-02 8:20 ` Georgi Djakov
2019-09-12 8:29 ` [PATCH v2 2/2] arm64: dts: sdm845: Add interconnect properties for Venus Stanimir Varbanov
2019-10-10 14:24 ` Georgi Djakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c222f45-2db7-42a7-c79a-492bb587c331@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=agross@kernel.org \
--cc=daidavid1@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=stanimir.varbanov@linaro.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).