From: Maulik Shah <mkshah@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: swboyd@chromium.org, mka@chromium.org, evgreen@chromium.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
agross@kernel.org, dianders@chromium.org, linux@roeck-us.net,
rnayak@codeaurora.org, ilina@codeaurora.org,
lsrao@codeaurora.org,
Mahesh Sivasubramanian <msivasub@codeaurora.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v6 1/4] dt-bindings: Introduce SoC sleep stats bindings
Date: Tue, 6 Apr 2021 11:55:33 +0530 [thread overview]
Message-ID: <3d131469-965a-0a31-a04c-5881feb41b13@codeaurora.org> (raw)
In-Reply-To: <YEuhxqDRly658D9S@builder.lan>
Hi,
On 3/12/2021 10:45 PM, Bjorn Andersson wrote:
> On Thu 04 Feb 08:21 CST 2021, Maulik Shah wrote:
>
>> From: Mahesh Sivasubramanian <msivasub@codeaurora.org>
>>
>> Add device binding documentation for Qualcomm Technologies, Inc. (QTI)
>> SoC sleep stats driver. The driver is used for displaying SoC sleep
>> statistic maintained by Always On Processor or Resource Power Manager.
>>
>> Cc: devicetree@vger.kernel.org
>> Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org>
>> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
>> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>> ---
>> .../bindings/soc/qcom/soc-sleep-stats.yaml | 46 ++++++++++++++++++++++
>> 1 file changed, 46 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
>> new file mode 100644
>> index 0000000..1e012ba
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
>> @@ -0,0 +1,46 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/soc/qcom/soc-sleep-stats.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Technologies, Inc. (QTI) SoC sleep stats bindings
>> +
>> +maintainers:
>> + - Maulik Shah <mkshah@codeaurora.org>
>> + - Lina Iyer <ilina@codeaurora.org>
>> +
>> +description:
>> + Always On Processor/Resource Power Manager maintains statistics of the SoC
>> + sleep modes involving powering down of the rails and oscillator clock.
>> +
>> + Statistics includes SoC sleep mode type, number of times low power mode were
>> + entered, time of last entry, time of last exit and accumulated sleep duration.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - qcom,rpmh-sleep-stats
>> + - qcom,rpm-sleep-stats
>> +
>> + reg:
>> + maxItems: 1
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>> +examples:
>> + # Example of rpmh sleep stats
>> + - |
>> + rpmh-sleep-stats@c3f0000 {
>> + compatible = "qcom,rpmh-sleep-stats";
>> + reg = <0 0x0c3f0000 0 0x400>;
> The example is built with #address-cells = <1> and #size-cells = <1>, so
> this needs to be reg = <0x0c3f0000 0x400>.
>
> Regards,
> Bjorn
Thanks, Fixed in v7.
Thanks,
Maulik
>
>> + };
>> + # Example of rpm sleep stats
>> + - |
>> + rpm-sleep-stats@4690000 {
>> + compatible = "qcom,rpm-sleep-stats";
>> + reg = <0 0x04690000 0 0x400>;
>> + };
>> +...
>> --
>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
>> of Code Aurora Forum, hosted by The Linux Foundation
>>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2021-04-06 6:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 14:21 [PATCH v6 0/4] Introduce SoC sleep stats driver Maulik Shah
2021-02-04 14:21 ` [PATCH v6 1/4] dt-bindings: Introduce SoC sleep stats bindings Maulik Shah
2021-02-04 21:09 ` Rob Herring
2021-02-09 0:23 ` Stephen Boyd
2021-03-12 17:14 ` Bjorn Andersson
2021-03-12 17:15 ` Bjorn Andersson
2021-04-06 6:25 ` Maulik Shah [this message]
2021-02-04 14:21 ` [PATCH v6 2/4] soc: qcom: Add SoC sleep stats driver Maulik Shah
2021-02-07 10:25 ` kernel test robot
2021-02-09 0:42 ` Stephen Boyd
2021-04-06 6:40 ` Maulik Shah
2021-02-04 14:21 ` [PATCH v6 3/4] arm64: dts: qcom: sc7180: Enable SoC sleep stats Maulik Shah
2021-02-04 14:21 ` [PATCH v6 4/4] arm64: defconfig: Enable SoC sleep stats driver Maulik Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d131469-965a-0a31-a04c-5881feb41b13@codeaurora.org \
--to=mkshah@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lsrao@codeaurora.org \
--cc=mka@chromium.org \
--cc=msivasub@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).