From: Steev Klimaszewski <steev@kali.org>
To: Kalle Valo <kvalo@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Govind Singh <govinds@codeaurora.org>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] ath10k: do not enforce interrupt trigger type
Date: Sat, 14 May 2022 00:05:46 -0500 [thread overview]
Message-ID: <3d856d44-a2d6-b5b8-ec78-ce19a3686986@kali.org> (raw)
In-Reply-To: <87zgjl4e8t.fsf@kernel.org>
On 5/13/22 10:57 AM, Kalle Valo wrote:
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
>
>> Interrupt line can be configured on different hardware in different way,
>> even inverted. Therefore driver should not enforce specific trigger
>> type - edge rising - but instead rely on Devicetree to configure it.
>>
>> All Qualcomm DTSI with WCN3990 define the interrupt type as level high,
>> so the mismatch between DTSI and driver causes rebind issues:
>>
>> $ echo 18800000.wifi > /sys/bus/platform/drivers/ath10k_snoc/unbind
>> $ echo 18800000.wifi > /sys/bus/platform/drivers/ath10k_snoc/bind
>> [ 44.763114] irq: type mismatch, failed to map hwirq-446 for interrupt-controller@17a00000!
>> [ 44.763130] ath10k_snoc 18800000.wifi: error -ENXIO: IRQ index 0 not found
>> [ 44.763140] ath10k_snoc 18800000.wifi: failed to initialize resource: -6
> So you tested on WCN3990? On what firmware version? I can add the
> Tested-on tag if you provide that.
>
Hello Krzystof, Kalle,
I have seen this issue as well on a Lenovo Flex 5G, which has a WCN3990:
wcn3990 hw1.0 target 0x00000008 chip_id 0x00000000 sub 0000:0000
kconfig debug 0 debugfs 0 tracing 0 dfs 0 testmode 0
firmware ver api 5 features wowlan,mgmt-tx-by-reference,non-bmi crc32
b3d4b790
htt-ver 3.86 wmi-op 4 htt-op 3 cal file max-sta 32 raw 0 hwcrypto 1
With this patch applied, I no longer see the error message in the commit
message, when I unbind/bind when wifi stops working.
Tested-by: Steev Klimaszewski <steev@kali.org>
-- Steev
next prev parent reply other threads:[~2022-05-14 5:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 15:15 [PATCH] ath10k: do not enforce interrupt trigger type Krzysztof Kozlowski
2022-05-13 15:57 ` Kalle Valo
2022-05-14 5:05 ` Steev Klimaszewski [this message]
2022-05-14 18:09 ` Steev Klimaszewski
2022-05-14 19:32 ` Krzysztof Kozlowski
2022-05-18 7:18 ` Kalle Valo
2022-05-14 19:32 ` Krzysztof Kozlowski
2022-05-22 12:22 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d856d44-a2d6-b5b8-ec78-ce19a3686986@kali.org \
--to=steev@kali.org \
--cc=ath10k@lists.infradead.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=govinds@codeaurora.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).