From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 936FBC433DB for ; Fri, 5 Mar 2021 22:46:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 547D164F4A for ; Fri, 5 Mar 2021 22:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229637AbhCEWpu (ORCPT ); Fri, 5 Mar 2021 17:45:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhCEWpY (ORCPT ); Fri, 5 Mar 2021 17:45:24 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2005AC06175F for ; Fri, 5 Mar 2021 14:45:24 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id z11so6285414lfb.9 for ; Fri, 05 Mar 2021 14:45:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FOK/3RIskxWxbqQcsQFEJPI1xEXUn3wcudWwNgFLA5Y=; b=esQGue9YpbsE2BnWamAL/QS+ol5Ucaio/gc+QJfuWX9TbLxhuL05JRd3iaSTfMM+ZT SiCIUdqkt8tbyazqA3tu4C1PT9WRxXlhvtGblEcwUnghR/sk7FrHE67qdwjza+l+FWXu tTGzH4Z61uWCAwD3mS/yzOaQgAJkJBJ6cm7lrbwi7pH64elU8VDOJG7h+NmyHFy6mxKK Xlu0PLQqVpRdSt7LgyjGRKDhJEoscP5+lkzj8Q1c5YJB+1WYs5tANy1gVnyQpDO4Hn8B K9cNNmZT/qed/93qTT31VIuLDADjh5aUelqOSHsu+S+4isIjhjinDO4yR1RZGtqmZ7Dv ljwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FOK/3RIskxWxbqQcsQFEJPI1xEXUn3wcudWwNgFLA5Y=; b=smGh59lDvkkuaIlriSb3NIFeldBLOFBmEstp5QIZLLwUbPmKjthCAo8x00txdd0pvB EhuSP8SmCJJYSPgZ39P/SipSw78DmqVPwyY+GwkB9pd+3k2DUnSu4OPlN2oU9iswFIyj 1f3ExacMdgPe+4g5ShxePukybSOen0KYg+w/zK48VTPsAIrK4dF+VDH4NklMJ8VYA9ie 6JmG5xco09Eg4oyXXhzAMJWik+QOk6Tszy97+Kafqo1oxvaJvZo9+sqLZSHwfNUlIBde LayjKY9NHXDVV36y86Sbs/7b6soMfN6p9nKN3p6+tLuZe7DNpaBFNHGYauD5cpuox7VP 0+qA== X-Gm-Message-State: AOAM532KJKRovnC9WEVObKFrYDZH0JQ4jV8budtlXA9hkQT9iL2TaecX 1YfjaFL58WG7Q/9uUIktACUnrw== X-Google-Smtp-Source: ABdhPJxjyVuZEQnq1OV6y0hg3sDLiB7MWslzlTpE7fxnRrUrVIFuHPqDIijjs0T2rvjKc5sWEMYCfQ== X-Received: by 2002:a05:6512:230f:: with SMTP id o15mr6940292lfu.326.1614984322570; Fri, 05 Mar 2021 14:45:22 -0800 (PST) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id 3sm468042lfq.1.2021.03.05.14.45.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 14:45:22 -0800 (PST) Subject: Re: [PATCH] drm/msm/dsi: support CPHY mode for 7nm pll/phy To: Jonathan Marek , freedreno@lists.freedesktop.org Cc: Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Douglas Anderson , Kalyan Thota , Jordan Crouse , "Kristian H. Kristensen" , Sam Ravnborg , Rikard Falkeborn , Emil Velikov , Viresh Kumar , Rajendra Nayak , Konrad Dybcio , Dave Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20210215162805.21481-1-jonathan@marek.ca> From: Dmitry Baryshkov Message-ID: <3e511cd9-2dbc-abf0-23c0-26779eb1777f@linaro.org> Date: Sat, 6 Mar 2021 01:45:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210215162805.21481-1-jonathan@marek.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 15/02/2021 19:27, Jonathan Marek wrote: > Add the required changes to support 7nm pll/phy in CPHY mode. > > This adds a "qcom,dsi-phy-cphy-mode" property for the PHY node to enable > the CPHY mode. > > Signed-off-by: Jonathan Marek Other that few comments bellow: Reviewed-by: Dmitry Baryshkov > --- > .../devicetree/bindings/display/msm/dsi.txt | 1 + > drivers/gpu/drm/msm/dsi/dsi.c | 12 +-- > drivers/gpu/drm/msm/dsi/dsi.h | 6 +- > drivers/gpu/drm/msm/dsi/dsi.xml.h | 2 + > drivers/gpu/drm/msm/dsi/dsi_host.c | 34 +++++-- > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 49 +++++++++- > drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 3 + > drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 89 ++++++++++++++----- > drivers/gpu/drm/msm/dsi/pll/dsi_pll.c | 4 +- > drivers/gpu/drm/msm/dsi/pll/dsi_pll.h | 5 +- > drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c | 71 +++++++++------ > 11 files changed, 210 insertions(+), 66 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi.txt b/Documentation/devicetree/bindings/display/msm/dsi.txt > index b9a64d3ff184..7ffc86a9816b 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi.txt > +++ b/Documentation/devicetree/bindings/display/msm/dsi.txt > @@ -124,6 +124,7 @@ Required properties: > Optional properties: > - qcom,dsi-phy-regulator-ldo-mode: Boolean value indicating if the LDO mode PHY > regulator is wanted. > +- qcom,dsi-phy-cphy-mode: Boolean value indicating if CPHY mode is wanted. > - qcom,mdss-mdp-transfer-time-us: Specifies the dsi transfer time for command mode > panels in microseconds. Driver uses this number to adjust > the clock rate according to the expected transfer time. This should go in a separate patch, shan't it? > diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c > index 627048851d99..68d8547f7264 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi.c > +++ b/drivers/gpu/drm/msm/dsi/dsi.c > @@ -13,7 +13,7 @@ struct drm_encoder *msm_dsi_get_encoder(struct msm_dsi *msm_dsi) > return msm_dsi->encoder; > } > > -static int dsi_get_phy(struct msm_dsi *msm_dsi) > +static int dsi_get_phy(struct msm_dsi *msm_dsi, bool *cphy_mode) I see no need to pass the 'cphy_mode' through the bool pointer and back to msm_dsi_host_init. What about just putting it into struct msm_dsi? > { > struct platform_device *pdev = msm_dsi->pdev; > struct platform_device *phy_pdev; > @@ -29,6 +29,7 @@ static int dsi_get_phy(struct msm_dsi *msm_dsi) > if (phy_pdev) > msm_dsi->phy = platform_get_drvdata(phy_pdev); > > + *cphy_mode = of_property_read_bool(phy_node, "qcom,dsi-phy-cphy-mode"); > of_node_put(phy_node); > > if (!phy_pdev || !msm_dsi->phy) { > @@ -65,6 +66,7 @@ static void dsi_destroy(struct msm_dsi *msm_dsi) > static struct msm_dsi *dsi_init(struct platform_device *pdev) > { > struct msm_dsi *msm_dsi; > + bool cphy_mode; > int ret; > > if (!pdev) > @@ -79,13 +81,13 @@ static struct msm_dsi *dsi_init(struct platform_device *pdev) > msm_dsi->pdev = pdev; > platform_set_drvdata(pdev, msm_dsi); > > - /* Init dsi host */ > - ret = msm_dsi_host_init(msm_dsi); > + /* GET dsi PHY */ > + ret = dsi_get_phy(msm_dsi, &cphy_mode); > if (ret) > goto destroy_dsi; > > - /* GET dsi PHY */ > - ret = dsi_get_phy(msm_dsi); > + /* Init dsi host */ > + ret = msm_dsi_host_init(msm_dsi, cphy_mode); > if (ret) > goto destroy_dsi; -- With best wishes Dmitry