From: Adrian Hunter <adrian.hunter@intel.com>
To: Asutosh Das <asutoshd@codeaurora.org>,
cang@codeaurora.org, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bean Huo <beanhuo@micron.com>, Yue Hu <huyue2@yulong.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v18 2/2] ufs: sysfs: Resume the proper scsi device
Date: Thu, 15 Apr 2021 12:21:52 +0300 [thread overview]
Message-ID: <3e88725f-166d-114b-506d-17a41c2a5c72@intel.com> (raw)
In-Reply-To: <4745814f5fa37d49e969c2ffb1b4df401dbc98e7.1618426513.git.asutoshd@codeaurora.org>
On 14/04/21 9:58 pm, Asutosh Das wrote:
> Resumes the actual scsi device the unit descriptor of which
> is being accessed instead of the hba alone.
>
> Reviewed-by: Can Guo <cang@codeaurora.org>
> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/scsi/ufs/ufs-sysfs.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-sysfs.c b/drivers/scsi/ufs/ufs-sysfs.c
> index d7c3cff..4d9d4d8 100644
> --- a/drivers/scsi/ufs/ufs-sysfs.c
> +++ b/drivers/scsi/ufs/ufs-sysfs.c
> @@ -245,9 +245,9 @@ static ssize_t wb_on_store(struct device *dev, struct device_attribute *attr,
> goto out;
> }
>
> - pm_runtime_get_sync(hba->dev);
> + ufshcd_rpm_get_sync(hba);
> res = ufshcd_wb_toggle(hba, wb_enable);
> - pm_runtime_put_sync(hba->dev);
> + ufshcd_rpm_put_sync(hba);
> out:
> up(&hba->host_sem);
> return res < 0 ? res : count;
> @@ -297,10 +297,10 @@ static ssize_t ufs_sysfs_read_desc_param(struct ufs_hba *hba,
> goto out;
> }
>
> - pm_runtime_get_sync(hba->dev);
> + ufshcd_rpm_get_sync(hba);
> ret = ufshcd_read_desc_param(hba, desc_id, desc_index,
> param_offset, desc_buf, param_size);
> - pm_runtime_put_sync(hba->dev);
> + ufshcd_rpm_put_sync(hba);
> if (ret) {
> ret = -EINVAL;
> goto out;
> @@ -678,7 +678,7 @@ static ssize_t _name##_show(struct device *dev, \
> up(&hba->host_sem); \
> return -ENOMEM; \
> } \
> - pm_runtime_get_sync(hba->dev); \
> + ufshcd_rpm_get_sync(hba); \
> ret = ufshcd_query_descriptor_retry(hba, \
> UPIU_QUERY_OPCODE_READ_DESC, QUERY_DESC_IDN_DEVICE, \
> 0, 0, desc_buf, &desc_len); \
> @@ -695,7 +695,7 @@ static ssize_t _name##_show(struct device *dev, \
> goto out; \
> ret = sysfs_emit(buf, "%s\n", desc_buf); \
> out: \
> - pm_runtime_put_sync(hba->dev); \
> + ufshcd_rpm_put_sync(hba); \
> kfree(desc_buf); \
> up(&hba->host_sem); \
> return ret; \
> @@ -744,10 +744,10 @@ static ssize_t _name##_show(struct device *dev, \
> } \
> if (ufshcd_is_wb_flags(QUERY_FLAG_IDN##_uname)) \
> index = ufshcd_wb_get_query_index(hba); \
> - pm_runtime_get_sync(hba->dev); \
> + ufshcd_rpm_get_sync(hba); \
> ret = ufshcd_query_flag(hba, UPIU_QUERY_OPCODE_READ_FLAG, \
> QUERY_FLAG_IDN##_uname, index, &flag); \
> - pm_runtime_put_sync(hba->dev); \
> + ufshcd_rpm_put_sync(hba); \
> if (ret) { \
> ret = -EINVAL; \
> goto out; \
> @@ -813,10 +813,10 @@ static ssize_t _name##_show(struct device *dev, \
> } \
> if (ufshcd_is_wb_attrs(QUERY_ATTR_IDN##_uname)) \
> index = ufshcd_wb_get_query_index(hba); \
> - pm_runtime_get_sync(hba->dev); \
> + ufshcd_rpm_get_sync(hba); \
> ret = ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR, \
> QUERY_ATTR_IDN##_uname, index, 0, &value); \
> - pm_runtime_put_sync(hba->dev); \
> + ufshcd_rpm_put_sync(hba); \
> if (ret) { \
> ret = -EINVAL; \
> goto out; \
> @@ -964,10 +964,10 @@ static ssize_t dyn_cap_needed_attribute_show(struct device *dev,
> goto out;
> }
>
> - pm_runtime_get_sync(hba->dev);
> + ufshcd_rpm_get_sync(hba);
> ret = ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,
> QUERY_ATTR_IDN_DYN_CAP_NEEDED, lun, 0, &value);
> - pm_runtime_put_sync(hba->dev);
> + ufshcd_rpm_put_sync(hba);
> if (ret) {
> ret = -EINVAL;
> goto out;
>
prev parent reply other threads:[~2021-04-15 9:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 18:58 [PATCH v18 0/2] Enable power management for ufs wlun Asutosh Das
2021-04-14 18:58 ` [PATCH v18 1/2] scsi: ufs: Enable power management for wlun Asutosh Das
2021-04-14 22:41 ` kernel test robot
2021-04-15 11:06 ` Adrian Hunter
2021-04-15 18:22 ` Dan Carpenter
2021-04-15 23:11 ` Bart Van Assche
2021-04-16 2:10 ` Martin K. Petersen
2021-04-16 18:21 ` Asutosh Das (asd)
2021-04-14 18:58 ` [PATCH v18 2/2] ufs: sysfs: Resume the proper scsi device Asutosh Das
2021-04-15 9:21 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e88725f-166d-114b-506d-17a41c2a5c72@intel.com \
--to=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=huyue2@yulong.com \
--cc=jejb@linux.ibm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).