From: Robin Murphy <robin.murphy@arm.com>
To: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>,
Jordan Crouse <jcrouse@codeaurora.org>,
Rob Clark <robdclark@gmail.com>
Cc: "iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Tomasz Figa <tfiga@chromium.org>
Subject: Re: [PATCH 2/2] iommu/arm-smmu: Allow client devices to select direct mapping
Date: Thu, 16 Apr 2020 14:58:25 +0100 [thread overview]
Message-ID: <3f12cefb-3887-859c-ddf5-c7a0fc755152@arm.com> (raw)
In-Reply-To: <813cc5b2da10c27db982254b274bf26008a9e6da.1579692800.git.saiprakash.ranjan@codeaurora.org>
On 2020-01-22 11:48 am, Sai Prakash Ranjan wrote:
> From: Jordan Crouse <jcrouse@codeaurora.org>
>
> Some client devices want to directly map the IOMMU themselves instead
> of using the DMA domain. Allow those devices to opt in to direct
> mapping by way of a list of compatible strings.
>
> Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> Co-developed-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> ---
> drivers/iommu/arm-smmu-qcom.c | 39 +++++++++++++++++++++++++++++++++++
> drivers/iommu/arm-smmu.c | 3 +++
> drivers/iommu/arm-smmu.h | 5 +++++
> 3 files changed, 47 insertions(+)
>
> diff --git a/drivers/iommu/arm-smmu-qcom.c b/drivers/iommu/arm-smmu-qcom.c
> index 64a4ab270ab7..ff746acd1c81 100644
> --- a/drivers/iommu/arm-smmu-qcom.c
> +++ b/drivers/iommu/arm-smmu-qcom.c
> @@ -3,6 +3,7 @@
> * Copyright (c) 2019, The Linux Foundation. All rights reserved.
> */
>
> +#include <linux/of_device.h>
> #include <linux/qcom_scm.h>
>
> #include "arm-smmu.h"
> @@ -11,6 +12,43 @@ struct qcom_smmu {
> struct arm_smmu_device smmu;
> };
>
> +static const struct arm_smmu_client_match_data qcom_adreno = {
> + .direct_mapping = true,
> +};
> +
> +static const struct arm_smmu_client_match_data qcom_mdss = {
> + .direct_mapping = true,
> +};
Might it make sense to group these by the desired SMMU behaviour rather
than (apparently) what kind of device the client happens to be, which
seems like a completely arbitrary distinction from the SMMU driver's PoV?
> +
> +static const struct of_device_id qcom_smmu_client_of_match[] = {
> + { .compatible = "qcom,adreno", .data = &qcom_adreno },
> + { .compatible = "qcom,mdp4", .data = &qcom_mdss },
> + { .compatible = "qcom,mdss", .data = &qcom_mdss },
> + { .compatible = "qcom,sc7180-mdss", .data = &qcom_mdss },
> + { .compatible = "qcom,sdm845-mdss", .data = &qcom_mdss },
> + {},
> +};
> +
> +static const struct arm_smmu_client_match_data *
> +qcom_smmu_client_data(struct device *dev)
> +{
> + const struct of_device_id *match =
> + of_match_device(qcom_smmu_client_of_match, dev);
> +
> + return match ? match->data : NULL;
of_device_get_match_data() is your friend.
> +}
> +
> +static int qcom_smmu_request_domain(struct device *dev)
> +{
> + const struct arm_smmu_client_match_data *client;
> +
> + client = qcom_smmu_client_data(dev);
> + if (client)
> + iommu_request_dm_for_dev(dev);
> +
> + return 0;
> +}
> +
> static int qcom_sdm845_smmu500_reset(struct arm_smmu_device *smmu)
> {
> int ret;
> @@ -41,6 +79,7 @@ static int qcom_smmu500_reset(struct arm_smmu_device *smmu)
> }
>
> static const struct arm_smmu_impl qcom_smmu_impl = {
> + .req_domain = qcom_smmu_request_domain,
> .reset = qcom_smmu500_reset,
> };
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index 16c4b87af42b..67dd9326247a 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1448,6 +1448,9 @@ static int arm_smmu_add_device(struct device *dev)
> device_link_add(dev, smmu->dev,
> DL_FLAG_PM_RUNTIME | DL_FLAG_AUTOREMOVE_SUPPLIER);
>
> + if (smmu->impl && smmu->impl->req_domain)
> + return smmu->impl->req_domain(dev);
> +
There are about 5 different patchsets flying around at the moment that
all touch default domain allocation, so this is a fast-moving target,
but I think where the dust should settle is with arm_smmu_ops forwarding
.def_domain_type (or whatever it ends up as) calls to arm_smmu_impl as
appropriate.
> return 0;
>
> out_cfg_free:
> diff --git a/drivers/iommu/arm-smmu.h b/drivers/iommu/arm-smmu.h
> index 8d1cd54d82a6..059dc9c39f64 100644
> --- a/drivers/iommu/arm-smmu.h
> +++ b/drivers/iommu/arm-smmu.h
> @@ -244,6 +244,10 @@ enum arm_smmu_arch_version {
> ARM_SMMU_V2,
> };
>
> +struct arm_smmu_client_match_data {
> + bool direct_mapping;
> +};
Does this need to be public? I don't see the other users...
Robin.
> +
> enum arm_smmu_implementation {
> GENERIC_SMMU,
> ARM_MMU500,
> @@ -386,6 +390,7 @@ struct arm_smmu_impl {
> int (*init_context)(struct arm_smmu_domain *smmu_domain);
> void (*tlb_sync)(struct arm_smmu_device *smmu, int page, int sync,
> int status);
> + int (*req_domain)(struct device *dev);
> };
>
> static inline void __iomem *arm_smmu_page(struct arm_smmu_device *smmu, int n)
>
next prev parent reply other threads:[~2020-04-16 13:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 11:48 [PATCH 0/2] iommu/arm-smmu: Allow client devices to select direct mapping Sai Prakash Ranjan
2020-01-22 11:48 ` [PATCH 1/2] iommu: arm-smmu-impl: Convert to a generic reset implementation Sai Prakash Ranjan
2020-02-09 0:00 ` Bjorn Andersson
2020-02-14 2:44 ` Stephen Boyd
2020-04-16 13:33 ` Robin Murphy
2020-01-22 11:48 ` [PATCH 2/2] iommu/arm-smmu: Allow client devices to select direct mapping Sai Prakash Ranjan
2020-04-13 23:12 ` Evan Green
2020-04-14 16:18 ` Sai Prakash Ranjan
2020-04-16 13:58 ` Robin Murphy [this message]
2020-04-16 16:23 ` Sai Prakash Ranjan
2020-04-16 17:17 ` Robin Murphy
2020-04-16 17:43 ` Sai Prakash Ranjan
2020-02-04 17:42 ` [PATCH 0/2] " Sai Prakash Ranjan
2020-04-09 23:31 ` Matthias Kaehlcke
2020-04-11 9:20 ` Sai Prakash Ranjan
2020-04-13 15:12 ` Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f12cefb-3887-859c-ddf5-c7a0fc755152@arm.com \
--to=robin.murphy@arm.com \
--cc=bjorn.andersson@linaro.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jcrouse@codeaurora.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=tfiga@chromium.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).