From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Rob Herring <robh@kernel.org>,
Martin Botka <martin.botka@somainline.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
angelogioacchino.delregno@somainline.org,
marijn.suijten@somainline.org, jamipkettunen@somainline.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/2] dt-bindings: clk: qcom: gcc-sm6125: Document SM6125 GCC driver
Date: Sat, 5 Jun 2021 12:56:11 +0200 [thread overview]
Message-ID: <4072d11b-0d5c-df57-399c-5ead810d8947@somainline.org> (raw)
In-Reply-To: <20210602190841.GA3792989@robh.at.kernel.org>
> Dual license new bindings please:
>
> GPL-2.0-only OR BSD-2-Clause
Ack.
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/qcom,gcc-sm6125.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Global Clock & Reset Controller Binding for SM6125
>> +
>> +maintainers:
>> + - Konrad Dybcio <konrad.dybcio@somainline.org>
>> +
>> +description: |
>> + Qualcomm global clock control module which supports the clocks, resets and
>> + power domains on SM6125.
>> +
>> + See also:
>> + - dt-bindings/clock/qcom,gcc-sm6125.h
>> +
>> +properties:
>> + compatible:
>> + const: qcom,gcc-sm6125
> The normal ordering would be 'qcom,sm6125-gcc'
The current one is in line with all the other qcom clk drivers.
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/qcom,rpmcc.h>
>> + clock-controller@1400000 {
>> + compatible = "qcom,gcc-sm6125";
> Wrong indentation.
Ack.
Konrad
next prev parent reply other threads:[~2021-06-05 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 18:43 [PATCH V3 1/2] dt-bindings: clk: qcom: gcc-sm6125: Document SM6125 GCC driver Martin Botka
2021-06-02 19:08 ` Rob Herring
2021-06-05 10:56 ` Konrad Dybcio [this message]
[not found] ` <20210526184325.675736-2-martin.botka@somainline.org>
2021-06-02 19:10 ` [PATCH V3 2/2] clk: qcom: Add SM6125 (TRINKET) " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4072d11b-0d5c-df57-399c-5ead810d8947@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jamipkettunen@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).