From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Bhaumik Bhatt <bbhatt@codeaurora.org>, mani@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
hemantk@codeaurora.org
Subject: Re: [PATCH v2 4/8] bus: mhi: core: Handle firmware load using state worker
Date: Tue, 28 Apr 2020 08:27:30 -0600 [thread overview]
Message-ID: <407b5720-b1df-c7e0-b676-baad3d148d56@codeaurora.org> (raw)
In-Reply-To: <1588042766-17496-5-git-send-email-bbhatt@codeaurora.org>
Err, you fixed the SOB on patches 1-3, but now broke 4+.
On 4/27/2020 8:59 PM, Bhaumik Bhatt wrote:
No "From: ..." means you are the author.
> Upon power up, driver queues firmware worker thread if the execution
> environment is PBL. Firmware worker is blocked with a timeout until
> state worker gets a chance to run and unblock firmware worker. An
> endpoint power up failure can be seen if state worker gets a chance to
> run after firmware worker has timed out. Remove this dependency and
> handle firmware load directly using state worker thread.
>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
SOB from you meets the developers certificate of origin.
> Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
SOB from Hemant here, is confusing. This would normally signal that
Hemant is sending a patch you authored (ie patches 1-3 are authored by
Hemant but you posted them to list), and he is attesting that he has the
right to do so (certificate of origin), but this email came from you.
This doesn't add up.
If you are trying to imply that Hemant wrote this change with you, there
is a Co-authored-by tag you can use (goes before the SOB) to indicate
multiple authors since git only has a single author field. The
Documentation/process/submitting-patches I pointed out on v1 should have
the details for this.
Otherwise, you are listed as the author, and the patch has your SOB,
therefore nothing else is needed.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-04-28 14:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 2:59 [RESEND PATCH v2 0/8] Bug fixes and improved logging in MHI Bhaumik Bhatt
2020-04-28 2:59 ` [PATCH v2 1/8] bus: mhi: core: Cache intmod from mhi event to mhi channel Bhaumik Bhatt
2020-04-28 14:39 ` Jeffrey Hugo
2020-04-29 17:27 ` Hemant Kumar
2020-04-28 2:59 ` [PATCH v2 2/8] bus: mhi: core: Add range check for channel id received in event ring Bhaumik Bhatt
2020-04-28 14:44 ` Jeffrey Hugo
2020-04-29 17:29 ` Hemant Kumar
2020-04-28 2:59 ` [PATCH v2 3/8] bus: mhi: core: Read transfer length from an event properly Bhaumik Bhatt
2020-04-28 14:50 ` Jeffrey Hugo
2020-04-29 17:30 ` Hemant Kumar
2020-04-28 2:59 ` [PATCH v2 4/8] bus: mhi: core: Handle firmware load using state worker Bhaumik Bhatt
2020-04-28 14:27 ` Jeffrey Hugo [this message]
2020-04-28 2:59 ` [PATCH v2 5/8] bus: mhi: core: WARN_ON for malformed vector table Bhaumik Bhatt
2020-04-28 2:59 ` [PATCH v2 6/8] bus: mhi: core: Return appropriate error codes for AMSS load failure Bhaumik Bhatt
2020-04-28 2:59 ` [PATCH v2 7/8] bus: mhi: core: Improve debug logs for loading firmware Bhaumik Bhatt
2020-04-28 2:59 ` [PATCH v2 8/8] bus: mhi: core: Ensure non-zero session or sequence ID values Bhaumik Bhatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=407b5720-b1df-c7e0-b676-baad3d148d56@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).