From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEA69C433E2 for ; Tue, 8 Sep 2020 20:01:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96DAB20658 for ; Tue, 8 Sep 2020 20:01:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=marek-ca.20150623.gappssmtp.com header.i=@marek-ca.20150623.gappssmtp.com header.b="mCT551VG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730986AbgIHUBD (ORCPT ); Tue, 8 Sep 2020 16:01:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730369AbgIHPf0 (ORCPT ); Tue, 8 Sep 2020 11:35:26 -0400 Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58B50C0619EF for ; Tue, 8 Sep 2020 06:58:38 -0700 (PDT) Received: by mail-qk1-x741.google.com with SMTP id f142so15272442qke.13 for ; Tue, 08 Sep 2020 06:58:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek-ca.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+0VeQsmoLvQuU6aBo8zkUNaslkMwNc2y2ovMYLqi8XU=; b=mCT551VGMZB94T4mxoyukc4bwxgzEzUfWwL2NvOY75ZaeJdpVQG9CBGM1bGuJrJs2d vIOmu8PzXYmtEsQLa/m2JAQSu0eJCPrcPkfvV9Ijc4QajjV3687zmTDPrqeSq1uJuG91 dsViQvLDQdy6yiU6PEXgnu4e/No+wesobtdBRKR8F3GKNMVVobwe4Q1QlOXue+A4zk2K aYi1G2PgHsePs/N6bKyI3DvK2mxmNGCtZMk5tgCkOnw4yYsxg/YOAyvDPeqBTNZj0uyF +N6GfQAzFQn/Ey3fK4fQ10k+G/OswU60JOly4rzK2N70fyiOx+Ce+/BJY+P/ccnOv329 b9ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+0VeQsmoLvQuU6aBo8zkUNaslkMwNc2y2ovMYLqi8XU=; b=Twe+tM+OuDPrY8v2BwRw0Sq5X/pKWJ2KY6zoWY4fdG6+CYtQmVFbAxGff8y4flecmz RhuZWSYzItZSqV8gVjv1dn6+HBikiHR440zo0/U9hv6IWRLcc1aznWbqxtOmKoHGbn81 PXGJaodP3ElJl7a+I3W1rSS86hQJQGFm8s6qarN1hcfSiXyAabhcfHWexl1Cz0X8t0TS ZipC8p5QVRaIMKoJLF6e5NtYS9z+eo+0PXZpJcmDI+CQDmTFM5KWXjuPRd7kvv7RLTRL 5kTqyxKdivzIbP2EXGlSW+Ax/jCn9pCSVDU5fbcsYG+Cn2k5A4rph1H0pGjqmSN0wSVw bIdw== X-Gm-Message-State: AOAM531nzYiOuYvOkpxS4PPpl2V7DQI5e3e/8v2pJs3jpmeDQr5fLeKe vHApfUJtk4KUP9ro6zuaffkyCw== X-Google-Smtp-Source: ABdhPJzENRkC0WQz6clGvHTyG+K0LCw8iXyZ0zOHXituNkpO4M4F4y2QK9X/EX38k0eqbQaYJJPsSw== X-Received: by 2002:a37:b201:: with SMTP id b1mr224085qkf.10.1599573517558; Tue, 08 Sep 2020 06:58:37 -0700 (PDT) Received: from [192.168.0.189] ([147.253.86.153]) by smtp.gmail.com with ESMTPSA id m1sm10014629qkn.89.2020.09.08.06.58.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Sep 2020 06:58:36 -0700 (PDT) Subject: Re: [PATCH v2 3/4] soundwire: qcom: add support for mmio soundwire master devices To: Pierre-Louis Bossart , linux-arm-msm@vger.kernel.org Cc: "moderated list:SOUNDWIRE SUBSYSTEM" , open list , Bjorn Andersson , Vinod Koul , Andy Gross , Sanyog Kale , Bard Liao References: <20200905173905.16541-1-jonathan@marek.ca> <20200905173905.16541-4-jonathan@marek.ca> From: Jonathan Marek Message-ID: <4bf165c2-1458-442b-5c85-5cebabda7232@marek.ca> Date: Tue, 8 Sep 2020 09:57:43 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 9/8/20 9:56 AM, Pierre-Louis Bossart wrote: > > > >> @@ -764,8 +786,11 @@ static int qcom_swrm_probe(struct platform_device >> *pdev) >>           if (!ctrl->regmap) >>               return -EINVAL; >>       } else { >> -        /* Only WCD based SoundWire controller is supported */ >> -        return -ENOTSUPP; >> +        ctrl->reg_read = qcom_swrm_cpu_reg_read; >> +        ctrl->reg_write = qcom_swrm_cpu_reg_write; >> +        ctrl->mmio = devm_platform_ioremap_resource(pdev, 0); >> +        if (IS_ERR(ctrl->mmio)) >> +            return PTR_ERR(ctrl->mmio); > > Shouldn't this be conditional on SLIMBUS being enabled, as done in your > patch2? > No, the case above is the SLIMBUS case. This patch is adding support for the non-SLIMBUS case. >>       } >>       ctrl->irq = of_irq_get(dev->of_node, 0); >>