From: Anibal Limon <anibal.limon@linaro.org>
To: linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 5/5] arm64: dts: qcom: msm8916: Enable modem and WiFi
Date: Mon, 22 Mar 2021 15:03:06 -0600 [thread overview]
Message-ID: <4d0c3a46-5657-4e48-f7c7-1b653978b1af@linaro.org> (raw)
In-Reply-To: <YFTA8gEPp1x6o/9f@gerhold.net>
On 3/19/21 9:19 AM, Stephan Gerhold wrote:
> Hi Bjorn,
>
> On Thu, Mar 11, 2021 at 04:33:18PM -0800, Bjorn Andersson wrote:
>> Enable the modem and WiFi subsystems and specify msm8916 specific
>> firmware path for these and the WCNSS control service.
>>
>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> The changes itself look good to me, but the commit message is really
> misleading. It does not mention anywhere that the change actually just
> enables "modem" on apq8016-sbc instead of "msm8916". :)
>
> Also, WCNSS was actually enabled before already (with the default
> firmware path). In my opinion, it would be clearer to change the
> firmware-name for it in an extra patch.
>
>> ---
>> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 12 ++++++++++++
>> arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +-
>> 2 files changed, 13 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
>> index 6aef0c2e4f0a..448e3561ef63 100644
>> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
>> @@ -305,6 +305,12 @@ &mdss {
>> status = "okay";
>> };
>>
>> +&mpss {
>> + status = "okay";
>> +
>> + firmware-name = "qcom/msm8916/mba.mbn", "qcom/msm8916/modem.mbn";
>> +};
>> +
>> &pm8916_resin {
>> status = "okay";
>> linux,code = <KEY_VOLUMEDOWN>;
>> @@ -312,6 +318,8 @@ &pm8916_resin {
>>
>> &pronto {
>> status = "okay";
>> +
>> + firmware-name = "qcom/msm8916/wcnss.mbn";
>> };
>>
>
> How do I get a .mbn from the wcnss.{mdt,.b??} files provided in the
> DB410c firmware package? I guess I should just run them through
> https://github.com/andersson/pil-squasher?
>
> Also, is the single file format (mbn) preferred now? Not sure if there
> is any significant difference except having less files laying around.
Same issue here, where can I get mbn file?,
After change the file to use wcnss.mdt this patch works.
Regards,
Anibal
>
> Thanks,
> Stephan
>
>
next prev parent reply other threads:[~2021-03-22 21:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 0:33 [PATCH 0/5] qcom: wcnss: Allow overriding firmware form DT Bjorn Andersson
2021-03-12 0:33 ` [PATCH 1/5] dt-bindings: soc: qcom: wcnss: Add firmware-name property Bjorn Andersson
2021-03-22 21:00 ` Anibal Limon
2021-03-24 15:21 ` Rob Herring
2021-03-12 0:33 ` [PATCH 2/5] wcn36xx: Allow firmware name to be overridden by DT Bjorn Andersson
2021-03-15 11:58 ` Bryan O'Donoghue
2021-03-22 21:01 ` Anibal Limon
2021-03-12 0:33 ` [PATCH 3/5] soc: qcom: wcnss_ctrl: Introduce local variable "dev" Bjorn Andersson
2021-03-22 21:01 ` Anibal Limon
2021-03-12 0:33 ` [PATCH 4/5] soc: qcom: wcnss_ctrl: Allow reading firmware-name from DT Bjorn Andersson
2021-03-15 11:57 ` Bryan O'Donoghue
2021-03-22 21:02 ` Anibal Limon
2021-03-12 0:33 ` [PATCH 5/5] arm64: dts: qcom: msm8916: Enable modem and WiFi Bjorn Andersson
2021-03-15 11:57 ` Bryan O'Donoghue
2021-03-15 12:01 ` Bryan O'Donoghue
2021-03-18 14:50 ` Bjorn Andersson
2021-03-19 14:41 ` Bryan O'Donoghue
2021-03-19 15:19 ` Stephan Gerhold
2021-03-22 21:03 ` Anibal Limon [this message]
2021-05-31 16:33 ` Bjorn Andersson
2021-03-18 16:48 ` [PATCH 0/5] qcom: wcnss: Allow overriding firmware form DT Vinod Koul
2021-03-18 16:56 ` Jeffrey Hugo
2021-03-18 17:06 ` Bjorn Andersson
2021-03-18 18:12 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d0c3a46-5657-4e48-f7c7-1b653978b1af@linaro.org \
--to=anibal.limon@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).