Re: [PATCH 6/8] dt-bindings: vendor-prefixes: add LG Electronics

From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Luca Weiss <luca@z3ntu.xyz>, linux-arm-msm@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht, bartosz.dudziak@snejp.pl,
	Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Oleksij Rempel <linux@rempel-privat.de>,
	Sam Ravnborg <sam@ravnborg.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Daniel Palmer <daniel@0x0f.com>,
	Max Merchel <Max.Merchel@tq-group.com>,
	Hao Fang <fanghao11@huawei.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] dt-bindings: vendor-prefixes: add LG Electronics
Date: Tue, 14 Sep 2021 09:24:47 +0200	[thread overview]
Message-ID: <4f415ca1-6527-5667-01f2-9676f565d670@canonical.com> (raw)
In-Reply-To: <5220943.AHGTne7y6d@g550jk>

On 13/09/2021 21:14, Luca Weiss wrote:
> Hi Krzysztof,
> 
> On Montag, 13. September 2021 10:49:43 CEST Krzysztof Kozlowski wrote:
>> On 12/09/2021 01:27, Luca Weiss wrote:
>>> LG Electronics is a part of the LG Corporation and produces, amongst
>>> other things, consumer electronics such as phones and smartwatches.
>>
>> Hi,
>>
>> Thanks for the patches.
>>
>> I think "lge" it's the same prefix as "lg". There is no sense in having
>> multiple vendor prefixes just because company splits inside business
>> units or subsidiaries. The same as with other conglomerates, e.g.
>> Samsung - if we wanted to be specific, there will be 4-5 Samsung
>> vendors... Not mentioning that company organisation is not always
>> disclosed and can change.
>>
> 
> I was mostly following qcom-msm8974-lge-nexus5-hammerhead as it's the other LG 
> device tree I am aware of so I've picked lge instead of lg. Also worth noting 
> that Google uses "LGE" in the Android device tree[1] or in the model name in 
> the LG G Watch R kernel sources ("LGE APQ 8026v2 LENOK rev-1.0")

[1] Does not point to kernel tree. Downstream user could be a good
argument to switch to lge, but then I would expect correcting other "lg"
devices which are in fact made by LGE.

> 
> I don't have a strong opinion either way so I'm fine with either.
> 
> If we decide to go with "lg" do we want to change the Nexus 5 devicetree 
> (hammerhead) also, that one has the lge name in at least compatible and 
> filename (I don't know how much of a breaking change that would be considered 
> as).

We would have to add a new one and mark the old compatible as deprecated.

> 
>> We already have lg for several components, also made by LG Electronics.
>> What about these?
>>
>> There is only one device with "lge", added back in 2016 without adding
>> vendor prefix. I would propose to fix that one, instead of keeping
>> duplicated "lg".
>>
>> Best regards,
>> Krzysztof
> 
> Regards
> Luca
> 
> [1] https://android.googlesource.com/device/lge/hammerhead/
> 
> 
> 

Best regards,
Krzysztof