From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D09BC4332F for ; Tue, 7 Dec 2021 15:56:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239301AbhLGQAH (ORCPT ); Tue, 7 Dec 2021 11:00:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239265AbhLGQAH (ORCPT ); Tue, 7 Dec 2021 11:00:07 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBA1EC061746 for ; Tue, 7 Dec 2021 07:56:36 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id o13so30373480wrs.12 for ; Tue, 07 Dec 2021 07:56:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=s04DWXu5NLwyK43+n0H/Fmx6iCKArUlT2QSk1QCIXEA=; b=leLkaw4Wq4nrnYqRR9i+abimOSRyJ+xJHXAVfqjj+KuC25tQnYy5B0vVrQS/qMzUfv Nzx0Yc1/d8FmVVwS6NNwL81AmJmkekro1sv4KyZcFuf5jb+l3iQQ9lQk6kCK1ld3pvr1 dMnxEv9T1vJTd9yaSL8QI8qOi/YqngfClRtusBdrp2eD85vVar9OmInaq8LtUAXrzbqB x2iYS+0r4q9sXr5Owqi3XjZXwMC0tOOYiLSPKJl62VOEL0rpErsrHTYOm5lzHy5tjOL2 jiF7lRj7rSuVlNwYEensr/mIw6DHml4OQsxn7aicDRaCL2JCH/4JMQH4nEdm372RUWHy 1H+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=s04DWXu5NLwyK43+n0H/Fmx6iCKArUlT2QSk1QCIXEA=; b=gx+1Zalb1chR0hqYEQsS4x4XEXKE1SBJr1zoYFFX6lzfVeDQHIlsvl4g+IRbqQdlVn nuSOr9q5S04xqRgeJRAvS38NqO18LFj7OK5ekokqqysTvSgdH/SZGu2KSnYL6HliHjZK fZil/ICmVTCxNjdscgjwu6ozAelU28VtjGPIA946mIjhDCndXOTdbAj6oXsh9qJbuQty MRNykGTL/c4ox/O7PdTw/K8j5z1vCA0xSk1XWAqsCpU8QVBkccCgWXdnn1hhI2rBwa/b 8rkbkS15g/xHgHG3rxML+MQWtennKKFm67nT5GGesnae0/UwRidCq4+6shdxtm83UtJs XZbA== X-Gm-Message-State: AOAM530Q4JIn72qqaPcft5oRi8QKLrfbVRszwwp/Xzs69RusosjS7Xfk RwijFAmIIhfF31PcasxdbyFqnA== X-Google-Smtp-Source: ABdhPJxQBhRnVCXcNj/xSOYLWlR2ziSKQKPnBd1I2FJAjBpy539Q0U8rvPoTbp2fFBr9e85jDnZDXQ== X-Received: by 2002:adf:ed83:: with SMTP id c3mr50812916wro.169.1638892595418; Tue, 07 Dec 2021 07:56:35 -0800 (PST) Received: from [192.168.86.34] (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.googlemail.com with ESMTPSA id j17sm11346wmq.41.2021.12.07.07.56.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Dec 2021 07:56:34 -0800 (PST) Subject: Re: [PATCH] dt-bindings: misc: convert Qualcomm FastRPC bindings to the YAML schema To: David Heidelberg , Andy Gross , Bjorn Andersson , Rob Herring Cc: ~okias/devicetree@lists.sr.ht, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211206193849.109079-1-david@ixit.cz> From: Srinivas Kandagatla Message-ID: <4f631075-85d0-7362-e3d6-b3abaec465e0@linaro.org> Date: Tue, 7 Dec 2021 15:56:33 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211206193849.109079-1-david@ixit.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi David, Thanks for the patch, On 06/12/2021 19:38, David Heidelberg wrote: > Switch the DT binding to a YAML schema to enable the DT validation. > > Also: > - simplify example > - embrace compute-cb@ subnodes instead of just cb@ > > Signed-off-by: David Heidelberg There is already a similar patch [1] in the list. If you have noticed it, Its better to let the author know about your plans so that we do not duplicate the same thing. Your patch seems to have addressed issues with subnode names and example. so am okay with this patch. Acked-by: Srinivas Kandagatla FastRPC patches normally go via char-misc tree, so if Rob acks can you send it to Greg as well. --srini > --- > .../devicetree/bindings/misc/qcom,fastrpc.txt | 78 --------------- > .../bindings/misc/qcom,fastrpc.yaml | 94 +++++++++++++++++++ > 2 files changed, 94 insertions(+), 78 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/misc/qcom,fastrpc.txt > create mode 100644 Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml > > diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt b/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt > deleted file mode 100644 > index 2a1827ab50d2..000000000000 > --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt > +++ /dev/null > @@ -1,78 +0,0 @@ > -Qualcomm Technologies, Inc. FastRPC Driver > - > -The FastRPC implements an IPC (Inter-Processor Communication) > -mechanism that allows for clients to transparently make remote method > -invocations across DSP and APPS boundaries. This enables developers > -to offload tasks to the DSP and free up the application processor for > -other tasks. > - > -- compatible: > - Usage: required > - Value type: > - Definition: must be "qcom,fastrpc" > - > -- label > - Usage: required > - Value type: > - Definition: should specify the dsp domain name this fastrpc > - corresponds to. must be one of this: "adsp", "mdsp", "sdsp", "cdsp" > - > -- #address-cells > - Usage: required > - Value type: > - Definition: Must be 1 > - > -- #size-cells > - Usage: required > - Value type: > - Definition: Must be 0 > - > -= COMPUTE BANKS > -Each subnode of the Fastrpc represents compute context banks available > -on the dsp. > -- All Compute context banks MUST contain the following properties: > - > -- compatible: > - Usage: required > - Value type: > - Definition: must be "qcom,fastrpc-compute-cb" > - > -- reg > - Usage: required > - Value type: > - Definition: Context Bank ID. > - > -- qcom,nsessions: > - Usage: Optional > - Value type: > - Defination: A value indicating how many sessions can share this > - context bank. Defaults to 1 when this property > - is not specified. > - > -Example: > - > -adsp-pil { > - compatible = "qcom,msm8996-adsp-pil"; > - ... > - smd-edge { > - label = "lpass"; > - fastrpc { > - compatible = "qcom,fastrpc"; > - qcom,smd-channels = "fastrpcsmd-apps-dsp"; > - label = "adsp"; > - #address-cells = <1>; > - #size-cells = <0>; > - > - cb@1 { > - compatible = "qcom,fastrpc-compute-cb"; > - reg = <1>; > - }; > - > - cb@2 { > - compatible = "qcom,fastrpc-compute-cb"; > - reg = <2>; > - }; > - ... > - }; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml > new file mode 100644 > index 000000000000..f42ab208a7fc > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml > @@ -0,0 +1,94 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/misc/qcom,fastrpc.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm FastRPC Driver > + > +maintainers: > + - Srinivas Kandagatla > + > +description: | > + The FastRPC implements an IPC (Inter-Processor Communication) > + mechanism that allows for clients to transparently make remote method > + invocations across DSP and APPS boundaries. This enables developers > + to offload tasks to the DSP and free up the application processor for > + other tasks. > + > +properties: > + compatible: > + items: > + - const: qcom,fastrpc > + > + label: > + items: > + enum: > + - adsp > + - mdsp > + - sdsp > + - cdsp > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > +patternProperties: > + "(compute-)?cb@[0-9]$": > + type: object > + > + description: > > + Each subnode of the Fastrpc represents compute context banks available on the dsp. > + > + properties: > + compatible: > + items: > + - const: qcom,fastrpc-compute-cb > + > + reg: > + maxItems: 1 > + > + qcom,nsession: > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 1 > + description: > > + A value indicating how many sessions can share this context bank. > + > + required: > + - compatible > + - reg > + > + additionalProperties: true > + > +required: > + - compatible > + - label > + - '#address-cells' > + - '#size-cells' > + > +additionalProperties: true > + > +examples: > + - | > + smd-edge { > + label = "lpass"; > + fastrpc { > + compatible = "qcom,fastrpc"; > + label = "adsp"; > + qcom,smd-channels = "fastrpcsmd-apps-dsp"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + compute-cb@1 { > + compatible = "qcom,fastrpc-compute-cb"; > + reg = <1>; > + }; > + > + compute-cb@2 { > + compatible = "qcom,fastrpc-compute-cb"; > + reg = <2>; > + }; > + }; > + }; > [1] https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20211130092846.18804-1-srinivas.kandagatla@linaro.org/