From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5F70C07E95 for ; Wed, 7 Jul 2021 09:47:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9BDE6198A for ; Wed, 7 Jul 2021 09:47:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231252AbhGGJug (ORCPT ); Wed, 7 Jul 2021 05:50:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231195AbhGGJug (ORCPT ); Wed, 7 Jul 2021 05:50:36 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6515AC06175F for ; Wed, 7 Jul 2021 02:47:56 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id l1so1401927wme.4 for ; Wed, 07 Jul 2021 02:47:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Dm2rBXOWQDYbyq7hq3px23+lQhiHxAKM1oygtO8cTVM=; b=S5978gsp1zz5G1304knfRBzraXCAg7QVZwfWiw8VImnRLUFqcI3BeIvhEPsGAIX2Zg /o1PLYpQGDxUthu2FEs5NQuXLqq/q1ZXjBaX1iL2GoZzLOu6mQw6iEoVMJ85z7WTT8/W aQk/VpJCAV/WCt06QMXSxlqoo64ox21IMCPbkNcCe2bAD1hVM0D1GEWgUpVqwnl0sUIc XtqDdoZutmIzPBGwahYWioCgfQr3VAE22PKtJ2hhGFzPloI1OI1kfBRA6ScvkIblKIgK KZnUurvuO85tWcxzYFp74OxStJ+DudDfrO9R8skvqb6CIXB27cF81qlPXFoEAlqZ5QUN JABw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Dm2rBXOWQDYbyq7hq3px23+lQhiHxAKM1oygtO8cTVM=; b=R1PyLhjgg2GQAAvIUMYkjdoOyXYjCDszBQ/EpTqO9DUmUkCS3toq0lMUY/ZYONn87X wJAo6I7iAerFA/eZrm1W/CelGNl2trIZtkqQrxOCukRrwlFhotb5GS/6lFb0xIxolK0G xzIciBtD53GbjQKDruoT3Wtj6uhrMPw+c5n9AErU1h5I9i1xX8fqhHGzEGBux4XyGK67 HZhc85Vz3dJLHuw3gqBgiUM966U+wfsNbuG3pbpA4DfwGSqooL+yr2lJrXFcS4euCsCW ws5EuKXBDxPRGByshtedELZt4vDEBeCPQ6YUFXDAcw9x/93tYOJgTczrriU2AypalmH3 0xOA== X-Gm-Message-State: AOAM530EffUKkVLNtqKDJ63+fLjuKkVobO+tGDhFyxZAVyrR+Q5nb92d 1G6akmSx/q3wJJcnodpJlfJlX1HpyMMLtg== X-Google-Smtp-Source: ABdhPJxIy1zv1VqCVrkP1G6sHNsRESEieiJSMFLIb4KpC98Ngg9XW1tSJcU0PUj+n5PtysZdHBU7hA== X-Received: by 2002:a05:600c:48aa:: with SMTP id j42mr25648022wmp.93.1625651274701; Wed, 07 Jul 2021 02:47:54 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id x17sm24330582wrn.62.2021.07.07.02.47.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jul 2021 02:47:53 -0700 (PDT) Subject: Re: [PATCH 2/3] usb: dwc3: Add role switch relay support To: Bjorn Andersson Cc: balbi@kernel.org, agross@kernel.org, gregkh@linuxfoundation.org, jackp@codeaurora.org, wcheng@codeaurora.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20210704013314.200951-1-bryan.odonoghue@linaro.org> <20210704013314.200951-3-bryan.odonoghue@linaro.org> From: Bryan O'Donoghue Message-ID: <51a11204-cd59-e18f-7dc3-f78632e77bde@linaro.org> Date: Wed, 7 Jul 2021 10:49:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 07/07/2021 06:14, Bjorn Andersson wrote: > So you're going to rely on DT to create a role-switch link between the > dwc3 core driver and the qcom wrapper? > > As I said the other day, this is just a hack to get around the fact that > of_platform_populate() may return before the dwc3 core has probed. A beautiful hack though > Another such case can be seen in [1], where Wesley is patching the DT > node in runtime in order to pass a boolean parameter between the two > driver parts. > > If we fix that we don't need these kinds of workarounds. OK, I understand/agree Lets look at changing the way dwc3-qcom launches dwc3-core and make it that 1. Probe deferral in dwc3-core either defers the dwc3-qcom code 2. Or that the dwc3-qcom code waits for dwc3-core either way instead of avoiding the fact that dwc3-core can defer we should make it that dwc3-qcom::probe() exits only when the dwc3-core is done --- bod