From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH v5 08/11] nvmem: qfprom: Add Qualcomm QFPROM support. Date: Thu, 18 Jun 2015 14:22:27 +0100 Message-ID: <5582C613.2090201@linaro.org> References: <1432226535-8640-1-git-send-email-srinivas.kandagatla@linaro.org> <1432226675-9039-1-git-send-email-srinivas.kandagatla@linaro.org> <5580AA9B.7040001@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5580AA9B.7040001-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Boyd , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Maxime Ripard , Rob Herring , Kumar Gala , Mark Brown , s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Greg Kroah-Hartman , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org, mporter-OWPKS81ov/FWk0Htik3J/w@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org On 17/06/15 00:00, Stephen Boyd wrote: > On 05/21/2015 09:44 AM, Srinivas Kandagatla wrote: >> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig >> index f157b6d..e665e23 100644 >> --- a/drivers/nvmem/Kconfig >> +++ b/drivers/nvmem/Kconfig >> @@ -8,3 +8,18 @@ menuconfig NVMEM >> from both the Linux Kernel and the userspace. >> >> If unsure, say no. >> + >> +if NVMEM >> + >> +config QCOM_QFPROM >> + tristate "QCOM QFPROM Support" >> + depends on ARCH_QCOM > > || COMPILE_TEST? > Yes, makes sense. I will add it. >> + select REGMAP_MMIO >> + help >> + Say y here to enable QFPROM support. The QFPROM provides access >> + functions for QFPROM data to rest of the drivers via nvmem interface. >> + >> + This driver can also be built as a module. If so, the module >> + will be called nvmem-qfprom. >> + >> +endif >> diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile >> index f694cfc..caea611 100644 >> --- a/drivers/nvmem/Makefile >> +++ b/drivers/nvmem/Makefile >> @@ -5,3 +5,7 @@ >> obj-$(CONFIG_NVMEM) += nvmem_core.o >> nvmem_core-y := core.o >> nvmem_core-y += nvmem-mmio.o >> + >> +# Devices >> +obj-$(CONFIG_QCOM_QFPROM) += nvmem_qfprom.o >> +nvmem_qfprom-y := qfprom.o > > Why not just > > obj-$(CONFIG_QCOM_QFPROM) += nvmem_qfprom.o > > ? I will recheck on this. > >> diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c >> new file mode 100644 >> index 0000000..5ea84bb >> --- /dev/null >> +++ b/drivers/nvmem/qfprom.c >> @@ -0,0 +1,51 @@ >> +/* >> + * Copyright (C) 2015 Srinivas Kandagatla >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 and >> + * only version 2 as published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ >> + >> +#include >> +#include >> +#include "nvmem-mmio.h" >> + >> +static struct regmap_config qfprom_regmap_config = { > > const? Will fix all the comments. > >> + .reg_bits = 32, >> + .val_bits = 8, >> + .reg_stride = 1, >> +}; >> + >> +static struct nvmem_config econfig = { > > const? > >> + .name = "qfprom", >> + .owner = THIS_MODULE, >> +}; >> + >> +static struct nvmem_mmio_data qfprom_data = { > > const? > >> + .nvmem_config = &econfig, >> + .regmap_config = &qfprom_regmap_config, >> +}; >> >