From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Subject: Re: [PATCH V2 1/6] SLIMbus: Device management on SLIMbus Date: Fri, 19 Jun 2015 09:22:08 +0100 Message-ID: <5583D130.5080207@linaro.org> References: <1434505564-14333-1-git-send-email-sdharia@codeaurora.org> <1434505564-14333-2-git-send-email-sdharia@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f46.google.com ([74.125.82.46]:35739 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753177AbbFSIWL (ORCPT ); Fri, 19 Jun 2015 04:22:11 -0400 Received: by wgbhy7 with SMTP id hy7so83277952wgb.2 for ; Fri, 19 Jun 2015 01:22:10 -0700 (PDT) In-Reply-To: <1434505564-14333-2-git-send-email-sdharia@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Sagar Dharia , gregkh@linuxfoundation.org, bp@suse.de, poeschel@lemonage.de, treding@nvidia.com, broonie@kernel.org, gong.chen@linux.intel.com, andreas.noever@gmail.com, alan@linux.intel.com, mathieu.poirier@linaro.org, daniel@ffwll.ch, oded.gabbay@amd.com, jkosina@suse.cz, sharon.dvir1@mail.huji.ac.il, joe@perches.com, davem@davemloft.net, james.hogan@imgtec.com, michael.opdenacker@free-electrons.com, linux-kernel@vger.kernel.org Cc: nkaje@codeaurora.org, kheitke@audience.com, mlocke@codeaurora.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org On 17/06/15 02:45, Sagar Dharia wrote: > --- /dev/null > +++ b/drivers/slimbus/Kconfig > @@ -0,0 +1,9 @@ > +# > +# SLIMBUS driver configuration > +# > +menuconfig SLIMBUS > + tristate "Slimbus support" > + help > + Slimbus is standard interface between baseband and audio codec, > + and other peripheral components in mobile terminals. Perhaps this is a fussy comment but this description of slimbus makes pretty heavy use of mobile phone jargon. Admittedly it is jargon from the slimbus spec which, as standards go, seems rather myopic about its potential user base. However, even the standards own self-description doesn't limit its role to baseband <-> peripherals. What happened to the application processor/main-SoC? Also would an "If unsure, choose N." be useful? It could be quite a long time before someone who doesn't know they need slimbus actually finds that they do. Daniel.