* [PATCH -next] thermal: qcom: return error code on error path in adc_tm5_get_dt_channel_data()
@ 2021-05-22 5:15 Yang Yingliang
2021-05-27 9:13 ` Daniel Lezcano
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2021-05-22 5:15 UTC (permalink / raw)
To: linux-kernel, linux-pm, linux-arm-msm; +Cc: daniel.lezcano, colin.king
Return -EINVAL when args is invalid.
Fixes: ca66dca5eda6 ("thermal: qcom: add support for adc-tm5 PMIC thermal monitor")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
index b460b56e981c..8ccd5d22c13b 100644
--- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
+++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
@@ -441,7 +441,7 @@ static int adc_tm5_get_dt_channel_data(struct adc_tm5_chip *adc_tm,
if (args.args_count != 1 || args.args[0] >= ADC5_MAX_CHANNEL) {
dev_err(dev, "%s: invalid ADC channel number %d\n", name, chan);
- return ret;
+ return -EINVAL;;
}
channel->adc_channel = args.args[0];
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] thermal: qcom: return error code on error path in adc_tm5_get_dt_channel_data()
2021-05-22 5:15 [PATCH -next] thermal: qcom: return error code on error path in adc_tm5_get_dt_channel_data() Yang Yingliang
@ 2021-05-27 9:13 ` Daniel Lezcano
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Lezcano @ 2021-05-27 9:13 UTC (permalink / raw)
To: Yang Yingliang, linux-kernel, linux-pm, linux-arm-msm; +Cc: colin.king
On 22/05/2021 07:15, Yang Yingliang wrote:
> Return -EINVAL when args is invalid.
>
> Fixes: ca66dca5eda6 ("thermal: qcom: add support for adc-tm5 PMIC thermal monitor")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> index b460b56e981c..8ccd5d22c13b 100644
> --- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> +++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> @@ -441,7 +441,7 @@ static int adc_tm5_get_dt_channel_data(struct adc_tm5_chip *adc_tm,
>
> if (args.args_count != 1 || args.args[0] >= ADC5_MAX_CHANNEL) {
> dev_err(dev, "%s: invalid ADC channel number %d\n", name, chan);
> - return ret;
> + return -EINVAL;;
semicolon x 2
> }
> channel->adc_channel = args.args[0];
>
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-27 9:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-22 5:15 [PATCH -next] thermal: qcom: return error code on error path in adc_tm5_get_dt_channel_data() Yang Yingliang
2021-05-27 9:13 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).