From: Timur Tabi <timur@codeaurora.org>
To: Rob Herring <robh@kernel.org>, Gilad Avidov <gavidov@codeaurora.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
sdharia@codeaurora.org, shankerd@codeaurora.org,
gregkh@linuxfoundation.org, vikrams@codeaurora.org,
cov@codeaurora.org
Subject: Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver
Date: Fri, 29 Jan 2016 12:22:34 -0600 [thread overview]
Message-ID: <56ABADEA.40801@codeaurora.org> (raw)
In-Reply-To: <20151231231039.GA8886@rob-hp-laptop>
Gilad is no longer working for Qualcomm, so I'm taking over (as best as
I can) this driver. Let's just say it's going to be a learning experience.
Rob Herring wrote:
>> diff --git a/Documentation/devicetree/bindings/net/qcom-emac.txt b/Documentation/devicetree/bindings/net/qcom-emac.txt
>> new file mode 100644
>> index 0000000..8d58a40
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/qcom-emac.txt
>> @@ -0,0 +1,68 @@
>> +Qualcomm EMAC Gigabit Ethernet Controller
>> +
>> +Required properties:
>> +- cell-index : EMAC controller instance number.
>> +- compatible : Should be "qcom,emac".
>
> This should be more specific with the SOC name.
The emac is present on a lot of Qualcomm SOCs, and there are only a few
variations of it. It's not really SOC-specific, and the hardware
version can be queried by the driver.
What did you have in mind? I don't know even have a list of which SOCs
has an emac, especially since it's mostly on MSM parts, and I work on
the server SOC.
>> +- reg : Offset and length of the register regions for the device
>> +- reg-names : Register region names referenced in 'reg' above.
>> + Required register resource entries are:
>> + "base" : EMAC controller base register block.
>> + "csr" : EMAC wrapper register block.
>> + Optional register resource entries are:
>> + "ptp" : EMAC PTP (1588) register block.
>> + Required if 'qcom,emac-tstamp-en' is present.
>> + "sgmii" : EMAC SGMII PHY register block.
>> +- interrupts : Interrupt numbers used by this controller
>> +- interrupt-names : Interrupt resource names referenced in 'interrupts' above.
>> + Required interrupt resource entries are:
>> + "emac_core0" : EMAC core0 interrupt.
>> + "sgmii_irq" : EMAC SGMII interrupt.
>> +- qcom,emac-gpio-mdc : GPIO pin number of the MDC line of MDIO bus.
>> +- qcom,emac-gpio-mdio : GPIO pin number of the MDIO line of MDIO bus.
>
> Use the standard binding for GPIO controlled MDIO bus.
I'm not familiar with that one. Are you talking about
bindings/net/mdio-gpio.txt?
>> +- phy-addr : Specifies phy address on MDIO bus.
>> + Required if the optional property "qcom,no-external-phy"
>> + is not specified.
>
> Don't you think you will need to know the specific phy device or other
> properties of the phy?
That, I can't answer. Aren't all MDIO devices basically the same? It's
been a while since I've worked on them.
>> +Optional properties:
>> +- qcom,emac-tstamp-en : Enables the PTP (1588) timestamping feature.
>> + Include this only if PTP (1588) timestamping
>> + feature is needed. If included, "ptp" register
>> + base should be specified.
>
> Isn't this a user enabled feature if the h/w supports it?
Is there a sysfs entry for that? We were planning on having a similar
ACPI property.
next prev parent reply other threads:[~2016-01-29 18:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-30 1:48 [PATCH V3] net: emac: emac gigabit ethernet controller driver Gilad Avidov
2015-12-30 2:31 ` kbuild test robot
[not found] ` <1451440135-25771-1-git-send-email-gavidov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-12-30 4:26 ` kbuild test robot
2015-12-31 23:10 ` Rob Herring
2016-01-29 18:22 ` Timur Tabi [this message]
[not found] ` <56ABADEA.40801-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-01-29 20:10 ` Rob Herring
2016-01-29 20:38 ` Timur Tabi
2016-01-30 21:58 ` Rob Herring
2016-04-07 19:28 ` Timur Tabi
[not found] ` <5706B4EF.2050600-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-07 20:10 ` Andrew Lunn
[not found] ` <20160407201009.GA16136-g2DYL2Zd6BY@public.gmane.org>
2016-04-07 21:43 ` Timur Tabi
2016-04-08 0:53 ` Andrew Lunn
2016-04-08 19:06 ` Timur Tabi
2016-04-08 21:07 ` Vikram Sethi
[not found] ` <57081D96.902-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-08 21:45 ` Timur Tabi
[not found] ` <5708013F.90207-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-08 22:43 ` Bjorn Andersson
2016-04-08 23:01 ` Timur Tabi
2016-04-08 23:25 ` Bjorn Andersson
2016-01-06 0:21 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56ABADEA.40801@codeaurora.org \
--to=timur@codeaurora.org \
--cc=cov@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=gavidov@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sdharia@codeaurora.org \
--cc=shankerd@codeaurora.org \
--cc=vikrams@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).