From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Andy Gross <andy.gross@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jmaggard10@gmail.com
Subject: Re: [RFC PATCH 1/3] libahci: save port map for forced port map
Date: Thu, 31 Mar 2016 16:58:27 +0100 [thread overview]
Message-ID: <56FD4923.3090209@linaro.org> (raw)
In-Reply-To: <20160330185706.GQ7822@mtj.duckdns.org>
On 30/03/16 19:57, Tejun Heo wrote:
> Hello,
>
> On Tue, Mar 29, 2016 at 02:11:13PM +0100, Srinivas Kandagatla wrote:
>> In usecases where force_port_map is used saved_port_map is never set,
>> resulting in not programming the PORTS_IMPL register as part of intial
>> config. This patch fixes this by setting it to port_map even in case
>> where force_port_map is used, making it more inline with other parts of
>> the code.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> drivers/ata/libahci.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
>> index 3982054..a5d7c1c 100644
>> --- a/drivers/ata/libahci.c
>> +++ b/drivers/ata/libahci.c
>> @@ -507,6 +507,7 @@ void ahci_save_initial_config(struct device *dev, struct ahci_host_priv *hpriv)
>> dev_info(dev, "forcing port_map 0x%x -> 0x%x\n",
>> port_map, hpriv->force_port_map);
>> port_map = hpriv->force_port_map;
>> + hpriv->saved_port_map = port_map;
>
> So, the only change it'd cause is making the driver write the forced
> value to the PI register. Does that make sense?
Yes, that is the intention, I guess, This was done exactly in case where
the port number was fabricated too.
Without this I could not get the sata working on my board with forced
port map option.
--srini
>
> Thanks.
>
next prev parent reply other threads:[~2016-03-31 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 13:11 [RFC PATCH 0/3] ahci: add ports-implemented dt bindings Srinivas Kandagatla
2016-03-29 13:11 ` [RFC PATCH 1/3] libahci: save port map for forced port map Srinivas Kandagatla
2016-03-30 18:57 ` Tejun Heo
2016-03-31 15:58 ` Srinivas Kandagatla [this message]
2016-03-31 16:43 ` Tejun Heo
2016-03-31 16:51 ` Srinivas Kandagatla
2016-03-29 13:11 ` [RFC PATCH 2/3] ata: ahci-platform: Add ports-implemented dt bindings Srinivas Kandagatla
2016-03-29 14:11 ` Rob Herring
2016-03-29 14:43 ` Srinivas Kandagatla
2016-03-29 17:07 ` Rob Herring
2016-03-29 17:10 ` Srinivas Kandagatla
2016-03-29 13:11 ` [RFC PATCH 3/3] ARM: dts: apq8064: add ahci ports-implemented mask Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD4923.3090209@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=andy.gross@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=jmaggard10@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).