linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: schowdhu@codeaurora.org
To: Joe Perches <joe@perches.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org,
	Bryan O'Donoghue <pure.logic@nexus-software.ie>,
	Greg KH <greg@kroah.com>,
	linux-kernel@vger.kernel.org, ckadabi@codeaurora.org,
	tsoni@codeaurora.org, bryanh@codeaurora.org,
	psodagud@codeaurora.org, satyap@codeaurora.org,
	pheragu@codeaurora.org, Rajendra Nayak <rnayak@codeaurora.org>,
	Sibi Sankar <sibis@codeaurora.org>,
	Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Subject: Re: [PATCH V0 4/7] usb: common: eud: Added the driver support for Embedded USB Debugger(EUD)
Date: Tue, 05 Oct 2021 19:28:30 +0530	[thread overview]
Message-ID: <576a1eac007ac512ba47d5d3f761ec9a@codeaurora.org> (raw)
In-Reply-To: <c56e78bc85cbe6b05dd16c750e596ab331c37dee.camel@perches.com>

On 2021-10-05 12:44, Joe Perches wrote:
> On Mon, 2021-10-04 at 09:42 -0700, Bjorn Andersson wrote:
>> On Mon 04 Oct 04:16 PDT 2021, Souradeep Chowdhury wrote:
>> 
>> > Add support for control peripheral of EUD (Embedded USB Debugger) to
>> > listen to events such as USB attach/detach, pet EUD to indicate software
>> > is functional.Reusing the platform device kobj, sysfs entry 'enable' is
>> > created to enable or disable EUD.
> []
>> > diff --git a/drivers/usb/common/qcom_eud.c b/drivers/usb/common/qcom_eud.c
> []
>> > +static ssize_t enable_show(struct device *dev,
>> > +		struct device_attribute *attr, char *buf)
>> > +{
>> > +	struct eud_chip *chip = dev_get_drvdata(dev);
>> > +
>> > +	return sprintf(buf, "%d", chip->enable);
> 
> trivia:
> 
> should probably use sysfs_emit and have a trailing '\n' in the format.

Ack

  reply	other threads:[~2021-10-05 14:00 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04 11:16 [PATCH V0 0/7] Add Embedded USB Debugger (EUD) driver Souradeep Chowdhury
2021-10-04 11:16 ` [PATCH V0 1/7] dt-bindings: connector: Add property for eud type c connector Souradeep Chowdhury
2021-10-04 16:37   ` Rob Herring
2021-10-05 13:11     ` schowdhu
2021-10-05 16:37       ` Bjorn Andersson
2021-10-07  9:25         ` schowdhu
2021-10-12  3:22           ` Bjorn Andersson
2021-11-02  9:20             ` schowdhu
2021-10-04 11:16 ` [PATCH V0 2/7] dt-bindings: usb: dwc3: Update dwc3 properties for EUD connector Souradeep Chowdhury
2021-10-04 15:50   ` Bjorn Andersson
2021-10-05 12:57     ` schowdhu
2021-10-04 11:16 ` [PATCH V0 3/7] usb: dwc3: drd: Register the eud connector child node for dwc3 Souradeep Chowdhury
2021-10-05  4:42   ` kernel test robot
2021-10-05 12:32   ` kernel test robot
2021-10-04 11:16 ` [PATCH V0 4/7] usb: common: eud: Added the driver support for Embedded USB Debugger(EUD) Souradeep Chowdhury
2021-10-04 11:31   ` Greg KH
2021-10-05 12:54     ` schowdhu
2021-10-04 16:42   ` Bjorn Andersson
2021-10-05  7:14     ` Joe Perches
2021-10-05 13:58       ` schowdhu [this message]
2021-10-05 13:01     ` schowdhu
2021-10-04 20:08   ` Randy Dunlap
2021-10-05 13:57     ` schowdhu
2021-10-04 11:16 ` [PATCH V0 5/7] arm64: dts: qcom: sc7280: Add EUD connector node Souradeep Chowdhury
2021-10-04 11:16 ` [PATCH V0 6/7] arm64: dts: qcom: sc7280: Set the default dr_mode for usb2 Souradeep Chowdhury
2021-10-04 11:16 ` [PATCH V0 7/7] MAINTAINERS: Add maintainer entry for EUD Souradeep Chowdhury

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576a1eac007ac512ba47d5d3f761ec9a@codeaurora.org \
    --to=schowdhu@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=bryanh@codeaurora.org \
    --cc=ckadabi@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=greg@kroah.com \
    --cc=joe@perches.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pheragu@codeaurora.org \
    --cc=psodagud@codeaurora.org \
    --cc=pure.logic@nexus-software.ie \
    --cc=rnayak@codeaurora.org \
    --cc=saiprakash.ranjan@codeaurora.org \
    --cc=satyap@codeaurora.org \
    --cc=sibis@codeaurora.org \
    --cc=tsoni@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).