From: bbhatt@codeaurora.org
To: Loic Poulain <loic.poulain@linaro.org>, clew@codeaurora.org
Cc: manivannan.sadhasivam@linaro.org, hemantk@codeaurora.org,
linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org
Subject: Re: [PATCH] bus: mhi: Remove auto-start option
Date: Fri, 18 Sep 2020 19:38:46 -0700 [thread overview]
Message-ID: <5baa5f331edb9feb5314b2d6e32b25e0@codeaurora.org> (raw)
In-Reply-To: <1600424219-6674-1-git-send-email-loic.poulain@linaro.org>
On 2020-09-18 03:16, Loic Poulain wrote:
> There is really no point having an auto-start for channels.
> This is confusing for the device drivers, some have to enable the
> channels, others don't have... and waste resources (e.g. pre allocated
> buffers) that may never be used.
>
> This is really up to the MHI device(channel) driver to manage the state
> of its channels.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> ---
> drivers/bus/mhi/core/init.c | 9 ---------
> drivers/bus/mhi/core/internal.h | 1 -
> include/linux/mhi.h | 2 --
> net/qrtr/mhi.c | 5 +++++
> 4 files changed, 5 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index ac19067..7aef6b7 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -727,7 +727,6 @@ static int parse_ch_cfg(struct mhi_controller
> *mhi_cntrl,
> mhi_chan->offload_ch = ch_cfg->offload_channel;
> mhi_chan->db_cfg.reset_req = ch_cfg->doorbell_mode_switch;
> mhi_chan->pre_alloc = ch_cfg->auto_queue;
> - mhi_chan->auto_start = ch_cfg->auto_start;
>
> /*
> * If MHI host allocates buffers, then the channel direction
> @@ -1125,11 +1124,6 @@ static int mhi_driver_probe(struct device *dev)
> goto exit_probe;
>
> ul_chan->xfer_cb = mhi_drv->ul_xfer_cb;
> - if (ul_chan->auto_start) {
> - ret = mhi_prepare_channel(mhi_cntrl, ul_chan);
> - if (ret)
> - goto exit_probe;
> - }
> }
>
> ret = -EINVAL;
> @@ -1163,9 +1157,6 @@ static int mhi_driver_probe(struct device *dev)
> if (ret)
> goto exit_probe;
>
> - if (dl_chan && dl_chan->auto_start)
> - mhi_prepare_channel(mhi_cntrl, dl_chan);
> -
> mhi_device_put(mhi_dev);
>
> return ret;
> diff --git a/drivers/bus/mhi/core/internal.h
> b/drivers/bus/mhi/core/internal.h
> index 5a81a42..73b52a0 100644
> --- a/drivers/bus/mhi/core/internal.h
> +++ b/drivers/bus/mhi/core/internal.h
> @@ -563,7 +563,6 @@ struct mhi_chan {
> bool configured;
> bool offload_ch;
> bool pre_alloc;
> - bool auto_start;
> bool wake_capable;
> };
>
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 008b8f6..742dabe 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -214,7 +214,6 @@ enum mhi_db_brst_mode {
> * @offload_channel: The client manages the channel completely
> * @doorbell_mode_switch: Channel switches to doorbell mode on M0
> transition
> * @auto_queue: Framework will automatically queue buffers for DL
> traffic
> - * @auto_start: Automatically start (open) this channel
> * @wake-capable: Channel capable of waking up the system
> */
> struct mhi_channel_config {
> @@ -232,7 +231,6 @@ struct mhi_channel_config {
> bool offload_channel;
> bool doorbell_mode_switch;
> bool auto_queue;
> - bool auto_start;
> bool wake_capable;
> };
>
> diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c
> index ff0c414..7100f0b 100644
> --- a/net/qrtr/mhi.c
> +++ b/net/qrtr/mhi.c
> @@ -76,6 +76,11 @@ static int qcom_mhi_qrtr_probe(struct mhi_device
> *mhi_dev,
> struct qrtr_mhi_dev *qdev;
> int rc;
>
> + /* start channels */
> + rc = mhi_prepare_for_transfer(mhi_dev);
> + if (rc)
> + return rc;
> +
> qdev = devm_kzalloc(&mhi_dev->dev, sizeof(*qdev), GFP_KERNEL);
> if (!qdev)
> return -ENOMEM;
Hi Loic,
Thank you for your patch. Hemant and I discussed and we are OK with this
patch.
Adding Chris to ensure that QRTR changes are acceptable.
Thanks,
Bhaumik
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation Collaborative Project'
next prev parent reply other threads:[~2020-09-19 2:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 10:16 [PATCH] bus: mhi: Remove auto-start option Loic Poulain
2020-09-19 2:38 ` bbhatt [this message]
2020-09-19 11:27 ` Manivannan Sadhasivam
2020-09-21 7:07 ` Loic Poulain
2020-11-18 5:31 Manivannan Sadhasivam
2020-11-18 5:43 ` Kalle Valo
2020-11-18 9:31 ` Manivannan Sadhasivam
2020-11-18 11:55 ` Carl Huang
2020-11-18 11:57 ` Manivannan Sadhasivam
2020-11-18 17:46 ` Bhaumik Bhatt
2020-11-24 15:45 ` Kalle Valo
2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5baa5f331edb9feb5314b2d6e32b25e0@codeaurora.org \
--to=bbhatt@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).