From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04E10C433DB for ; Sat, 27 Feb 2021 13:56:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEBDA64D79 for ; Sat, 27 Feb 2021 13:56:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230178AbhB0N42 (ORCPT ); Sat, 27 Feb 2021 08:56:28 -0500 Received: from m42-2.mailgun.net ([69.72.42.2]:46752 "EHLO m42-2.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230165AbhB0N4Z (ORCPT ); Sat, 27 Feb 2021 08:56:25 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1614434164; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=EmDgNHN3ZYfCjkpOGYl55fojHvz/cYCq0lJ8kPRF08k=; b=HioMYjLojwVCav/V0lTCuXppOOvcR01ZGAVL9lmuMElFY+I4NOAUPpNtYm9xd6JPsj3Akzjb gDcWZzQSadPZo2KdgxYoPOSh1JorHDrAlKut6w10G3hONzI8ok3bfuF4D2s9sC+vZ9qAHQxx n6Vkm4GksaOpQ5Yp30yZqPtR+6Q= X-Mailgun-Sending-Ip: 69.72.42.2 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 603a4f7416ba74520197a6d8 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 27 Feb 2021 13:56:04 GMT Sender: saiprakash.ranjan=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 7D0C2C433C6; Sat, 27 Feb 2021 13:56:03 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id B82DEC433CA; Sat, 27 Feb 2021 13:56:02 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 27 Feb 2021 19:26:02 +0530 From: Sai Prakash Ranjan To: Stephen Boyd Cc: devicetree@vger.kernel.org, Rajendra Nayak , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Andy Gross , Sibi Sankar , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 8/9] arm64: dts: qcom: sc7280: Add AOSS QMP node In-Reply-To: <161436520297.1254594.4348845199981053890@swboyd.mtv.corp.google.com> References: <463a45f2c3e4a91430c006fa1637c7f4f124185e.1614244789.git.saiprakash.ranjan@codeaurora.org> <161428210272.1254594.16034240343090747878@swboyd.mtv.corp.google.com> <161436520297.1254594.4348845199981053890@swboyd.mtv.corp.google.com> Message-ID: <5cf5692ef7d348ec361081d0341f1254@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-02-27 00:16, Stephen Boyd wrote: > Quoting Sai Prakash Ranjan (2021-02-25 23:51:00) >> On 2021-02-26 01:11, Stephen Boyd wrote: >> > Quoting Sai Prakash Ranjan (2021-02-25 01:30:24) >> >> Add a DT node for the AOSS QMP on SC7280 SoC. >> >> >> >> Signed-off-by: Sai Prakash Ranjan >> >> --- >> >> arch/arm64/boot/dts/qcom/sc7280.dtsi | 14 ++++++++++++++ >> >> 1 file changed, 14 insertions(+) >> >> >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> >> b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> >> index 65c1e0f2fb56..cbd567ccc04e 100644 >> >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> >> @@ -9,6 +9,7 @@ >> >> #include >> >> #include >> >> #include >> >> +#include >> >> #include >> >> >> >> / { >> >> @@ -368,6 +369,19 @@ pdc: interrupt-controller@b220000 { >> >> interrupt-controller; >> >> }; >> >> >> >> + aoss_qmp: qmp@c300000 { >> > >> > power-domain-controller@c300000? power-controller@c300000? >> > >> >> Its an AOSS message RAM and all other SM* SoCs have as qmp@ >> and the dt binding as well, I see only SM8150 with power-controller, >> that should probably be fixed? > > Node name should be generic while still being meaningful. Nobody knows > what qmp is, but power-controller makes sense. Can you fix this and the > others to be power-controller? > Ok makes sense, I will post changing others as well and see if we get any comments there. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation