From: Stephen Boyd <email@example.com> To: Lina Iyer <firstname.lastname@example.org> Cc: email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH V2 2/4] drivers: qcom: rpmh-rsc: avoid locking in the interrupt handler Date: Wed, 24 Jul 2019 12:37:49 -0700 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <20190724145251.GB18620@codeaurora.org> Quoting Lina Iyer (2019-07-24 07:52:51) > On Tue, Jul 23 2019 at 14:11 -0600, Stephen Boyd wrote: > >Quoting Lina Iyer (2019-07-22 14:53:38) > >> Avoid locking in the interrupt context to improve latency. Since we > >> don't lock in the interrupt context, it is possible that we now could > >> race with the DRV_CONTROL register that writes the enable register and > >> cleared by the interrupt handler. For fire-n-forget requests, the > >> interrupt may be raised as soon as the TCS is triggered and the IRQ > >> handler may clear the enable bit before the DRV_CONTROL is read back. > >> > >> Use the non-sync variant when enabling the TCS register to avoid reading > >> back a value that may been cleared because the interrupt handler ran > >> immediately after triggering the TCS. > >> > >> Signed-off-by: Lina Iyer <email@example.com> > >> --- > > > >I have to read this patch carefully. The commit text isn't convincing me > >that it is actually safe to make this change. It mostly talks about the > >performance improvements and how we need to fix __tcs_trigger(), which > >is good, but I was hoping to be convinced that not grabbing the lock > >here is safe. > > > >How do we ensure that drv->tcs_in_use is cleared before we call > >tcs_write() and try to look for a free bit? Isn't it possible that we'll > >get into a situation where the bitmap is all used up but the hardware > >has just received an interrupt and is going to clear out a bit and then > >an rpmh write fails with -EBUSY? > > > If we have a situation where there are no available free bits, we retry > and that is part of the function. Since we have only 2 TCSes avaialble > to write to the hardware and there could be multiple requests coming in, > it is a very common situation. We try and acquire the drv->lock and if > there are free TCS available and if available mark them busy and send > our requests. If there are none available, we keep retrying. > Ok. I wonder if we need some sort of barriers here too, like an smp_mb__after_atomic()? That way we can make sure that the write to clear the bit is seen by another CPU that could be spinning forever waiting for that bit to be cleared? Before this change the spinlock would be guaranteed to make these barriers for us, but now that doesn't seem to be the case. I really hope that this whole thing can be changed to be a mutex though, in which case we can use the bit_wait() API, etc. to put tasks to sleep while RPMh is processing things.
next prev parent reply index Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-22 21:53 [PATCH V2 1/4] drivers: qcom: rpmh-rsc: simplify TCS locking Lina Iyer 2019-07-22 21:53 ` [PATCH V2 2/4] drivers: qcom: rpmh-rsc: avoid locking in the interrupt handler Lina Iyer 2019-07-23 20:11 ` Stephen Boyd 2019-07-24 14:52 ` Lina Iyer 2019-07-24 19:37 ` Stephen Boyd [this message] 2019-07-24 20:36 ` Lina Iyer 2019-07-24 23:27 ` Doug Anderson 2019-07-25 15:18 ` Lina Iyer 2019-07-25 15:39 ` Doug Anderson 2019-07-29 19:01 ` Lina Iyer 2019-07-29 20:56 ` Stephen Boyd 2019-07-30 17:29 ` Lina Iyer 2019-07-22 21:53 ` [PATCH V2 3/4] drivers: qcom: rpmh: switch over from spinlock irq variants Lina Iyer 2019-07-23 18:24 ` Stephen Boyd 2019-07-22 21:53 ` [PATCH V2 4/4] drivers: qcom: rpmh-rsc: remove redundant register access Lina Iyer 2019-07-23 18:22 ` [PATCH V2 1/4] drivers: qcom: rpmh-rsc: simplify TCS locking Stephen Boyd 2019-07-23 19:21 ` Lina Iyer 2019-07-23 20:18 ` Stephen Boyd 2019-07-24 14:54 ` Lina Iyer 2019-07-24 18:32 ` Stephen Boyd 2019-07-24 19:36 ` Lina Iyer
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ARM-MSM Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \ firstname.lastname@example.org email@example.com public-inbox-index linux-arm-msm Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm AGPL code for this site: git clone https://public-inbox.org/ public-inbox