From: Stephen Boyd <swboyd@chromium.org>
To: Amit Kucheria <amit.kucheria@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
agross@kernel.org, bjorn.andersson@linaro.org,
edubezval@gmail.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, marc.w.gonzalez@free.fr,
masneyb@onstation.org
Cc: linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 14/15] drivers: thermal: tsens: Create function to return sign-extended temperature
Date: Tue, 27 Aug 2019 17:38:20 -0700 [thread overview]
Message-ID: <5d65ccfd.1c69fb81.95798.20d8@mx.google.com> (raw)
In-Reply-To: <64a3d07ebe5c4cfb4643d91f5f6605e8a4ffa48b.1566907161.git.amit.kucheria@linaro.org>
Quoting Amit Kucheria (2019-08-27 05:14:10)
> diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> index ea2c46cc6a66a..06b44cfd5eab9 100644
> --- a/drivers/thermal/qcom/tsens-common.c
> +++ b/drivers/thermal/qcom/tsens-common.c
> @@ -84,13 +84,43 @@ static inline int code_to_degc(u32 adc_code, const struct tsens_sensor *s)
> return degc;
> }
>
> +/**
> + * tsens_hw_to_mC - Return sign-extended temperature in mCelsius.
> + * @s: Pointer to sensor struct
sensor? This isn't golang!
> + * @field: Index into regmap_field array pointing to temperature data
> + *
> + * This function handles temperature returned in ADC code or deciCelsius
> + * depending on IP version.
> + *
> + * Return: Temperature in milliCelsius on success, a negative errno will
> + * be returned in error cases
> + */
> +static int tsens_hw_to_mC(struct tsens_sensor *s, int field)
> +{
> + struct tsens_priv *priv = s->priv;
> + u32 temp = 0;
> + int ret;
> +
> + ret = regmap_field_read(priv->rf[field], &temp);
> + if (ret)
> + return ret;
> +
> + if (priv->feat->adc) {
> + /* Convert temperature from ADC code to milliCelsius */
Nitpick: Move this comment above the if and drop the braces.
> + return code_to_degc(temp, s) * 1000;
> + }
> +
> + /* deciCelsius -> milliCelsius along with sign extension */
> + return sign_extend32(temp, priv->tempres) * 100;
> +}
> +
> int get_temp_tsens_valid(struct tsens_sensor *s, int *temp)
> {
> struct tsens_priv *priv = s->priv;
> int hw_id = s->hw_id;
> u32 temp_idx = LAST_TEMP_0 + hw_id;
> u32 valid_idx = VALID_0 + hw_id;
> - u32 last_temp = 0, valid, mask;
> + u32 valid;
> int ret;
>
> ret = regmap_field_read(priv->rf[valid_idx], &valid);
> @@ -310,6 +328,10 @@ int __init init_common(struct tsens_priv *priv)
> goto err_put_device;
> }
> }
> +
> + /* Save away resolution of signed temperature value for this IP */
> + priv->tempres = priv->fields[LAST_TEMP_0].msb - priv->fields[LAST_TEMP_0].lsb;
> +
Why not just calculate this in the function that uses it? Is there a
reason to stash it away in the struct?
> for (i = 0, j = VALID_0; i < priv->feat->max_sensors; i++, j++) {
> priv->rf[j] = devm_regmap_field_alloc(dev, priv->tm_map,
> priv->fields[j]);
next prev parent reply other threads:[~2019-08-28 0:38 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 12:13 [PATCH v2 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
2019-08-27 12:13 ` [PATCH v2 01/15] drivers: thermal: tsens: Get rid of id field in tsens_sensor Amit Kucheria
2019-08-27 12:13 ` [PATCH v2 02/15] drivers: thermal: tsens: Simplify code flow in tsens_probe Amit Kucheria
2019-08-27 12:13 ` [PATCH v2 03/15] drivers: thermal: tsens: Add __func__ identifier to debug statements Amit Kucheria
2019-08-29 14:04 ` Daniel Thompson
2019-08-29 14:28 ` Amit Kucheria
2019-08-29 15:19 ` Daniel Thompson
2019-08-29 16:14 ` Amit Kucheria
2019-08-29 16:34 ` Daniel Thompson
2019-08-27 12:14 ` [PATCH v2 04/15] drivers: thermal: tsens: Add debugfs support Amit Kucheria
2019-08-28 0:31 ` Stephen Boyd
2019-08-27 12:14 ` [PATCH v2 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor Amit Kucheria
2019-08-28 0:32 ` Stephen Boyd
2019-08-27 12:14 ` [PATCH v2 06/15] arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors Amit Kucheria
2019-08-28 0:32 ` Stephen Boyd
2019-08-27 12:14 ` [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver Amit Kucheria
2019-08-28 0:33 ` Stephen Boyd
2019-08-29 8:48 ` Amit Kucheria
2019-08-29 14:53 ` Stephen Boyd
2019-08-29 16:34 ` Amit Kucheria
2019-08-30 11:32 ` Amit Kucheria
2019-08-30 15:55 ` Stephen Boyd
2019-08-30 16:40 ` Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 08/15] arm64: dts: sdm845: thermal: Add interrupt support Amit Kucheria
2019-08-28 0:34 ` Stephen Boyd
2019-08-27 12:14 ` [PATCH v2 09/15] arm64: dts: msm8996: " Amit Kucheria
2019-08-28 0:35 ` Stephen Boyd
2019-08-30 20:10 ` Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 10/15] arm64: dts: msm8998: " Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 11/15] arm64: dts: qcs404: " Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 12/15] arm: dts: msm8974: " Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 13/15] arm64: dts: msm8916: " Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 14/15] drivers: thermal: tsens: Create function to return sign-extended temperature Amit Kucheria
2019-08-28 0:38 ` Stephen Boyd [this message]
[not found] ` <CAP245DVGY6+vue_REqy=Tbvka2fcBx6XhSBePW4L3=pNagX=Dw@mail.gmail.com>
2019-08-28 15:44 ` Stephen Boyd
2019-08-27 12:14 ` [PATCH v2 15/15] drivers: thermal: tsens: Add interrupt support Amit Kucheria
2019-08-28 21:42 ` Stephen Boyd
2019-08-29 12:30 ` Amit Kucheria
2019-08-29 14:54 ` Stephen Boyd
2019-08-29 3:53 ` Thara Gopinath
2019-09-10 16:01 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d65ccfd.1c69fb81.95798.20d8@mx.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).