From: Stephen Boyd <swboyd@chromium.org>
To: Amit Kucheria <amit.kucheria@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Eduardo Valentin <edubezval@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: linux-pm@vger.kernel.org
Subject: Re: [PATCH] of-thermal: Disable polling when interrupt property is found in DT
Date: Tue, 15 Oct 2019 21:57:30 -0700 [thread overview]
Message-ID: <5da6a33b.1c69fb81.64cc.6834@mx.google.com> (raw)
In-Reply-To: <1b53ef537203e629328285b4597a09e4a586d688.1571181041.git.amit.kucheria@linaro.org>
Quoting Amit Kucheria (2019-10-15 16:13:16)
> Currently, in order to enable interrupt-only mode, one must set
> polling-delay-passive and polling-delay properties in the DT to 0,
> otherwise the thermal framework will continue to setup a periodic timers
> to monitor the thermal zones.
>
> Change the behaviour, so that on DT-based systems, we no longer have to
> set the properties to zero if we find an 'interrupt' property in the
> sensor.
>
> Following data shows the number of times
> thermal_zone_device_set_polling() is invoked with and without this
> patch. So the patch achieves the same behaviour as setting the delay
> properties to 0.
>
> Current behaviour (without setting delay properties to 0):
> FUNC COUNT
> thermal_zone_device_update 302
> thermal_zone_device_set_pollin 7911
thermal_zone_device_set_polling?
>
> Current behaviour (with delay properties set to 0):
> FUNC COUNT
> thermal_zone_device_update 3
> thermal_zone_device_set_pollin 6
>
> With this patch (without setting delay properties to 0):
> FUNC COUNT
> thermal_zone_device_update 3
> thermal_zone_device_set_pollin 6
>
> Suggested-by: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
next prev parent reply other threads:[~2019-10-16 4:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1571181041.git.amit.kucheria@linaro.org>
2019-10-15 23:13 ` [PATCH] of-thermal: Disable polling when interrupt property is found in DT Amit Kucheria
2019-10-16 4:57 ` Stephen Boyd [this message]
2019-10-16 5:22 ` Amit Kucheria
2019-10-30 6:51 ` Daniel Lezcano
2019-11-04 6:26 ` Amit Kucheria
2019-11-07 12:49 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5da6a33b.1c69fb81.64cc.6834@mx.google.com \
--to=swboyd@chromium.org \
--cc=amit.kucheria@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).