From: Jishnu Prakash <jprakash@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
mka@chromium.org, linus.walleij@linaro.org,
Jonathan.Cameron@huawei.com, smohanad@codeaurora.org,
kgunda@codeaurora.org, aghayal@codeaurora.org,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Mark Rutland <mark.rutland@arm.com>,
linux-iio@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V2 2/3] iio: adc: Add PMIC7 ADC bindings
Date: Mon, 27 Apr 2020 18:24:43 +0530 [thread overview]
Message-ID: <5de6ad40-1ce6-6f53-15d8-236f0685a2bb@codeaurora.org> (raw)
In-Reply-To: <20200420220244.GA32739@bogus>
Hi Rob,
On 4/21/2020 3:32 AM, Rob Herring wrote:
> On Wed, Apr 15, 2020 at 02:47:45PM +0530, Jishnu Prakash wrote:
>> of 512 will be used.
>> - For compatible property "qcom,spmi-adc5", valid values are 250, 420
>> and 840. If property is not found, default value of 840 is used.
>> + - For compatible property "qcom,spmi-adc7", valid values are 85, 340
>> + and 1360. If property is not found, default value of 1360 is used.
> We express constraints in schema now, don't duplicate with free form
> text.
I'll remove the redundant parts of the descriptions in the next post.
>
>> - For compatible property "qcom,spmi-adc-rev2", valid values are 256,
>> 512 and 1024. If property is not present, default value is 1024.
>> + then:
>> + patternProperties:
>> + "^.*@[0-9a-fx]+$":
> 'x' should not be in unit-addresses.
I'll remove it in the next post.
>
>> + properties:
>> + qcom,decimation:
>> + items:
> Not an array, so 'items' doesn't make sense here.
I'll remove it in the next post.
>
>> + enum: [ 85, 340, 1360 ]
>> + default: 1360
>> +
>>
next prev parent reply other threads:[~2020-04-27 12:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 9:17 [PATCH V2 0/3] iio: adc: Add support for QCOM SPMI PMIC7 ADC Jishnu Prakash
2020-04-15 9:17 ` [PATCH V2 1/3] iio: adc: Convert the QCOM SPMI ADC bindings to .yaml format Jishnu Prakash
2020-04-16 20:42 ` Rob Herring
2020-04-27 12:53 ` Jishnu Prakash
2020-04-18 16:22 ` Jonathan Cameron
2020-04-27 12:53 ` Jishnu Prakash
2020-04-15 9:17 ` [PATCH V2 2/3] iio: adc: Add PMIC7 ADC bindings Jishnu Prakash
2020-04-18 16:18 ` Jonathan Cameron
2020-04-27 12:55 ` Jishnu Prakash
2020-04-20 22:02 ` Rob Herring
2020-04-27 12:54 ` Jishnu Prakash [this message]
2020-04-15 9:17 ` [PATCH V2 3/3] iio: adc: Add support for PMIC7 ADC Jishnu Prakash
2020-04-17 10:21 ` Andy Shevchenko
[not found] ` <68d9c770-b190-dd13-0869-fdae9fb1f16f@codeaurora.org>
2020-04-27 13:28 ` Andy Shevchenko
2020-05-13 9:20 ` Jishnu Prakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5de6ad40-1ce6-6f53-15d8-236f0685a2bb@codeaurora.org \
--to=jprakash@codeaurora.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=aghayal@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kgunda@codeaurora.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
--cc=smohanad@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).