From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C44BC2D0CE for ; Tue, 21 Jan 2020 18:38:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D3CE24125 for ; Tue, 21 Jan 2020 18:38:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lZ+0PgQl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729261AbgAUSis (ORCPT ); Tue, 21 Jan 2020 13:38:48 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:45070 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729081AbgAUSis (ORCPT ); Tue, 21 Jan 2020 13:38:48 -0500 Received: by mail-pl1-f193.google.com with SMTP id b22so1689366pls.12 for ; Tue, 21 Jan 2020 10:38:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:subject:cc:to:from:user-agent:date; bh=WxV6dyVTVKbwDTmHI1PEXvBt0/vhMfR4VpCjB4pvFvc=; b=lZ+0PgQlkA83kPsDqHEx2g3dps1viqHOORC844RNZ+tHapd3BQc+nmgo4t8nSae01E xDpqcE2e1iX2owmIN7FWLTcTYZu0/l3O0xpT/YopxdT2mWlNypPECQspMPm9KU2drTTu mp71fiR7tsMS/3H97dHAyUorzIKI3EwsmTZJA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:subject:cc:to:from :user-agent:date; bh=WxV6dyVTVKbwDTmHI1PEXvBt0/vhMfR4VpCjB4pvFvc=; b=m8WK2KqDJ2s38XIUetW/IBLH12eAak0a+H7kfIq5rxjLAJ7q1Sun/0JnW8ph2e8F8h jxeT0/8GB2JlabrHiiXGb8+yx2WPpNPlbM2uE0DPh7v/qk6Zm41BLJZWHPhD9hCC/5Ot hvdJqJBdbUn3fjeEIhxjJC3h7ha02jY5fOs9+L8OSwBEbBrhWntJ2QWKPCgDsEyqFcUW oqSeVJyus/KKetgfKQaSz3/2UdxzJkJ9RrKMZ+0xPUZBsJVBmARc1nKUV9xcBXb2SPAG cEJcdqKQjD8V0+ZmCW7kJGaSl5bmGIHVLI0M5eOedF5SHZTXZ+BD54E/4as/YPhozEXR DFZQ== X-Gm-Message-State: APjAAAU5PDJW3lMyfg+CrDfB/0/bQECy7iW3HBt4axHc6X7W8QDzhDfJ YX50uAu+iJzzKF/tMeNIwNnRMSBkok0RXQ== X-Google-Smtp-Source: APXvYqxWT3/UBuZQoVoxdqELNaCNFWPct/1TYX2wzaBljeyZhH2i9hUMGIUjJWCMLn58ARqKvTTnOw== X-Received: by 2002:a17:90a:e2ce:: with SMTP id fr14mr6675221pjb.99.1579631927609; Tue, 21 Jan 2020 10:38:47 -0800 (PST) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id i3sm45853513pfo.72.2020.01.21.10.38.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 10:38:47 -0800 (PST) Message-ID: <5e274537.1c69fb81.a77e7.08fd@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200121183519.GP1511@yoga> References: <20200121180950.36959-1-swboyd@chromium.org> <20200121183519.GP1511@yoga> Subject: Re: [PATCH] pinctrl: qcom: Don't lock around irq_set_irq_wake() Cc: Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, Douglas Anderson , Brian Masney , Lina Iyer , Maulik Shah To: Bjorn Andersson From: Stephen Boyd User-Agent: alot/0.8.1 Date: Tue, 21 Jan 2020 10:38:46 -0800 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Bjorn Andersson (2020-01-21 10:35:19) > On Tue 21 Jan 10:09 PST 2020, Stephen Boyd wrote: >=20 > > __vfs_write+0x54/0x18c > > vfs_write+0xe4/0x1a4 > > ksys_write+0x7c/0xe4 > > __arm64_sys_write+0x20/0x2c > > el0_svc_common+0xa8/0x160 > > el0_svc_handler+0x7c/0x98 > > el0_svc+0x8/0xc > >=20 > > Fixes: f365be092572 ("pinctrl: Add Qualcomm TLMM driver") >=20 > This lock used to protect the wake_irqs bitmap, and although your change > indicates that the locking was wrong before this point I think the fixes > should be: >=20 > Fixes: 6aced33f4974 ("pinctrl: msm: drop wake_irqs bitmap") >=20 >=20 > Either way, the patch looks good. >=20 > Reviewed-by: Bjorn Andersson >=20 Ok. Thanks for fixing the Fixes tag.