From: "chenxiang (M)" <chenxiang66@hisilicon.com>
To: Joerg Roedel <joro@8bytes.org>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Cc: Will Deacon <will@kernel.org>, <linux-kernel@vger.kernel.org>,
<iommu@lists.linux-foundation.org>,
<linux-arm-msm@vger.kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
<linux-arm-kernel@lists.infradead.org>, <linuxarm@huawei.com>
Subject: Re: [PATCH] iommu: Add device name to iommu map/unmap trace events
Date: Tue, 6 Apr 2021 14:56:53 +0800 [thread overview]
Message-ID: <626fbcb8-b84f-1522-4ec3-9c7c1f5f7a93@hisilicon.com> (raw)
In-Reply-To: <20210212105039.GG7302@8bytes.org>
Hi,
在 2021/2/12 18:50, Joerg Roedel 写道:
> On Tue, Feb 09, 2021 at 06:06:20PM +0530, Sai Prakash Ranjan wrote:
>> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
>> index 5e7fe519430a..6064187d9bb6 100644
>> --- a/include/linux/iommu.h
>> +++ b/include/linux/iommu.h
>> @@ -87,6 +87,7 @@ struct iommu_domain {
>> void *handler_token;
>> struct iommu_domain_geometry geometry;
>> void *iova_cookie;
>> + char dev_name[32];
>> };
> No, definitly not. A domain is a device DMA address space which can be
> used by more than one device. Just look at IOMMU groups with more than
> one member device, in this case just one device name would be very
> misleading.
Is it possible to use group id to identify different domains?
>
> Regards,
>
> Joerg
> _______________________________________________
> iommu mailing list
> iommu@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
>
> .
>
next prev parent reply other threads:[~2021-04-06 6:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 12:36 [PATCH] iommu: Add device name to iommu map/unmap trace events Sai Prakash Ranjan
2021-02-12 10:50 ` Joerg Roedel
2021-04-06 6:56 ` chenxiang (M) [this message]
2021-04-06 9:08 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=626fbcb8-b84f-1522-4ec3-9c7c1f5f7a93@hisilicon.com \
--to=chenxiang66@hisilicon.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=robin.murphy@arm.com \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).